Closes issue #8363: Call startForegroundService instead of startService on DownloadMiddleware

import android.content.Context

import android.content.Intent

import androidx.annotation.VisibleForTesting

import androidx.core.content.ContextCompat

import kotlinx.coroutines.CoroutineScope

import kotlinx.coroutines.Dispatchers

import kotlinx.coroutines.InternalCoroutinesApi

        if (download.status !in arrayOf(COMPLETED, CANCELLED)) {

            val intent = Intent(applicationContext, downloadServiceClass)

            intent.putExtra(DownloadManager.EXTRA_DOWNLOAD_ID, download.id)

            applicationContext.startService(intent)

            startForegroundService(intent)

            logger.debug("Sending download intent ${download.fileName}")

        }

    }

    @VisibleForTesting

    internal fun startForegroundService(intent: Intent) {

        ContextCompat.startForegroundService(applicationContext, intent)

    }

}

import org.mockito.Mockito.verify

import org.mockito.Mockito.times

import org.mockito.Mockito.never

import org.mockito.Mockito.spy

@RunWith(AndroidJUnit4::class)

class DownloadMiddlewareTest {

    @Test

    fun `service is started when download is queued`() = runBlockingTest {

        val applicationContext: Context = mock()

        val downloadMiddleware = DownloadMiddleware(

        val downloadMiddleware = spy(DownloadMiddleware(

            applicationContext,

            AbstractFetchDownloadService::class.java,

            coroutineContext = dispatcher,

            downloadStorage = mock()

        )

        ))

        val store = BrowserStore(

            initialState = BrowserState(),

            middleware = listOf(downloadMiddleware)

        store.dispatch(DownloadAction.AddDownloadAction(download)).joinBlocking()

        val intentCaptor = argumentCaptor<Intent>()

        verify(applicationContext).startService(intentCaptor.capture())

        verify(downloadMiddleware).startForegroundService(intentCaptor.capture())

        assertEquals(download.id, intentCaptor.value.getStringExtra(EXTRA_DOWNLOAD_ID))

    }