Commit 6ed052d4 authored by MozLando's avatar MozLando
Browse files

Merge #5146



5146: Closes #5144: Fix GeckoWebPushHandler API signature update r=pocmo a=jonalmeida
Co-authored-by: default avatarJonathan Almeida <jalmeida@mozilla.com>
parents 2cb7e37a 0a742910
......@@ -6,7 +6,7 @@ internal object GeckoVersions {
/**
* GeckoView Nightly Version.
*/
const val nightly_version = "72.0.20191119043902"
const val nightly_version = "72.0.20191125095200"
/**
* GeckoView Beta Version.
......
......@@ -19,8 +19,8 @@ internal class GeckoWebPushHandler(
/**
* See [WebPushHandler].
*/
override fun onPushMessage(subscription: WebPushSubscription, message: ByteArray?) {
runtime.webPushController.onPushEvent(subscription.toGeckoSubscription(), message)
override fun onPushMessage(scope: String, message: ByteArray?) {
runtime.webPushController.onPushEvent(scope, message)
}
/**
......
......@@ -39,7 +39,7 @@ class GeckoWebPushHandlerTest {
ByteArray(16)
)
handler.onPushMessage(subscription, null)
handler.onPushMessage("", null)
verify(controller).onPushEvent(any(), isNull())
......
......@@ -16,10 +16,10 @@ interface WebPushHandler {
/**
* Invoked when a push message has been delivered.
*
* @param subscription A [WebPushSubscription] for the messaged delivered.
* @param scope The subscription identifier which usually represents the website's URI.
* @param message A [ByteArray] message.
*/
fun onPushMessage(subscription: WebPushSubscription, message: ByteArray?)
fun onPushMessage(scope: String, message: ByteArray?)
/**
* Invoked when a subscription has now changed/expired.
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment