Commit a24b3dd7 authored by Sebastian Kaspari's avatar Sebastian Kaspari
Browse files

Closes #2736: Update GeckoView Nightly to 68.0.20190414095735.

parent d5ff92cb
......@@ -6,7 +6,7 @@ internal object GeckoVersions {
/**
* GeckoView Nightly Version.
*/
const val nightly_version = "68.0.20190409095652"
const val nightly_version = "68.0.20190414095735"
/**
* GeckoView Beta Version.
......
......@@ -775,7 +775,10 @@ class GeckoEngineSessionTest {
assertEquals(TrackingProtectionPolicy.SOCIAL, ContentBlocking.AT_SOCIAL)
assertEquals(TrackingProtectionPolicy.TEST, ContentBlocking.AT_TEST)
assertEquals(TrackingProtectionPolicy.all().categories and TrackingProtectionPolicy.CRYPTOMINING.inv(),
assertEquals(
TrackingProtectionPolicy.all().categories and
TrackingProtectionPolicy.CRYPTOMINING.inv() and
TrackingProtectionPolicy.FINGERPRINTING.inv(),
ContentBlocking.AT_ALL)
}
......
......@@ -340,7 +340,7 @@ internal class GeckoPromptDelegate(private val geckoEngineSession: GeckoEngineSe
private fun GeckoChoice.toChoice(): Choice {
val choiceChildren = items?.map { it.toChoice() }?.toTypedArray()
return Choice(id, !disabled, label ?: "", selected, separator, choiceChildren)
return Choice(id, !disabled, label, selected, separator, choiceChildren)
}
/**
......
......@@ -761,6 +761,7 @@ class GeckoEngineSessionTest {
assertEquals(TrackingProtectionPolicy.SOCIAL, ContentBlocking.AT_SOCIAL)
assertEquals(TrackingProtectionPolicy.TEST, ContentBlocking.AT_TEST)
assertEquals(TrackingProtectionPolicy.CRYPTOMINING, ContentBlocking.AT_CRYPTOMINING)
assertEquals(TrackingProtectionPolicy.FINGERPRINTING, ContentBlocking.AT_FINGERPRINTING)
assertEquals(TrackingProtectionPolicy.all().categories, ContentBlocking.AT_STRICT)
}
......
......@@ -113,7 +113,8 @@ class GeckoEngineTest {
TrackingProtectionPolicy.ANALYTICS,
TrackingProtectionPolicy.CONTENT,
TrackingProtectionPolicy.TEST,
TrackingProtectionPolicy.CRYPTOMINING
TrackingProtectionPolicy.CRYPTOMINING,
TrackingProtectionPolicy.FINGERPRINTING
).categories, contentBlockingSettings.categories)
assertEquals(defaultSettings.trackingProtectionPolicy, TrackingProtectionPolicy.all())
......@@ -160,7 +161,8 @@ class GeckoEngineTest {
TrackingProtectionPolicy.ANALYTICS,
TrackingProtectionPolicy.CONTENT,
TrackingProtectionPolicy.TEST,
TrackingProtectionPolicy.CRYPTOMINING
TrackingProtectionPolicy.CRYPTOMINING,
TrackingProtectionPolicy.FINGERPRINTING
).categories, contentBlockingSettings.categories)
assertTrue(engine.settings.testingModeEnabled)
assertEquals("test-ua", engine.settings.userAgentString)
......
......@@ -87,7 +87,8 @@ abstract class EngineSession(
// This policy is just to align categories with GeckoView (which has AT_TEST = 1 << 5)
const val TEST: Int = 1 shl 5
const val CRYPTOMINING = 1 shl 6
internal const val ALL: Int = AD + ANALYTICS + SOCIAL + CONTENT + TEST + CRYPTOMINING
const val FINGERPRINTING = 1 shl 7
internal const val ALL: Int = AD + ANALYTICS + SOCIAL + CONTENT + TEST + CRYPTOMINING + FINGERPRINTING
fun none(): TrackingProtectionPolicy = TrackingProtectionPolicy(NONE)
fun all() = TrackingProtectionPolicyForSessionTypes(ALL)
......
......@@ -23,6 +23,9 @@ permalink: /changelog/
* **browser-icons**
* ⚠️ **This is a breaking API change**: Creating a `BrowserIcons` instance requires a `Client` object (from `concept-fetch`) now.
* **browser-engine-gecko-nightly**:
* Added new content blocking category for [fingerprinting](https://en.wikipedia.org/wiki/Device_fingerprint): `TrackingProtectionPolicy.FINGERPRINTING`.
* **feature-findinpage**
* Find in Page now emits facts
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment