Commit a66754a1 authored by Denys M's avatar Denys M Committed by Sebastian Kaspari
Browse files

For #1481. Use androidx runner in `feature-qr`.

parent d0f4d77e

components/feature/qr/build.gradle

+3 −1
Original line number Diff line number Diff line
@@ -22,6 +22,8 @@ android { 
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'

        }

    }



    testOptions.unitTests.includeAndroidResources = true

}



dependencies {
@@ -38,7 +40,7 @@ dependencies { 


    testImplementation project(':support-test')

    testImplementation Dependencies.androidx_test_core

    testImplementation Dependencies.testing_junit

    testImplementation Dependencies.androidx_test_junit

    testImplementation Dependencies.testing_robolectric

    testImplementation Dependencies.testing_mockito

}

components/feature/qr/gradle.properties

0 → 100644
+2 −0
Original line number Diff line number Diff line 
# TODO remove and enable globally

android.enableUnitTestBinaryResources=true

components/feature/qr/src/test/java/mozilla/components/feature/qr/QrFeatureTest.kt

+14 −18
Original line number Diff line number Diff line
@@ -5,42 +5,38 @@ 
package mozilla.components.feature.qr



import android.Manifest

import android.content.Context

import android.content.pm.PackageManager

import androidx.fragment.app.FragmentManager

import androidx.fragment.app.FragmentTransaction

import androidx.test.core.app.ApplicationProvider

import androidx.test.ext.junit.runners.AndroidJUnit4

import mozilla.components.feature.qr.QrFeature.Companion.QR_FRAGMENT_TAG

import mozilla.components.support.test.any

import org.junit.Assert.assertTrue

import mozilla.components.support.test.robolectric.grantPermission

import mozilla.components.support.test.mock

import mozilla.components.support.test.robolectric.grantPermission

import mozilla.components.support.test.robolectric.testContext

import mozilla.components.support.test.whenever

import org.junit.Assert.assertEquals

import org.junit.Assert.assertFalse

import org.junit.Assert.assertTrue

import org.junit.Test

import org.junit.runner.RunWith

import org.mockito.ArgumentMatchers.anyInt

import org.mockito.ArgumentMatchers.anyString

import org.mockito.Mockito.`when`

import org.mockito.Mockito.doReturn

import org.mockito.Mockito.never

import org.mockito.Mockito.spy

import org.mockito.Mockito.verify

import org.robolectric.RobolectricTestRunner



@RunWith(RobolectricTestRunner::class)

@RunWith(AndroidJUnit4::class)

class QrFeatureTest {



    private val context: Context

        get() = ApplicationProvider.getApplicationContext()



    @Test

    fun `feature requests permission if required`() {

        val fragmentManager = mockFragmentManager()



        var permissionRequested = false



        val feature = QrFeature(context,

        val feature = QrFeature(testContext,

            fragmentManager = fragmentManager,

            onNeedToRequestPermissions = { permissionRequested = true }

        )
@@ -54,7 +50,7 @@ class QrFeatureTest { 
        val fragmentManager = mockFragmentManager()

        grantPermission(Manifest.permission.CAMERA)



        val feature = QrFeature(context,

        val feature = QrFeature(testContext,

            fragmentManager = fragmentManager,

            onNeedToRequestPermissions = { },

            onScanResult = { }
@@ -68,7 +64,7 @@ class QrFeatureTest { 
    fun `onPermissionsResult displays scanner only if permission granted`() {

        val fragmentManager = mockFragmentManager()



        val feature = QrFeature(context, fragmentManager = fragmentManager)

        val feature = QrFeature(testContext, fragmentManager = fragmentManager)



        assertFalse(feature.scan())
@@ -84,7 +80,7 @@ class QrFeatureTest { 
    fun `scan result is forwarded to caller`() {

        var scanResultReceived = ""



        val feature = QrFeature(context,

        val feature = QrFeature(testContext,

            fragmentManager = mockFragmentManager(),

            onScanResult = { result -> scanResultReceived = result }

        )
@@ -99,11 +95,11 @@ class QrFeatureTest { 
    fun `qr fragment is removed on back pressed`() {

        val fragmentManager = mockFragmentManager()

        val fragment: QrFragment = mock()

        `when`(fragmentManager.findFragmentByTag(QR_FRAGMENT_TAG)).thenReturn(fragment)

        whenever(fragmentManager.findFragmentByTag(QR_FRAGMENT_TAG)).thenReturn(fragment)



        val feature = spy(

            QrFeature(

                context,

                testContext,

                fragmentManager = fragmentManager,

                onScanResult = { }

            )
@@ -117,11 +113,11 @@ class QrFeatureTest { 
    fun `start attaches scan complete listener`() {

        val fragmentManager = mockFragmentManager()



        val feature = QrFeature(context, fragmentManager = fragmentManager, onScanResult = { })

        val feature = QrFeature(testContext, fragmentManager = fragmentManager, onScanResult = { })

        feature.start()



        val fragment: QrFragment = mock()

        `when`(fragmentManager.findFragmentByTag(QR_FRAGMENT_TAG)).thenReturn(fragment)

        whenever(fragmentManager.findFragmentByTag(QR_FRAGMENT_TAG)).thenReturn(fragment)

        feature.start()



        verify(fragment).scanCompleteListener = feature.scanCompleteListener

components/feature/qr/src/test/java/mozilla/components/feature/qr/QrFragmentTest.kt

+44 −46
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ import android.hardware.camera2.CameraDevice 
import android.hardware.camera2.CameraManager

import android.util.Size

import androidx.fragment.app.FragmentActivity

import androidx.test.ext.junit.runners.AndroidJUnit4

import com.google.zxing.BarcodeFormat

import com.google.zxing.BinaryBitmap

import com.google.zxing.MultiFormatReader
@@ -19,6 +20,7 @@ import mozilla.components.support.test.any 
import mozilla.components.support.test.argumentCaptor

import mozilla.components.support.test.eq

import mozilla.components.support.test.mock

import mozilla.components.support.test.whenever

import org.junit.Assert.assertEquals

import org.junit.Assert.assertNull

import org.junit.Assert.assertSame
@@ -26,22 +28,18 @@ import org.junit.Assert.fail 
import org.junit.Test

import org.junit.runner.RunWith

import org.mockito.ArgumentMatchers.anyInt

import org.mockito.Mockito.`when`

import org.mockito.Mockito.mock

import org.mockito.ArgumentMatchers.anyString

import org.mockito.Mockito.never

import org.mockito.Mockito.spy

import org.mockito.Mockito.times

import org.mockito.Mockito.verify

import org.robolectric.RobolectricTestRunner

import org.mockito.ArgumentMatchers.anyString

import java.lang.IllegalStateException



@RunWith(RobolectricTestRunner::class)

@RunWith(AndroidJUnit4::class)

class QrFragmentTest {



    @Test

    fun `initialize QR fragment`() {

        val scanCompleteListener = mock(QrFragment.OnScanCompleteListener::class.java)

        val scanCompleteListener = mock<QrFragment.OnScanCompleteListener>()

        val qrFragment = spy(QrFragment.newInstance(scanCompleteListener))



        qrFragment.scanCompleteListener?.onScanComplete("result")
@@ -50,7 +48,7 @@ class QrFragmentTest { 


    @Test

    fun `onPause closes camera and stops background thread`() {

        val qrFragment = spy(QrFragment.newInstance(mock(QrFragment.OnScanCompleteListener::class.java)))

        val qrFragment = spy(QrFragment.newInstance(mock()))

        qrFragment.onPause()



        verify(qrFragment).stopBackgroundThread()
@@ -59,14 +57,14 @@ class QrFragmentTest { 


    @Test

    fun `onResume opens camera and starts background thread`() {

        val qrFragment = spy(QrFragment.newInstance(mock(QrFragment.OnScanCompleteListener::class.java)))

        `when`(qrFragment.setUpCameraOutputs(anyInt(), anyInt())).then { }

        val qrFragment = spy(QrFragment.newInstance(mock()))

        whenever(qrFragment.setUpCameraOutputs(anyInt(), anyInt())).then { }



        qrFragment.textureView = mock()

        qrFragment.onResume()

        verify(qrFragment, never()).openCamera(anyInt(), anyInt())



        `when`(qrFragment.textureView.isAvailable).thenReturn(true)

        whenever(qrFragment.textureView.isAvailable).thenReturn(true)

        qrFragment.cameraId = "mockCamera"

        qrFragment.onResume()

        verify(qrFragment, times(2)).startBackgroundThread()
@@ -75,9 +73,9 @@ class QrFragmentTest { 


    @Test

    fun `onViewCreated sets initial state`() {

        val qrFragment = QrFragment.newInstance(mock(QrFragment.OnScanCompleteListener::class.java))

        val qrFragment = QrFragment.newInstance(mock())

        val view: AutoFitTextureView = mock()

        `when`(view.findViewById<AutoFitTextureView>(anyInt())).thenReturn(mock())

        whenever(view.findViewById<AutoFitTextureView>(anyInt())).thenReturn(mock())



        qrFragment.onViewCreated(view, mock())

        assertEquals(QrFragment.STATE_FIND_QRCODE, QrFragment.qrState)
@@ -85,13 +83,13 @@ class QrFragmentTest { 


    @Test

    fun `async scanning task invokes listener on successful qr scan`() {

        val listener = mock(QrFragment.OnScanCompleteListener::class.java)

        val reader = mock(MultiFormatReader::class.java)

        val listener = mock<QrFragment.OnScanCompleteListener>()

        val reader = mock<MultiFormatReader>()

        val task = QrFragment.AsyncScanningTask(listener, reader)



        val bitmap = mock(BinaryBitmap::class.java)

        val bitmap = mock<BinaryBitmap>()

        val result = com.google.zxing.Result("qrcode-result", ByteArray(0), emptyArray(), BarcodeFormat.ITF)

        `when`(reader.decodeWithState(any())).thenReturn(result)

        whenever(reader.decodeWithState(any())).thenReturn(result)



        QrFragment.qrState = QrFragment.STATE_DECODE_PROGRESS

        task.processImage(bitmap)
@@ -102,12 +100,12 @@ class QrFragmentTest { 


    @Test

    fun `async scanning task resets state on error`() {

        val listener = mock(QrFragment.OnScanCompleteListener::class.java)

        val reader = mock(MultiFormatReader::class.java)

        val listener = mock<QrFragment.OnScanCompleteListener>()

        val reader = mock<MultiFormatReader>()

        val task = QrFragment.AsyncScanningTask(listener, reader)



        val bitmap = mock(BinaryBitmap::class.java)

        `when`(reader.decodeWithState(any())).thenThrow(NotFoundException::class.java)

        val bitmap = mock<BinaryBitmap>()

        whenever(reader.decodeWithState(any())).thenThrow(NotFoundException::class.java)



        QrFragment.qrState = QrFragment.STATE_DECODE_PROGRESS

        task.processImage(bitmap)
@@ -117,12 +115,12 @@ class QrFragmentTest { 


    @Test

    fun `async scanning task does nothing if decoding not in progress`() {

        val listener = mock(QrFragment.OnScanCompleteListener::class.java)

        val reader = mock(MultiFormatReader::class.java)

        val listener = mock<QrFragment.OnScanCompleteListener>()

        val reader = mock<MultiFormatReader>()

        val task = QrFragment.AsyncScanningTask(listener, reader)



        val bitmap = mock(BinaryBitmap::class.java)

        `when`(reader.decodeWithState(any())).thenThrow(NotFoundException::class.java)

        val bitmap = mock<BinaryBitmap>()

        whenever(reader.decodeWithState(any())).thenThrow(NotFoundException::class.java)



        QrFragment.qrState = QrFragment.STATE_FIND_QRCODE

        assertNull(task.processImage(bitmap))
@@ -131,12 +129,12 @@ class QrFragmentTest { 


    @Test

    fun `async scanning decodes original unmodified image`() {

        val listener = mock(QrFragment.OnScanCompleteListener::class.java)

        val reader = mock(MultiFormatReader::class.java)

        val listener = mock<QrFragment.OnScanCompleteListener>()

        val reader = mock<MultiFormatReader>()

        val task = QrFragment.AsyncScanningTask(listener, reader)

        val imageCaptor = argumentCaptor<BinaryBitmap>()



        val bitmap = mock(BinaryBitmap::class.java)

        val bitmap = mock<BinaryBitmap>()



        QrFragment.qrState = QrFragment.STATE_DECODE_PROGRESS

        task.processImage(bitmap)
@@ -146,7 +144,7 @@ class QrFragmentTest { 


    @Test

    fun `camera is closed on disconnect and error`() {

        val qrFragment = spy(QrFragment.newInstance(mock(QrFragment.OnScanCompleteListener::class.java)))

        val qrFragment = spy(QrFragment.newInstance(mock()))



        var camera: CameraDevice = mock()

        qrFragment.stateCallback.onDisconnected(camera)
@@ -159,14 +157,14 @@ class QrFragmentTest { 


    @Test

    fun `catches and handles CameraAccessException when creating preview session`() {

        val qrFragment = spy(QrFragment.newInstance(mock(QrFragment.OnScanCompleteListener::class.java)))

        val qrFragment = spy(QrFragment.newInstance(mock()))



        var camera: CameraDevice = mock()

        `when`(camera.createCaptureRequest(anyInt())).thenThrow(CameraAccessException(123))

        val camera: CameraDevice = mock()

        whenever(camera.createCaptureRequest(anyInt())).thenThrow(CameraAccessException(123))

        qrFragment.cameraDevice = camera



        val textureView: AutoFitTextureView = mock()

        `when`(textureView.surfaceTexture).thenReturn(mock())

        whenever(textureView.surfaceTexture).thenReturn(mock())

        qrFragment.textureView = textureView



        qrFragment.previewSize = mock()
@@ -180,14 +178,14 @@ class QrFragmentTest { 


    @Test

    fun `catches and handles IllegalStateException when creating preview session`() {

        val qrFragment = spy(QrFragment.newInstance(mock(QrFragment.OnScanCompleteListener::class.java)))

        val qrFragment = spy(QrFragment.newInstance(mock()))



        var camera: CameraDevice = mock()

        `when`(camera.createCaptureRequest(anyInt())).thenThrow(IllegalStateException("CameraDevice was already closed"))

        val camera: CameraDevice = mock()

        whenever(camera.createCaptureRequest(anyInt())).thenThrow(IllegalStateException("CameraDevice was already closed"))

        qrFragment.cameraDevice = camera



        val textureView: AutoFitTextureView = mock()

        `when`(textureView.surfaceTexture).thenReturn(mock())

        whenever(textureView.surfaceTexture).thenReturn(mock())

        qrFragment.textureView = textureView



        qrFragment.previewSize = mock()
@@ -201,16 +199,16 @@ class QrFragmentTest { 


    @Test

    fun `catches and handles CameraAccessException when opening camera`() {

        val qrFragment = spy(QrFragment.newInstance(mock(QrFragment.OnScanCompleteListener::class.java)))

        `when`(qrFragment.setUpCameraOutputs(anyInt(), anyInt())).then { }

        val qrFragment = spy(QrFragment.newInstance(mock()))

        whenever(qrFragment.setUpCameraOutputs(anyInt(), anyInt())).then { }



        val cameraManager: CameraManager = mock()

        `when`(cameraManager.openCamera(anyString(), any<CameraDevice.StateCallback>(), any()))

        whenever(cameraManager.openCamera(anyString(), any<CameraDevice.StateCallback>(), any()))

                .thenThrow(CameraAccessException(123))



        val activity: FragmentActivity = mock()

        `when`(activity.getSystemService(Context.CAMERA_SERVICE)).thenReturn(cameraManager)

        `when`(qrFragment.activity).thenReturn(activity)

        whenever(activity.getSystemService(Context.CAMERA_SERVICE)).thenReturn(cameraManager)

        whenever(qrFragment.activity).thenReturn(activity)

        qrFragment.cameraId = "mockCamera"



        try {
@@ -222,13 +220,13 @@ class QrFragmentTest { 


    @Test

    fun `throws exception on device without camera`() {

        val qrFragment = spy(QrFragment.newInstance(mock(QrFragment.OnScanCompleteListener::class.java)))

        `when`(qrFragment.setUpCameraOutputs(anyInt(), anyInt())).then { }

        val qrFragment = spy(QrFragment.newInstance(mock()))

        whenever(qrFragment.setUpCameraOutputs(anyInt(), anyInt())).then { }



        val cameraManager: CameraManager = mock()

        val activity: FragmentActivity = mock()

        `when`(activity.getSystemService(Context.CAMERA_SERVICE)).thenReturn(cameraManager)

        `when`(qrFragment.activity).thenReturn(activity)

        whenever(activity.getSystemService(Context.CAMERA_SERVICE)).thenReturn(cameraManager)

        whenever(qrFragment.activity).thenReturn(activity)



        qrFragment.cameraId = null

        try {