Commit aacccbd7 authored by Sebastian Kaspari's avatar Sebastian Kaspari
Browse files

Closes #3738: Depend on "fat" GeckoView build from browser-engine-gecko-beta.

parent 48a1be86

automation/taskcluster/decision_task.py

+2 −2
Original line number Diff line number Diff line
@@ -92,12 +92,12 @@ def create_module_tasks(module): 
            "assembleOnly/Test": (

                ["ServoArm", "ServoX86", "SystemUniversal"],

                [

                    "GeckoBetaAarch64", "GeckoBetaArm", "GeckoBetaX86",

                    "GeckoBetaUniversal",

                    "GeckoNightlyUniversal",

                    "GeckoReleaseAarch64", "GeckoReleaseArm", "GeckoReleaseX86"

                ]

            ),

            "lintTask": "lintGeckoBetaArmDebug"

            "lintTask": "lintGeckoNightlyUniversal"

        },

        ":support-test": {

            "lintTask": "lint"

buildSrc/src/main/java/Gecko.kt

+1 −3
Original line number Diff line number Diff line
@@ -23,9 +23,7 @@ internal object GeckoVersions { 
object Gecko {

    const val geckoview_nightly = "org.mozilla.geckoview:geckoview-nightly:${GeckoVersions.nightly_version}"



    const val geckoview_beta_arm = "org.mozilla.geckoview:geckoview-beta-armeabi-v7a:${GeckoVersions.beta_version}"

    const val geckoview_beta_x86 = "org.mozilla.geckoview:geckoview-beta-x86:${GeckoVersions.beta_version}"

    const val geckoview_beta_aarch64 = "org.mozilla.geckoview:geckoview-beta-arm64-v8a:${GeckoVersions.beta_version}"

    const val geckoview_beta = "org.mozilla.geckoview:geckoview-beta:${GeckoVersions.beta_version}"



    const val geckoview_release_arm = "org.mozilla.geckoview:geckoview-armeabi-v7a:${GeckoVersions.release_version}"

    const val geckoview_release_x86 = "org.mozilla.geckoview:geckoview-x86:${GeckoVersions.release_version}"

components/browser/engine-gecko-beta/build.gradle

+1 −5
Original line number Diff line number Diff line
@@ -35,10 +35,7 @@ dependencies { 
    implementation Dependencies.kotlin_stdlib

    implementation Dependencies.kotlin_coroutines



    // We only compile against the ARM artifact. External module will decide which module to provide by build configuration.

    // As the Kotlin/Java API is the same for all ABIs it is not important which one we import here.

    compileOnly Gecko.geckoview_beta_arm

    testImplementation Gecko.geckoview_beta_arm

    api Gecko.geckoview_beta



    testImplementation Dependencies.androidx_test_core

    testImplementation Dependencies.androidx_test_junit
@@ -52,7 +49,6 @@ dependencies { 
    androidTestImplementation Dependencies.androidx_test_core

    androidTestImplementation Dependencies.androidx_test_runner

    androidTestImplementation Dependencies.androidx_test_rules

    androidTestImplementation Gecko.geckoview_beta_arm

    androidTestImplementation project(':tooling-fetch-tests')

}

components/browser/engine-gecko/build.gradle

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ dependencies { 
    androidTestImplementation Dependencies.androidx_test_core

    androidTestImplementation Dependencies.androidx_test_runner

    androidTestImplementation Dependencies.androidx_test_rules

    androidTestImplementation Gecko.geckoview_beta_arm

    androidTestImplementation Gecko.geckoview_release_arm

    androidTestImplementation project(':tooling-fetch-tests')

}

docs/changelog.md

+3 −0
Original line number Diff line number Diff line
@@ -18,6 +18,9 @@ permalink: /changelog/ 
    * `browser-engine-gecko-beta`: GeckoView 69.0

    * `browser-engine-gecko-nightly`: GeckoView 70.0



* **browser-engine-gecko-beta**

  * Like with the nightly flavor previously (0.55.0) this component now has a hard dependency on the new [universal GeckoView build](https://bugzilla.mozilla.org/show_bug.cgi?id=1508976) that is no longer architecture specific (ARM, x86, ..). With that apps no longer need to specify the GeckoView dependency themselves and synchronize the used version with Android Components. Additionally apps can now make use of [APK splits](https://developer.android.com/studio/build/configure-apk-splits) or [Android App Bundles (AAB)](https://developer.android.com/guide/app-bundle).



* **feature-media**

  * Added `MediaNotificationFeature` - a feature implementation to show an ongoing notification (keeping the app process alive) while web content is playing media.