Commit e8393845 authored by MickeyMoz's avatar MickeyMoz
Browse files

Merge #3991 

3991: Closes #3990: Update specs of browser menu r=pocmo a=sblatz

---
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not (this already includes tests)
- [x] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones

) of the version currently in development.


Co-authored-by: default avatarSawyer Blatz <sdblatz@gmail.com>
parents 9cd2b5ce a8b44de6

components/browser/menu/src/main/res/layout/mozac_browser_menu_item_toolbar.xml

+1 −1
Original line number Diff line number Diff line
@@ -5,6 +5,6 @@ 
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

    style="@android:style/TextAppearance.Material.Menu"

    android:layout_width="match_parent"

    android:layout_height="48dp"

    android:layout_height="@dimen/mozac_browser_menu_item_toolbar_height"

    android:gravity="center_vertical"

    android:orientation="horizontal" />

components/browser/menu/src/main/res/values/dimens.xml

+3 −1
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@ 
    <dimen name="mozac_browser_menu_corner_radius">4dp</dimen>

    <dimen name="mozac_browser_menu_elevation">8dp</dimen>

    <dimen name="mozac_browser_menu_width">250dp</dimen>

    <dimen name="mozac_browser_menu_padding_vertical">8dp</dimen>

    <dimen name="mozac_browser_menu_padding_vertical">0dp</dimen>



    <!--Menu Item -->

    <dimen name="mozac_browser_menu_item_text_size">16sp</dimen>
@@ -32,4 +32,6 @@ 


    <!--BrowserMenuImageText-->



    <!-- BrowserMenuItemToolbar -->

    <dimen name="mozac_browser_menu_item_toolbar_height">56dp</dimen>

</resources>

docs/changelog.md

+3 −0
Original line number Diff line number Diff line
@@ -12,6 +12,9 @@ permalink: /changelog/ 
* [Gecko](https://github.com/mozilla-mobile/android-components/blob/master/buildSrc/src/main/java/Gecko.kt)

* [Configuration](https://github.com/mozilla-mobile/android-components/blob/master/buildSrc/src/main/java/Config.kt)



* **browser-menu**

  * Updated the styling of the menu to not have padding on top or bottom. Also modified size of `BrowserMenuItemToolbar` to match `BrowserToolbar`'s height



# 8.0.0



* [Commits](https://github.com/mozilla-mobile/android-components/compare/v7.0.0...v8.0.0)