- 08 Sep, 2019 1 commit
-
-
MickeyMoz authored
-
- 06 Sep, 2019 13 commits
-
-
MozLando authored
4339: For #4302 - Adds the ability to override the basic shortcut name r=csadilek a=boek ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [x] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development. - [ ] **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser ) to address the breaking issues. Co-authored-by:
Jeff Boek <jeff@jeffboek.com>
-
Jeff Boek authored
-
MozLando authored
4330: Closes #3558: browser-state: Add engine session state and sync w/ browser-session r=pocmo a=csadilek Interestingly, we could live without an action for unlinking, as that only happens when the session is removed and since our new session state is immutable there's nothing to update, but for consistency/readability I've introduced it, plus there may be more use cases later. There's some special handling here for `restore`, as we first have to dispatch the restore action (which happens in the outer manager) before dispatching the link action (otherwise we won't find the session). Otherwise, all as discussed. I've named the object passed down to the legacy session manager "EngineSessionLinker", but better name suggestions welcome :) Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
Christian Sadilek authored
-
MozLando authored
4337: Update GV to 71.0.20190906094324 r=pocmo a=Dexterp37 This deals with the breaking change of the GV telemetry API. Co-authored-by:
Alessio Placitelli <alessio.placitelli@gmail.com>
-
MozLando authored
4338: Switch to regular set for Consumable listeners r=pocmo a=csadilek This was meant to prevent a footgun / accident leaks of session and context via the listeners, but of course, now that nothing else holds on to the listeners they could disappear (get gc'ed) and not be notified. Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
Christian Sadilek authored
- This was meant to prevent a footgun / accident leaks of session and context via the listeners, but of course, now that nothing else holds on to the listeners they could disappear (get gc'ed) and not be notified.
-
Alessio Placitelli authored
This deals with the breaking change of the GV telemetry API.
-
MozLando authored
4334: Docs update (20190906-121412) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MozLando authored
4327: Flow.ifChanged(): Added variant that takes a mapping function. r=csadilek a=pocmo This pattern emerged while migrating components. Often I want listen to value changes, but if the value changes then I need more than only the changed value. One example is the downloads feature. I want to listen to download changes. But if that changes then I need the whole `SessionState` object. Previously: ```kotlin scope = store.flowScoped { flow -> flow.mapNotNull { state -> state.findCustomTabOrSelectedTab(customTabId) } .map { it.content.download } .ifChanged() .collect { download -> // Okay, the DownloadState object now. But I also want the enclosing SessionState. } } ``` Now: ```kotlin scope = store.flowScoped { flow -> flow.mapNotNull { state -> state.findCustomTabOrSelectedTab(customTabId) } .ifChanged { it.content.download } .collect { state -> // Yay, I have the whole session state and can get // to the download by using state.content.download } } ``` Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com>
-
Sebastian Kaspari authored
-
MozLando authored
4331: Make BrowserAction names consistent r=pocmo a=csadilek Very minor refactoring, but since I just noticed. We could also decide to remove `Action` from all names, as they are usually prefixed with their type e.g. `TabListAction.AddTab`. Either way, I think we should keep them consistent. Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
- 05 Sep, 2019 20 commits
-
-
MozLando authored
4324: Closes #4320: Add api to indicate if strict social tracking protection r=csadilek a=Amejia481 Co-authored-by:
Arturo Mejia <arturomejiamarmol@gmail.com>
-
Arturo Mejia authored
-
Arturo Mejia authored
should be activated.
-
Christian Sadilek authored
-
MozLando authored
4316: Closes #4165: Add more logging for push r=csadilek a=jonalmeida This adds different levels of logging to the AutoPushFeature since we're not always able to tell from a release build in an app that a consumer has initialized their `PushService` successfully; that's a bit of a blackbox for us when it comes to testing in release. Co-authored-by:
Jonathan Almeida <jalmeida@mozilla.com>
-
MozLando authored
4106: fixes #1444 exposed title in HitResult and set image title as fragment title r=jonalmeida a=mcarare related Fenix issues : mozilla-mobile/fenix#4684 mozilla-mobile/fenix#580 added title in class Image & added title param in all usages. made it optional, with default null value, to keep WebView-based implementation of EngineView unchanged (SystemEngineView.kt) added title param in handleLongClick from 'element.title', as it is exposed by element information from gecko in ContextMenuCandidate added case for IMAGE. returning src string when title is null, blank or starting with http Co-authored-by:
mihai-adrian <mihai.carare.dev@gmail.com> Co-authored-by:
Mihai Adrian <48995920+mcarare@users.noreply.github.com>
-
Mihai Adrian authored
-
MozLando authored
4321: Public Suffix List update (20190905-141413) r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MozLando authored
4322: GeckoView update (beta) (20190905-141154) r=pocmo a=MickeyMoz 4323: GeckoView update (nightly) (20190905-141410) r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MickeyMoz authored
-
Sebastian Kaspari authored
-
MickeyMoz authored
-
MozLando authored
4319: Split changelog. r=jonalmeida a=pocmo
🤷 ♂ Co-authored-by:Sebastian Kaspari <s.kaspari@gmail.com>
-
Sebastian Kaspari authored
-
Sebastian Kaspari authored
-
MozLando authored
4318: Docs update (20190905-121255) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MozLando authored
4315: For #4284, 4285: HitResult and Download consumables for browser-state r=pocmo a=csadilek @pocmo As discussed, there are 3 parts/commits here: - Support for adding listeners to Consumables - Add HitResult to browser-state (and sync from browser-session) - Sync downloads between browser-session and browser-state Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
Christian Sadilek authored
Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com>
-
- 04 Sep, 2019 6 commits
-
-
MozLando authored
4314: Bug 1578859 - Update lib-crash README.md [ci skip] r=jonalmeida a=travis79 Removing a note from the README.md. With the addition of better pre-init handling, this no longer requires Glean to be initialized first. Co-authored-by:
Travis Long <tlong@mozilla.com>
-
Jonathan Almeida authored
-
Christian Sadilek authored
-
travis79 authored
Removing a note from the README.md since the addition of better pre-init handling, this no longer requires Glean to be initialized first.
-
Christian Sadilek authored
-
MozLando authored
4232: Initialize sentry client lazily #3445 r=rocketsroger a=KKS161994 Co-authored-by:
Kartikey Srivastava <kartikeysrivastava@kartikeys-macbook-pro.local>
-