1. 10 Sep, 2019 4 commits
  2. 09 Sep, 2019 12 commits
  3. 08 Sep, 2019 2 commits
  4. 06 Sep, 2019 13 commits
    • MozLando's avatar
      Merge #4339 · f5158da6
      MozLando authored
      4339: For #4302 - Adds the ability to override the basic shortcut name r=csadilek a=boek
      
      
      ### Pull Request checklist
      <!-- Before submitting the PR, please address each item -->
      - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
      - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
      - [x] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one
      - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features
      
      ### After merge
      - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development.
      - [ ] **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser
      
      ) to address the breaking issues.
      
      
      Co-authored-by: default avatarJeff Boek <jeff@jeffboek.com>
      f5158da6
    • Jeff Boek's avatar
    • MozLando's avatar
      Merge #4330 · 11769d53
      MozLando authored
      
      
      4330: Closes #3558: browser-state: Add engine session state and sync w/ browser-session r=pocmo a=csadilek
      
      Interestingly, we could live without an action for unlinking, as that only happens when the session is removed and since our new session state is immutable there's nothing to update, but for consistency/readability I've introduced it, plus there may be more use cases later.
      
      There's some special handling here for `restore`, as we first have to dispatch the restore action (which happens in the outer manager) before dispatching the link action (otherwise we won't find the session). Otherwise, all as discussed. I've named the object passed down to the legacy session manager "EngineSessionLinker", but better name suggestions welcome :)
      
      Co-authored-by: default avatarChristian Sadilek <christian.sadilek@gmail.com>
      11769d53
    • Christian Sadilek's avatar
    • MozLando's avatar
      Merge #4337 · dd85b2be
      MozLando authored
      
      
      4337: Update GV to 71.0.20190906094324 r=pocmo a=Dexterp37
      
      This deals with the breaking change of the GV telemetry API.
      
      
      
      
      Co-authored-by: default avatarAlessio Placitelli <alessio.placitelli@gmail.com>
      dd85b2be
    • MozLando's avatar
      Merge #4338 · 606dd32c
      MozLando authored
      
      
      4338: Switch to regular set for Consumable listeners r=pocmo a=csadilek
      
      This was meant to prevent a footgun / accident leaks of session and context via the listeners, but of course, now that nothing else holds on to the listeners they could disappear (get gc'ed) and not be notified. 
      
      Co-authored-by: default avatarChristian Sadilek <christian.sadilek@gmail.com>
      606dd32c
    • Christian Sadilek's avatar
      Switch to regular set for Consumable listeners · 155d7904
      Christian Sadilek authored
      - This was meant to prevent a footgun / accident leaks
      of session and context via the listeners, but of course,
      now that nothing else holds on to the listeners they could
      disappear (get gc'ed) and not be notified.
      155d7904
    • Alessio Placitelli's avatar
      Update GV to 71.0.20190906094324 · 8b7c948b
      Alessio Placitelli authored
      This deals with the breaking change of the
      GV telemetry API.
      8b7c948b
    • MozLando's avatar
      Merge #4334 · 65df8e8a
      MozLando authored
      
      
      4334:  Docs update (20190906-121412) [ci skip] r=pocmo a=MickeyMoz
      
      
      
      Co-authored-by: default avatarMickeyMoz <sebastian@mozilla.com>
      65df8e8a
    • MickeyMoz's avatar
      Update docs (20190906-121412) · 52d59224
      MickeyMoz authored
      52d59224
    • MozLando's avatar
      Merge #4327 · b2f19348
      MozLando authored
      
      
      4327: Flow.ifChanged(): Added variant that takes a mapping function. r=csadilek a=pocmo
      
      This pattern emerged while migrating components. Often I want listen to value changes, but if the value changes then I need more than only the changed value.
      
      One example is the downloads feature. I want to listen to download changes. But if that changes then I need the whole `SessionState` object.
      
      Previously:
      
      ```kotlin
      scope = store.flowScoped { flow ->
          flow.mapNotNull { state -> state.findCustomTabOrSelectedTab(customTabId) }
                 .map { it.content.download }
                 .ifChanged()
                .collect { download ->
                    // Okay, the DownloadState object now. But I also want the enclosing SessionState.
                }
      }
      ```
      
      Now:
      
      ```kotlin
      scope = store.flowScoped { flow ->
          flow.mapNotNull { state -> state.findCustomTabOrSelectedTab(customTabId) }
              .ifChanged { it.content.download }
              .collect { state ->
                  // Yay, I have the whole session state and can get
                  // to the download by using state.content.download
              }
      }
      ```
      
      
      
      Co-authored-by: default avatarSebastian Kaspari <s.kaspari@gmail.com>
      b2f19348
    • Sebastian Kaspari's avatar
    • MozLando's avatar
      Merge #4331 · a49e4410
      MozLando authored
      
      
      4331: Make BrowserAction names consistent r=pocmo a=csadilek
      
      Very minor refactoring, but since I just noticed. We could also decide to remove `Action` from all names, as they are usually prefixed with their type e.g. `TabListAction.AddTab`. Either way, I think we should keep them consistent.
      
      Co-authored-by: default avatarChristian Sadilek <christian.sadilek@gmail.com>
      a49e4410
  5. 05 Sep, 2019 9 commits