- 07 Oct, 2019 3 commits
-
-
MickeyMoz authored
-
MozLando authored
4660: Fix double-focus in browser menu r=pocmo a=NotWoods Co-authored-by:
Tiger Oakes <toakes@mozilla.com>
-
MozLando authored
4663: Docs update (20191006-121219) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
- 06 Oct, 2019 1 commit
-
-
MickeyMoz authored
-
- 05 Oct, 2019 1 commit
-
-
Tiger Oakes authored
-
- 04 Oct, 2019 12 commits
-
-
MozLando authored
4647: 1585953: Update bug numbers to URLs in Glean metadata r=mdboom a=mdboom Co-authored-by:
Michael Droettboom <mdboom@gmail.com>
-
MozLando authored
4644: GeckoView update (nightly) (20191004-141935) r=jonalmeida a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MozLando authored
4642: Docs update (20191004-121135) [ci skip] r=Amejia481 a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
Roger Yang authored
Closes #2203, closes #3511: Inline Socorro upload functionality and add support for "uncaught exception" crash reports
-
Michael Droettboom authored
-
Christian Sadilek authored
- We first need to configure a publish task that supports publishing .jar files. We only publish .aar right now.
-
Johan Lorenzo authored
-
Johan Lorenzo authored
-
MickeyMoz authored
-
MozLando authored
4643: Import strings from android-l10n r=Amejia481 a=Pike State: mozilla-l10n/android-l10n@31e0afdeb4df4eb1812d09705334cae40d18e065 Co-authored-by:
Axel Hecht <axel@pike.org>
-
Axel Hecht authored
State: mozilla-l10n/android-l10n@31e0afdeb4df4eb1812d09705334cae40d18e065
-
MickeyMoz authored
-
- 03 Oct, 2019 13 commits
-
-
MozLando authored
4631: Closes #4630: Clear out SyncEnginesStorage during logout r=Amejia481 a=grigoryk Co-authored-by:
Grisha Kruglov <gkruglov@mozilla.com>
-
Grisha Kruglov authored
-
MozLando authored
3918: Closes #3791 - Derive app icon for likely app-link app r=jonalmeida a=jhugman This PR exposes the icon and name of the app used to open a given link. This is to allow Fenix to display the app icon in the Quick Action Bar `Open in App` action. ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [X] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [X] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one - ~[ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~ ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones ) of the version currently in development. Co-authored-by:
James Hugman <james@hugman.tv> Co-authored-by:
Jonathan Almeida <jalmeida@mozilla.com>
-
MozLando authored
4617: Fix Glean SDK specific metrics API to be callable from Java r=Dexterp37 a=Dexterp37 This adds `@JvmOverloads` to the specific metrics API and the testing API. 4621: Docs update (20191003-121147) [ci skip] r=jonalmeida a=MickeyMoz 4622: GeckoView update (beta) (20191003-141540) r=jonalmeida a=MickeyMoz Co-authored-by:
Alessio Placitelli <alessio.placitelli@gmail.com> Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MozLando authored
4619: Closes #4618. Publish `tooling-detekt` package into maven repository. r=jonalmeida a=dector 4623: GeckoView update (nightly) (20191003-141631) r=Amejia481 a=MickeyMoz Co-authored-by:
Denys M <dector9@gmail.com> Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MickeyMoz authored
-
Denys M authored
-
MickeyMoz authored
-
Alessio Placitelli authored
This adds `@JvmOverloads` to the specific metrics API and the testing API.
-
MozLando authored
4604: Bug 1583870 - Migrate build tasks for PRs and pushes r=JohanLorenzo a=JohanLorenzo Co-authored-by:
Johan Lorenzo <jlorenzo@mozilla.com>
-
Johan Lorenzo authored
-
MozLando authored
4608: Bug 1583870 - Remove snapshot tasks which should not have been there r=JohanLorenzo a=JohanLorenzo Co-authored-by:
Johan Lorenzo <jlorenzo@mozilla.com>
-
- 02 Oct, 2019 10 commits
-
-
MozLando authored
4609: Fix find in page not working with fresh install r=csadilek a=VMadalin ### Description Fixed issue: https://github.com/mozilla-mobile/reference-browser/issues/915 The `engineSession` is null on `FindInPageInteractor` because the `bind()` method set it as null via `session.engineState.engineSession`. <img width="752" alt="Screenshot 2019-10-02 at 08 25 39" src="https://user-images.githubusercontent.com/18151158/66025739-799e8e00-e4f7-11e9-944d-73ab86d45485.png"> Finally and after deep research I discover the problem is related with the tabs, when `EngineStateReducer.reduce()` is called for the first time no one has add the new tab created and without it it's imposible to propagate the `GeckoEngineSession` to the `BrowserState` ``` 2019-10-02 17:50:58.885 8585-9964/org.mozilla.samples.browser: UnlinkEngineSessionAction 2019-10-02 17:50:58.891 8585-9964/org.mozilla.samples.browser: LinkEngineSessionAction 2019-10-02 17:50:58.919 8585-9964/org.mozilla.samples.browser: AddTabAction // after link ``` ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development. - [ ] **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser ) to address the breaking issues. Co-authored-by:
Madalin Valceleanu <devmobile@vmadalin.com>
-
Madalin Valceleanu authored
-
Jonathan Almeida authored
-
James Hugman authored
-
MozLando authored
4555: Closes #4535: Integrate setEnhancedTrackingProtectionLevel geckoView api. r=csadilek a=Amejia481 Co-authored-by:
Arturo Mejia <arturomejiamarmol@gmail.com>
-
MozLando authored
4600: Closes #4289: Migrate feature-prompts to use browser-state r=pocmo a=csadilek This migrates our feature-prompts module to browser-state. @pocmo I ended up introducing `Flow.ifAnyChanged` here because returning a `Pair` or other data class instance from `ifChanged` wouldn't have worked. We're comparing for reference equality in `ifChanged` so returning a new `Pair` would always indicate change and forward the value. The `ifChanged` block would have to get quite complicated. We'd have to return a different instance only if changed but then we're doing all the work in the feature module and the API doesn't help us. With `ifAnyChanged` this looks quite nice and we can refine the API more later. Most other changes are in the unit tests. I also did a round of manual testing, thanks to @Amejia481 for sending me lots of links to test :). I'll put up PRs for R-B and Fenix, once this one is approved. Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
Christian Sadilek authored
-
Christian Sadilek authored
-
Christian Sadilek authored
-
MozLando authored
4579: mozilla-mobile/fenix#5592 - enable private browsing for custom tabs r=NotWoods a=mohamediburan This PR enables private mode for custom tabs (see issue mozilla-mobile/fenix#5592) where it will not track history. This PR already passed all the tests and I checked tabIntentProcessor.kt file for sample tests. So, I can update test for this. but, I didn't find any tests for verifying whether it a private or normal tab. If I need to write test cases for this, please let me know. 4594: Prevent multiple browser menus r=pocmo a=Mugurell 4607: GeckoView update (nightly) (20191002-150346) r=pocmo a=MickeyMoz Co-authored-by:
Mohamed Iburan <mdiburan@gmail.com> Co-authored-by:
Petru Lingurar <petru.lingurar@softvision.ro> Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-