- 24 Sep, 2019 4 commits
-
-
MickeyMoz authored
-
Sebastian Kaspari authored
-
MozLando authored
4508: For #4460. Fix detekt warning about license in project files. r=pocmo a=dector Co-authored-by:
Denys M <dector9@gmail.com>
-
Sebastian Kaspari authored
-
- 23 Sep, 2019 20 commits
-
-
MozLando authored
4501: Closes #4406: Add TrackingProtectionUseCases r=rocketsroger a=Amejia481 Co-authored-by:
Arturo Mejia <arturomejiamarmol@gmail.com>
-
Arturo Mejia authored
-
Denys M authored
-
Denys M authored
-
MozLando authored
4477: 1581556: Enforce that Glean.initialize is only called on the MainThread r=mdboom a=mdboom Android `LifecycleObserver` s must be registered on the main thread [otherwise there is a race condition that may cause them to not be registered and/or unregister other observers](https://issuetracker.google.com/issues/138953075#comment2). Also see [the implementation](https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/LifecycleRegistry.java#187) that has a non-atomic push/operate/pop sequence of events. This bug is the source of all of the significant Fenix Sentry issues involving Glean: - https://sentry.prod.mozaws.net/operations/fenix/issues/5856320/?query=is:unresolved%20glean - https://sentry.prod.mozaws.net/operations/fenix/issues/5863576/?query=is:unresolved%20glean - https://sentry.prod.mozaws.net/operations/fenix/issues/5837548/?query=is:unresolved%20glean - https://sentry.prod.mozaws.net/operations/fenix/issues/5831193/?query=is:unresolved%20glean Beyond theoretical, this is quite likely the source of [Fenix reporting 50% more clients on metrics ping than baseline ping](https://bugzilla.mozilla.org/show_bug.cgi?id=1581556 ). Glean has two lifecycle observers. Failing to register one of them would disable the baseline ping. Failing to register the other would send metrics pings more than once between runs of the application. The combination of these two is *probably* enough to explain the problem, though it's hard to compare the scale of Sentry events to the scale of the problems in the data. @pocmo: Can you please confirm this is the appropriate way to dispatch something **back** to the main thread from a coroutine thread? Also, there are other instances of `addObserver` that may also need this treatment, but that largely depends on how that code is being used from the application, I suppose. Co-authored-by:
Michael Droettboom <mdboom@gmail.com>
-
MozLando authored
4478: Closes #4490: Resized icons on the toolbar. r=rocketsroger a=Amejia481 Related https://github.com/mozilla-mobile/android-components/issues/1514 **Updated pics** **Now**  **Before**  **Now**  **Before**  Co-authored-by:
Arturo Mejia <arturomejiamarmol@gmail.com>
-
Arturo Mejia authored
-
MozLando authored
4482: Issue #4241: FennecSessionMigration: First iteration of code to import "open tabs" from Fennec into an AC-based app. r=csadilek a=pocmo Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com>
-
MozLando authored
4498: GeckoView update (beta) (20190923-142515) r=pocmo a=MickeyMoz 4499: GeckoView update (nightly) (20190923-142523) r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MickeyMoz authored
-
MozLando authored
4494: Closes #4396: feature-media: Emit facts. r=Amejia481 a=pocmo Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com>
-
Sebastian Kaspari authored
-
Michael Droettboom authored
-
Michael Droettboom authored
-
Michael Droettboom authored
-
Michael Droettboom authored
-
MozLando authored
4493: GeckoView update (nightly) (20190922-141048) r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MozLando authored
4492: Docs update (20190922-121213) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MozLando authored
4461: Closes #846. Add detekt rule to check license header in kotlin files. r=pocmo a=dector 4491: Docs update (20190921-121118) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
Denys M <dector9@gmail.com> Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
- 22 Sep, 2019 2 commits
- 21 Sep, 2019 2 commits
- 20 Sep, 2019 12 commits
-
-
MozLando authored
4489: Update changelog with kotlin and coroutine version bump [ci skip] r=Amejia481 a=jonalmeida We updated our dependencies, but our consumers weren't aware. Co-authored-by:
Jonathan Almeida <jalmeida@mozilla.com>
-
MozLando authored
4365: For #3715 Support adding icon to a BrowserMenuSwitch r=Amejia481 a=mcarare Added BrowserMenuImageSwitch, a BrowserMenuSwitch with added icon. No paddingEnd for switch cause it would leave to much empty space. Co-authored-by:
mihai-adrian <mihai.carare.dev@gmail.com> Co-authored-by:
Mihai Adrian <48995920+mcarare@users.noreply.github.com>
-
Jonathan Almeida authored
-
MozLando authored
4487: Closes #4486: startup crash after closing all tabs r=Amejia481 a=csadilek This was introduced with the recent refactoring. We don't need to check for a connected port or update reader mode if there's no selected session. Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
MozLando authored
4485: GeckoView update (nightly) (20190920-141109) r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
Christian Sadilek authored
-
MozLando authored
4484: Public Suffix List update (20190920-141032) r=Amejia481 a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MickeyMoz authored
-
Sebastian Kaspari authored
Issue #4241: FennecSessionMigration: First iteration of code to import "open tabs" from Fennec into an AC-based app.
-
MozLando authored
4481: Docs update (20190920-121129) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-