1. 19 Nov, 2019 16 commits
    • MozLando's avatar
      Merge #5092 · 7b3fad0c
      MozLando authored
      
      
      5092: Closes #5091: Fix clashing file providers in feature-prompts and feature-downloads. r=NotWoods,sblatz,csadilek a=Amejia481
      
      
      
      Co-authored-by: default avatarArturo Mejia <arturomejiamarmol@gmail.com>
      7b3fad0c
    • Arturo Mejia's avatar
      Closes #5091: Fix clashing file providers in feature-prompts and · e2669721
      Arturo Mejia authored
      feature-downloads.
      e2669721
    • Sebastian Kaspari's avatar
      Set version to 23.0.0. · f1717afd
      Sebastian Kaspari authored
      f1717afd
    • Sebastian Kaspari's avatar
      Update changelog for 22.0.0 release. · f7af4804
      Sebastian Kaspari authored
      f7af4804
    • MozLando's avatar
      Merge #5101 · 79c3426a
      MozLando authored
      
      
      5101: Make ShareData parcelable r=jonalmeida a=NotWoods
      
      Adding parcel support so that `ShareData` can be passed between fragments in bundles. This will let ShareData be used with Fenix's ShareFragment.
      
      
      
      Co-authored-by: default avatarTiger Oakes <toakes@mozilla.com>
      79c3426a
    • Tiger Oakes's avatar
      Make ShareData parcelable · 82929076
      Tiger Oakes authored
      82929076
    • MozLando's avatar
      Merge #5096 · cde8f5e6
      MozLando authored
      5096: Add JUnit coroutine test rule r=Amejia481 a=NotWoods
      
      Hopefully this makes it simpler to override Dispatchers.Main for testing. Based loosely on https://craigrussell.io/2019/11/unit-testing-coroutine-suspend-functions-using-testcoroutinedispatcher/
      
       and Android Dev Summit slides.
      
      
      
      Co-authored-by: default avatarTiger Oakes <toakes@mozilla.com>
      cde8f5e6
    • MozLando's avatar
      Merge #5098 · a0f8d4f1
      MozLando authored
      
      
      5098: Closes #5034: Add release 18.0.1 to changelog. r=Amejia481 a=pocmo
      
      Released last week. Just the changelog entry was missing.
      
      Co-authored-by: default avatarSebastian Kaspari <s.kaspari@gmail.com>
      a0f8d4f1
    • MozLando's avatar
      Merge #5100 · 51daa1dd
      MozLando authored
      
      
      5100:  Docs update (20191119-120718) [ci skip] r=Amejia481 a=MickeyMoz
      
      
      
      Co-authored-by: default avatarMickeyMoz <sebastian@mozilla.com>
      51daa1dd
    • MickeyMoz's avatar
      Update docs (20191119-120718) · 7c8b55a7
      MickeyMoz authored
      7c8b55a7
    • MozLando's avatar
      Merge #5099 · 63349b66
      MozLando authored
      
      
      5099: Import strings from android-l10n. r=pocmo a=mozilla-l10n-automation-bot
      
      n/t
      
      Co-authored-by: default avatarMozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
      63349b66
    • Mozilla L10n Automation Bot's avatar
      Import l10n. · 196a3ce2
      Mozilla L10n Automation Bot authored
      196a3ce2
    • Sebastian Kaspari's avatar
      e7041131
    • Tiger Oakes's avatar
      Add JUnit coroutine test rule · 9740f940
      Tiger Oakes authored
      9740f940
    • MozLando's avatar
      Merge #5053 · 4b4ade17
      MozLando authored
      
      
      5053: Closes #2229: Encrypted-at-rest FxA state storage support r=csadilek a=grigoryk
      
      This patch adds a version of `AccountStorage` which is backed by an encrypted-at-rest shared-prefs implementation,
      `SecureAbove22Preferences`. As the name suggests, encryption at rest is enabled only for Android API levels 23+.
      Otherwise, plaintext storage is used. `SecureAbove22Preferences` will handle API level upgrades behind the scenes,
      if necessary.
      
      In order to support rolling this out, `SecureAbove22AccountStorage` automatically migrates account state if it was
      present in `SharedPrefAccountStorage`. And vice-versa, `SharedPrefAccountStorage` will automatically migrate account
      state if it was present in `SecureAbove22AccountStorage`. This allows applications to easily switch between two
      implementations, without any ill-effects.
      
      In order to monitor storage implementations for abnormalities (such as disappearing encryption keys), an optional
      `CrashReporter` instance may be configured now via FxaAccountManager.
      
      `DeviceConfig` gained a `secureStateAtRest` flag, which allows applications to specify if they'd like to encrypt
      account state. This config object isn't a perfect fit for this flag, but it's close enough conceptually.
      
      
      
      
      Co-authored-by: default avatarGrisha Kruglov <gkruglov@mozilla.com>
      4b4ade17
    • Grisha Kruglov's avatar
      Closes #2229: Encrypted-at-rest FxA state storage support · 3061e01c
      Grisha Kruglov authored
      This patch adds a version of `AccountStorage` which is backed by an encrypted-at-rest shared-prefs implementation,
      `SecureAbove22Preferences`. As the name suggests, encryption at rest is enabled only for Android API levels 23+.
      Otherwise, plaintext storage is used. `SecureAbove22Preferences` will handle API level upgrades behind the scenes,
      if necessary.
      
      In order to support rolling this out, `SecureAbove22AccountStorage` automatically migrates account state if it was
      present in `SharedPrefAccountStorage`. And vice-versa, `SharedPrefAccountStorage` will automatically migrate account
      state if it was present in `SecureAbove22AccountStorage`. This allows applications to easily switch between two
      implementations, without any ill-effects.
      
      In order to monitor storage implementations for abnormalities (such as disappearing encryption keys), an optional
      `CrashReporter` instance may be configured now via FxaAccountManager.
      
      `DeviceConfig` gained a `secureStateAtRest` flag, which allows applications to specify if they'd like to encrypt
      account state. This config object isn't a perfect fit for this flag, but it's close enough conceptually.
      3061e01c
  2. 18 Nov, 2019 15 commits
    • MozLando's avatar
      Merge #5078 · 1dcfb602
      MozLando authored
      
      
      5078: FxA cleanup: remove authErrorRegistry, and other simplifications r=csadilek a=grigoryk
      
      (splitting this off from a larger clean-up branch)
      
      The sole reason for authErrorRegistry was to expose an instance of FxaAccountManager
      to internal components which don't have direct access to it. The registry acted
      an internal singleton, but with a bunch of overhead and conceptual complexity around it.
      
      This patch simplifies this: it adds an actual singleton instead of the registry, with a
      simple API for components to call into if they encounter authentication errors.
      
      Behaviour of `handleFxaExceptions` also changed slightly, to reduce cognitive overhead:
      - instead of calling into an Async function on the observer, and ignoring the result,
      this API is now simply `suspend`, which is a first step on the way to reasoning about error handling within the FxA state machine in terms of structured concurrency.
      
      Other cleanup involves marking an expensive OAuthAccount method as async, as well as some
      simplification of error handling in FirefoxAccount.
      
      
      
      
      Co-authored-by: default avatarGrisha Kruglov <gkruglov@mozilla.com>
      1dcfb602
    • Grisha Kruglov's avatar
      FxA cleanup: remove authErrorRegistry · f5a67f39
      Grisha Kruglov authored
      The sole reason for authErrorRegistry was to expose an instance of FxaAccountManager
      to internal components which don't have direct access to it. The registry acted
      an internal singleton, but with a bunch of overhead and conceptual complexity around it.
      
      This patch simplifies this: it adds an actual singleton instead of the registry, with a
      simple API for components to call into if they encounter authentication errors.
      
      Behaviour of `handleFxaExceptions` also changed slightly, to reduce cognitive overhead:
      - instead of calling into an Async function on the observer, and ignoring the result,
      this API is now simply `suspend`, which allows us to reason about error handling within
      the FxA state machine terms of structured concurrency.
      
      Other cleanup involves marking an expensive OAuthAccount method as async, as well as some
      simplification of error handling in FirefoxAccount.
      f5a67f39
    • MozLando's avatar
      Merge #5061 · 993d8c1d
      MozLando authored
      
      
      5061: Add shortcut category to window feature r=csadilek a=NotWoods
      
      Prevents "Open in private mode" option from appearing when opening a window.
      
      Changed the first parameter to be `Activity` since the app crashes when you try to pass in application context instead.
      
      
      
      Co-authored-by: default avatarTiger Oakes <toakes@mozilla.com>
      993d8c1d
    • Tiger Oakes's avatar
      Add shortcut category to window feature · 875fa4ac
      Tiger Oakes authored
      Prevents "Open in private mode" option from appearing when opening a
      window.
      875fa4ac
    • MozLando's avatar
      Merge #5082 · c2052f96
      MozLando authored
      
      
      5082: Closes #4993: Add tag to notifications for WebNotification r=rocketsroger a=rocketsroger
      
      
      
      Co-authored-by: default avatarRoger Yang <royang@mozilla.com>
      c2052f96
    • MozLando's avatar
      Merge #5052 · ca43e554
      MozLando authored
      
      
      5052: For 5051: Update PublicSuffixList kdocs r=pocmo a=Baron-Severin
      
      
      
      Co-authored-by: default avatarSeverin Rudie <srudie@mozilla.com>
      ca43e554
    • MozLando's avatar
      Merge #5062 · b3494352
      MozLando authored
      
      
      5062: Import strings from android-l10n. r=pocmo a=mozilla-l10n-automation-bot
      
      n/t
      
      Co-authored-by: default avatarMozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
      b3494352
    • Mozilla L10n Automation Bot's avatar
      Import l10n. · c9579e11
      Mozilla L10n Automation Bot authored
      c9579e11
    • MozLando's avatar
      Merge #5076 #5088 · 0068c0de
      MozLando authored
      
      
      5076: For #4999: Fixes verifyDownload for cancelling & completed r=csadilek a=sblatz
      
      
      
      5088:  GeckoView update (beta) (20191118-140410) r=pocmo a=MickeyMoz
      
      
      
      Co-authored-by: default avatarSawyer Blatz <sdblatz@gmail.com>
      Co-authored-by: default avatarMickeyMoz <sebastian@mozilla.com>
      0068c0de
    • MozLando's avatar
      Merge #5089 · f73721e9
      MozLando authored
      
      
      5089:  GeckoView update (nightly) (20191118-140600) r=pocmo a=MickeyMoz
      
      
      
      Co-authored-by: default avatarMickeyMoz <sebastian@mozilla.com>
      f73721e9
    • MickeyMoz's avatar
      Update GeckoView (nightly) (20191118-140600) · 24a63a8e
      MickeyMoz authored
      24a63a8e
    • MickeyMoz's avatar
      Update GeckoView (beta) (20191118-140410) · 180054f1
      MickeyMoz authored
      180054f1
    • MozLando's avatar
      Merge #5086 #5087 · 11a835e4
      MozLando authored
      
      
      5086:  GeckoView update (nightly) (20191117-140637) r=pocmo a=MickeyMoz
      
      
      
      5087:  Docs update (20191118-120838) [ci skip] r=pocmo a=MickeyMoz
      
      
      
      Co-authored-by: default avatarMickeyMoz <sebastian@mozilla.com>
      11a835e4
    • MozLando's avatar
      Merge #5085 · 1bb0f70a
      MozLando authored
      
      
      5085:  Public Suffix List update (20191117-140615) r=pocmo a=MickeyMoz
      
      
      
      Co-authored-by: default avatarMickeyMoz <sebastian@mozilla.com>
      1bb0f70a
    • MickeyMoz's avatar
      Update docs (20191118-120838) · 7d847334
      MickeyMoz authored
      7d847334
  3. 17 Nov, 2019 5 commits
  4. 15 Nov, 2019 4 commits