- 21 Feb, 2020 1 commit
-
-
Mozilla L10n Automation Bot authored
-
- 20 Feb, 2020 10 commits
-
-
MozLando authored
5998: Closes #5998: Emit Facts for WebExtension Telemetry r=gabrielluong a=gabrielluong Fixes #5998 Co-authored-by:
Gabriel Luong <gabriel.luong@gmail.com>
-
Gabriel Luong authored
-
MozLando authored
5864: Fixed `ContextMenuFeature` and `DownloadsFeature` not working for non-selected normal tab r=pocmo a=JasonHK - Added `BrowserState.findTabOrCustomTabOrSelectedTab` extension method. - Fixed `ContextMenuFeature` not working for non-selected normal tab. - Fixed `DownloadsFeature` not working for non-selected normal tab 5997: Closes #5792: Potential deadlock between unsubscribe and dispatch r=pocmo a=csadilek As with our previous deadlock fix, we do **not** want to change the lock on the `Subscription`, as it guarantees we never dispatch to paused or stopped observers. However, the inner lock on `subscriptions` is only there for visibility purposes. We can achieve the same, namely making sure retrievals reflect the results of the most recently completed update, by using a concurrent HashSet: A set projection of https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html This removes the potential of a deadlock and I don't see any change in semantics: The `removeSubscription` case is guarded by the `Subscription` lock and can't overlap with dispatching to the same subscription. The `addSubscription` case is guarded by the lock on the `Store` which is also required for `dipsatching`, so add and dispatch can't overlap either. @pocmo wdyt? 6008: Bug 1615248 - add missing nightly entry in .cron.yml r=pocmo a=MihaiTabara Follow-up from https://github.com/mozilla-mobile/android-components/pull/5967 , I forgot to add its `cron.yml` corresponding entry for nightly releases. Co-authored-by:
Jason Kwok <JasonHK@users.noreply.github.com> Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com> Co-authored-by:
Mihai Tabara <mtabara@mozilla.com>
-
MozLando authored
4946: For #4907 - RTL url no margin set r=pocmo a=BranescuMihai This change takes into account all four possible scenarios: Legend: X button = X ActionContainer = A UrlView = U 1. (X GONE) (A GONE) <- 8dp -> (U) 2. (X GONE) (A) (U) 3. (X) (A) (U) 4. (X) (A GONE) (U) So basically, this adds 8dp only when both views in its anchoring chain are GONE. Co-authored-by:
Mihai Branescu <branescu.mihai2@gmail.com>
-
MozLando authored
6007: Closes #6004: Show web ext badge in browser menu item r=Amejia481 a=psymoon Co-authored-by:
Simon Chae <chaesmn@gmail.com>
-
Mihai Tabara authored
-
Simon Chae authored
-
MozLando authored
5591: Closes #5884 - Let PWA site controls be customized r=pocmo a=NotWoods Customize the notification that shows up when a PWA is open with any options. Co-authored-by:
Tiger Oakes <toakes@mozilla.com>
-
MozLando authored
6002: GeckoView update (nightly) (20200220-140714) r=Amejia481 a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
- 19 Feb, 2020 23 commits
-
-
Christian Sadilek authored
-
MozLando authored
5951: Closes #5900: IntentReceiverActivity is reused when opening intent from other apps. r=pocmo a=rocketsroger Co-authored-by:
Roger Yang <royang@mozilla.com>
-
MozLando authored
5987: Closes #5911: Update test coverage for feature-addons/ui r=csadilek,Amejia481 a=psymoon Add more coverage for: - `AddonsManagerAdapterDelegate` - `CustomViewHolder` - `Extensions` I don't think we need test coverage for `AddonPermissionsAdapter` since it's mostly android `RecyclerView` logic. Co-authored-by:
Simon Chae <chaesmn@gmail.com>
-
Simon Chae authored
Add more coverage for: - AddonsManagerAdapterDelegate - CustomViewHolder - Extensions
-
Roger Yang authored
-
MozLando authored
5994: GeckoView update (beta) (20200219-140730) r=pocmo a=MickeyMoz 5995: GeckoView update (nightly) (20200219-140737) r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MozLando authored
5993: Public Suffix List update (20200219-140729) r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MickeyMoz authored
-
MozLando authored
5967: Add nightly releases to compete snapshots - part 1 (building) bors r=JohanLorenzo,pocmo r=JohanLorenzo,pocmo a=MihaiTabara Motivation for this is https://github.com/mozilla-mobile/android-components/issues/5023 WIP - ~just a stub for now~ I still need to address a bunch of things like ~artifacts exposure~, beetmover and signing jobs, etc. But the main blocker is the fact that we need to create a new subdomain within maven.mozilla.org, something like https://nightly.maven.mozilla.org/ . Later edit: this seems to be working locally just fine. Adds the `nightly-release` graph succesfully and the version to be used is e.g. `public/build/browser-awesomebar-32.0.20200212190116-sources.jar` placed within ``` "payload": { "artifacts": { "public/build/browser-awesomebar-32.0.20200212190116-sources.jar": { "expires": { "relative-datestamp": "1 year" }, "path": "/builds/worker/checkouts/src/components/browser/awesomebar/build/maven/org/mozilla/components/browser-awesomebar/32.0.20200212190116/browser-awesomebar-32.0.20200212190116-sources.jar", "type": "file" }, ``` Co-authored-by:
Mihai Tabara <mtabara@mozilla.com>
-
MickeyMoz authored
-
MozLando authored
5992: Docs update (20200219-120809) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
Mihai Tabara authored
-
MickeyMoz authored
-
Mihai Tabara authored
-
Mihai Branescu authored
This change takes into account all four possible scenarios: Legend: X button = X ActionContainer = A UrlView = U 1. (X GONE) (A GONE) <- 8dp -> (U) 2. (X GONE) (A) (U) 3. (X) (A) (U) 4. (X) (A GONE) (U) So basically, this adds 8dp only when both views in it's anchoring chain are GONE
-
MozLando authored
5986: Update auto-generated metrics.md files r=pocmo a=grigoryk Seems like glean doc generation formatting changed, locally these files got re-generated for me. Co-authored-by:
Grisha Kruglov <gkruglov@mozilla.com>
-
MozLando authored
5971: Closes #5966: Migrate browser-icons to use browser-state. r=csadilek a=pocmo 5982: Add dummy assembleRelease task r=pocmo a=mdboom As reported by @pocmo on Slack: > Hm, the fix landed but it seems like our release process is broken > We are getting: `[task 2020-02-18T18:43:51.330Z] Task 'assembleRelease' not found in project ':tooling-glean-gradle'`. > To unblock our release I am going to disable that project in .buildconfig.yml in our release branch only. Adding a dummy task seems to get around this. I think [looked here](https://github.com/mozilla-mobile/android-components/blob/master/taskcluster/ci/build/kind.yml#L41 ) to see all of the tasks that are run on a release, and added all that were missing to make them all work. Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com> Co-authored-by:
Michael Droettboom <mdboom@gmail.com>
-
Sebastian Kaspari authored
-
Sebastian Kaspari authored
-
Sebastian Kaspari authored
-
MozLando authored
5979: Fixes #5978: Ensures captureThumbnail always executes callback r=pocmo a=sblatz Co-authored-by:
Sawyer Blatz <sdblatz@gmail.com>
-
Sawyer Blatz authored
-
- 18 Feb, 2020 6 commits
-
-
MozLando authored
5981: Closes 5861: A few messages reference "computer" r=Amejia481 a=st3fan Co-authored-by:
Stefan Arentz <stefan@arentz.ca>
-
MozLando authored
5976: Improve add-ons update flow. r=csadilek,psymoon a=Amejia481 Both the simple flow (with NO new permissions) and the complex update flow with new permissions work as expected, I did some minor changes as I noticed that we didn't remove from a previously allowed add-on from the status store after It was processed, also Geckoview requires us to process the updates in the main dispatcher. 5985: Closes #5983: QR scanner slow and fails to scan on some devices r=Amejia481 a=csadilek We're making the scan area a square which we found to work much better on various devices (esp. one plus 6T) when testing. Also limiting the maximum resolution to get faster scan results. Co-authored-by:
Arturo Mejia <arturomejiamarmol@gmail.com> Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
Grisha Kruglov authored
Seems like glean doc generation formatting changed, locally these files got re-generated for me.
-
Arturo Mejia authored
-
Christian Sadilek authored
-
Stefan Arentz authored
-