1. 31 Oct, 2019 1 commit
  2. 30 Oct, 2019 5 commits
  3. 29 Oct, 2019 3 commits
  4. 28 Oct, 2019 1 commit
  5. 25 Oct, 2019 3 commits
  6. 24 Oct, 2019 5 commits
  7. 23 Oct, 2019 3 commits
  8. 22 Oct, 2019 3 commits
  9. 21 Oct, 2019 1 commit
  10. 20 Oct, 2019 1 commit
  11. 18 Oct, 2019 1 commit
  12. 17 Oct, 2019 1 commit
  13. 16 Oct, 2019 2 commits
  14. 15 Oct, 2019 2 commits
  15. 13 Oct, 2019 1 commit
  16. 12 Oct, 2019 1 commit
    • Lina Cambridge's avatar
      Pass redirect source and target flags to history tracking delegates. · 15b873fe
      Lina Cambridge authored
      There's some confusion in `GeckoEngineSession` about redirect flags.
      The `VISIT_REDIRECT_SOURCE` and `VISIT_REDIRECT_SOURCE_PERMANENT` flags
      that we get from GeckoView's history delegate are for the redirect
      _source_, not the visit type. They indicate if the URL passed to
      `onVisited` is redirecting _to_ another URL, most likely because the
      server returned an HTTP 3xy status code with a `Location` header.
      Rust Places decides whether to mark the URL as hidden based on
      these flags.
      
      `VISIT_REDIRECT_{PERMANENT, TEMPORARY}`, however, indicate if the
      URL passed to `onVisited` is the _target_ of a redirect (in other
      words, the page that's _in_ the `Location` header). These get
      translated into `VisitType` flags, which Rust Places stores as the
      visit transition type. These two flags don't affect whether a URL
      is hidden.
      
      Note that, in a redirect chain, the middle links are both sources and
      targets. For example, in "mozilla.org" -> "www.mozilla.org" ->
      "www.mozilla.org/en-US", "www.mozilla.org" is both a redirect target
      (since "mozilla.org" redirected to it), and a source (it redirected
      to "www.mozilla.org/en-US").
      
      See mozilla-mobile/fenix#3526.
      15b873fe
  17. 11 Oct, 2019 2 commits
  18. 10 Oct, 2019 1 commit
  19. 09 Oct, 2019 3 commits