1. 21 Nov, 2019 1 commit
  2. 20 Nov, 2019 16 commits
  3. 19 Nov, 2019 19 commits
  4. 18 Nov, 2019 4 commits
    • MozLando's avatar
      Merge #5078 · 1dcfb602
      MozLando authored
      
      
      5078: FxA cleanup: remove authErrorRegistry, and other simplifications r=csadilek a=grigoryk
      
      (splitting this off from a larger clean-up branch)
      
      The sole reason for authErrorRegistry was to expose an instance of FxaAccountManager
      to internal components which don't have direct access to it. The registry acted
      an internal singleton, but with a bunch of overhead and conceptual complexity around it.
      
      This patch simplifies this: it adds an actual singleton instead of the registry, with a
      simple API for components to call into if they encounter authentication errors.
      
      Behaviour of `handleFxaExceptions` also changed slightly, to reduce cognitive overhead:
      - instead of calling into an Async function on the observer, and ignoring the result,
      this API is now simply `suspend`, which is a first step on the way to reasoning about error handling within the FxA state machine in terms of structured concurrency.
      
      Other cleanup involves marking an expensive OAuthAccount method as async, as well as some
      simplification of error handling in FirefoxAccount.
      
      
      
      
      Co-authored-by: default avatarGrisha Kruglov <gkruglov@mozilla.com>
      1dcfb602
    • Grisha Kruglov's avatar
      FxA cleanup: remove authErrorRegistry · f5a67f39
      Grisha Kruglov authored
      The sole reason for authErrorRegistry was to expose an instance of FxaAccountManager
      to internal components which don't have direct access to it. The registry acted
      an internal singleton, but with a bunch of overhead and conceptual complexity around it.
      
      This patch simplifies this: it adds an actual singleton instead of the registry, with a
      simple API for components to call into if they encounter authentication errors.
      
      Behaviour of `handleFxaExceptions` also changed slightly, to reduce cognitive overhead:
      - instead of calling into an Async function on the observer, and ignoring the result,
      this API is now simply `suspend`, which allows us to reason about error handling within
      the FxA state machine terms of structured concurrency.
      
      Other cleanup involves marking an expensive OAuthAccount method as async, as well as some
      simplification of error handling in FirefoxAccount.
      f5a67f39
    • MozLando's avatar
      Merge #5061 · 993d8c1d
      MozLando authored
      
      
      5061: Add shortcut category to window feature r=csadilek a=NotWoods
      
      Prevents "Open in private mode" option from appearing when opening a window.
      
      Changed the first parameter to be `Activity` since the app crashes when you try to pass in application context instead.
      
      
      
      Co-authored-by: default avatarTiger Oakes <toakes@mozilla.com>
      993d8c1d
    • Tiger Oakes's avatar
      Add shortcut category to window feature · 875fa4ac
      Tiger Oakes authored
      Prevents "Open in private mode" option from appearing when opening a
      window.
      875fa4ac