- 12 Feb, 2020 10 commits
-
-
Jonathan Almeida authored
-
Jonathan Almeida authored
-
Jonathan Almeida authored
-
MozLando authored
5897: Closes #5892: Whitelisted scheme should always open in third party apps r=Amejia481 a=rocketsroger Co-authored-by:
Roger Yang <royang@mozilla.com>
-
MozLando authored
5835: Closes #4779 - Fix `ExperimentsDebugActivity` command to change server r=travis79 a=travis79 This fixes the issue of not being able to change the Kinto endpoint using the `adb` command. The issue was due to the fact that the source was being updated, but then subsequently not being used for the update because the `ExperimentUpdater` was building a new `ExperimentSource` using the old config rather than using the updated one. Co-authored-by:
Travis Long <tlong@mozilla.com>
-
MozLando authored
5901: Issue #5143: Bring in GV API for addon updates r=Amejia481 a=csadilek Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
MozLando authored
5903: Docs update (20200212-121021) [ci skip] r=psymoon a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MozLando authored
5895: Update Glean to v24.2.0 r=Dexterp37 a=mdboom Co-authored-by:
Michael Droettboom <mdboom@gmail.com>
-
Christian Sadilek authored
-
- 11 Feb, 2020 16 commits
-
-
MozLando authored
5893: Move add-ons translations on the right path r=csadilek a=Amejia481 Related issue: https://github.com/mozilla-mobile/fenix/issues/8188 5896: Closes #5894: AddonManager API to suspend until all actions are processed r=psymoon,Amejia481 a=csadilek Co-authored-by:
Arturo Mejia <arturomejiamarmol@gmail.com> Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
MozLando authored
5898: For Fenix #8307 - Cancel validation await onTextChanged correctly r=Baron-Severin a=ekager Co-authored-by:
Emily Kager <ekager@mozilla.com>
-
Emily Kager authored
-
Christian Sadilek authored
-
MozLando authored
5888: Closes #5815: Update unsupported addons adapter when uninstall occurs r=Amejia481 a=psymoon One concern I have with this approach is if adapter can ever be null (i.e. garbage collected) at the wrong time (when `onUninstallSuccess` is invoked but activity/fragment is being destroyed). I tried testing uninstalling and pressing back quickly a few times and I haven't seen any crashes (perhaps the nullable adapter check is sufficient) Co-authored-by:
Simon Chae <chaesmn@gmail.com>
-
Roger Yang authored
-
Michael Droettboom authored
-
Simon Chae authored
-
Arturo Mejia authored
-
Michael Droettboom authored
-
MozLando authored
5877: Closes #5875: onTitleChange blocking on history storage write r=grigoryk,pocmo a=csadilek Looking through other call-sites, this seems save to move to an IO thread esp., as it writes to storage. We also already have a custom scope in the engine session which I am using here. Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
MozLando authored
5887: Docs update (20200211-120856) [ci skip] r=psymoon a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MozLando authored
5870: Closes #5868: Correctly handle null title when migrating open tabs. r=Amejia481 a=pocmo Closes #5868. 5881: Add Enabled and Disabled strings for add-ons settings r=pocmo a=gabrielluong In the new mockup for the add-on settings, it uses the strings "Enabled" and "Disabled" instead of "On" and "Off". Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com> Co-authored-by:
Gabriel Luong <gabriel.luong@gmail.com>
-
MozLando authored
5492: Closes #5174: Add telemetry crash service in lib-crash. r=pocmo a=rocketsroger Co-authored-by:
Roger Yang <royang@mozilla.com>
-
MozLando authored
5840: Closes #5832: Polish addons unsupported item to have bigger font size and a start margin r=Amejia481 a=gabrielluong Co-authored-by:
Gabriel Luong <gabriel.luong@gmail.com>
-
- 10 Feb, 2020 14 commits
-
-
Gabriel Luong authored
-
MozLando authored
5850: Closes #5692: NotImplementedError: Octet length not supported r=grigoryk a=st3fan This patch for #5692 fixes a integer sign issue when pulling bytes with the high bit set out of a `ByteArray`. I also fixed a bug where 3-byte lengths were not correctly decoded. (Unclear how likely it is that we encounter a login item that is larger than 2^16 though.) I was not sure how to write a test for the embedded `ByteArray.getEncodingLength` so I actually pulled that extension method out of the `FennecLoginsMigration` class. Let me know if there is an elegant solution for that. Draft because I'll add a few more test cases with funny numbers. Co-authored-by:
Stefan Arentz <stefan@arentz.ca>
-
Gabriel Luong authored
-
Christian Sadilek authored
-
Roger Yang authored
-
MozLando authored
5738: Refactor to decouple WebExtensions from the engine architecture r=csadilek a=keianhzo Closes #5735 Closes #5736 Closes #5737 The purpose of this task is to expose the `WebExtensions` features in a a more `concept-engine` architecture agnostic way. The Web Extensions implementation is coupled to the concept-engine/browser-session architecture. Some projects would prefer to have their own engine/session implementation but still be able to use modules from AC like the Web Extensions features. This is the case for Firefox Reality where we need a very specific engine/session implementation. WebExtensions shouldn't require much from Engine/Session as at the moment. They just use the runtime and the session from the inner engine implementations and in some cases might require session life cycle related callbacks to register handlers. We sould be able to refactor all the WebExtension realated code out of `Engine` and `EngineSession` and ideally also remove from the WebExtensions any dependency from session life cycle related classes like `SelectionAwareSessionObserver` or `LifecycleAwareFeature`. I've made a basic refactor proposal based on the reported issues. You can take look at it in this PR. - Added a new `WebExtensionEngine` interface that provides all the WebExtensions required functionality: `installWebExtension`, `updateWebExtension`, etc. to limit the required code to add support for AC Web Extensions. - Add a new `WebExtensionEngineSession` interface that provides access to the inner browser session as that's the one thing that Web Extensions require at the moment. - Make `Engine` and `EngineSession` implement `WebExtensionEngine` and `WebExtensionEngineSession`. - Updated `FxaWebChannelFeature` so `SessionManager` is an optional parameter and decouple it's implementation from it so they life cycle callbacks can be handled independently. - Updating the AC codebase to follow the new pattern. Things not yet covered by this proposal: - [ ] Completely decouple the extensions from `SessionManager` and `SelectionAwareSessionObserver`. - [ ] Follow the same pattern for other Web Extension features like `ReaderViewFeature`. - [ ] Update tests and fix CI issues - [ ] Refactor all the WebExtensions related code from `concept-engine` into support-webextensions? - [ ] Probably a bunch of things that I've missed If this look like a good initial step, I can keep on working on it. Otherwise you can close it and and we can discuss the opened issues to see what would be the right way to go to make AC Web Extensions to work for any GV based project. <!-- Text above this line will be added to the commit once "bors" merges this PR --> ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [x] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development. - [ ] **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser ) to address the breaking issues. Co-authored-by:
Manuel Martin <manmartin@mozilla.com>
-
MozLando authored
5872: Annotate breaking API on Awesomebar changes [ci skip] r=pocmo a=jonalmeida Co-authored-by:
Jonathan Almeida <jalmeida@mozilla.com>
-
MozLando authored
5774: Fix for #5605 - Set content intent for the migration notifications r=pocmo a=vmbaicu When the user taps on the migration notifications they do nothing because they do not have any content intent set. Co-authored-by:
Andrei Lazar <alazar@mozilla.com>
-
MozLando authored
5824: Navigate to home screen after PWA is installed r=pocmo a=NotWoods Pulled this logic [from Fennec](https://searchfox.org/mozilla-esr68/source/mobile/android/base/java/org/mozilla/gecko/util/ShortcutUtils.java#79 ). 5871: GeckoView update (nightly) (20200210-140525) r=psymoon a=MickeyMoz Co-authored-by:
Tiger Oakes <toakes@mozilla.com> Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
Andrei Lazar authored
Currently a notification is being shown for migration progress status, but no notification is being displayed to the user for when the migration is complete. In order to properly handle this notification's remove or click action, a broadcast receiver is required that listens for this specific actions so it can remove the notification's channel.
-
Jonathan Almeida authored
-
Stefan Arentz authored
-
MickeyMoz authored
-
MozLando authored
5826: Update androidx.core to 1.2 r=pocmo a=NotWoods Switched over to the new blend mode compat system and added some annotations 5847: No issue: land context menu search strings r=pocmo a=ekager Co-authored-by:
Tiger Oakes <toakes@mozilla.com> Co-authored-by:
Emily Kager <ekager@mozilla.com>
-