Unverified Commit 1f9c2d5d authored by Krist Baliev's avatar Krist Baliev Committed by GitHub
Browse files

remove deprecated logins checkpoint api (#7349)

parent 242220ac

CHANGELOG.md

+4 −0
Original line number Diff line number Diff line
@@ -6,6 +6,10 @@ 


## ⚠️ Breaking Changes ⚠️



### Logins



- **BREAKING**: Removed deprecated checkpoint API: `set_checkpoint(checkpoint)` and `get_checkpoint()`. They are not in use by desktop and mobile.



### Remote-Settings

 * Removed legacy remote-settings client

 * Renaming `RemoteSettingsConfig2` to `RemoteSettingsConfig`, which will require client updates.

components/logins/src/logins.udl

+0 −6
Original line number Diff line number Diff line
@@ -291,12 +291,6 @@ interface LoginStore { 
    [Throws=LoginsApiError]

    Login? get([ByRef] string id);



    [Throws=LoginsApiError]

    void set_checkpoint([ByRef] string checkpoint);



    [Throws=LoginsApiError]

    string? get_checkpoint();



    /// Run maintenance on the DB

    ///

    /// This is intended to be run during idle time and will take steps / to clean up / shrink the

components/logins/src/schema.rs

+0 −1
Original line number Diff line number Diff line
@@ -211,7 +211,6 @@ const CREATE_LOCAL_BREACHES_TABLE_SQL: &str = " 
pub(crate) static LAST_SYNC_META_KEY: &str = "last_sync_time";

pub(crate) static GLOBAL_SYNCID_META_KEY: &str = "global_sync_id";

pub(crate) static COLLECTION_SYNCID_META_KEY: &str = "passwords_sync_id";

pub(crate) static CHECKPOINT_KEY: &str = "checkpoint";



pub(crate) fn init(db: &Connection) -> Result<()> {

    let user_version = db.conn_ext_query_one::<i64>("PRAGMA user_version")?;

components/logins/src/store.rs

+0 −21
Original line number Diff line number Diff line
@@ -5,7 +5,6 @@ use crate::db::{LoginDb, LoginsDeletionMetrics}; 
use crate::encryption::EncryptorDecryptor;

use crate::error::*;

use crate::login::{BulkResultEntry, EncryptedLogin, Login, LoginEntry, LoginEntryWithMeta};

use crate::schema;

use crate::LoginsSyncEngine;

use parking_lot::Mutex;

use sql_support::run_maintenance;
@@ -318,17 +317,6 @@ impl LoginStore { 
            .and_then(|enc_login| enc_login.decrypt(db.encdec.as_ref()))

    }



    #[handle_error(Error)]

    pub fn set_checkpoint(&self, checkpoint: &str) -> ApiResult<()> {

        self.lock_db()?

            .put_meta(schema::CHECKPOINT_KEY, &checkpoint)

    }



    #[handle_error(Error)]

    pub fn get_checkpoint(&self) -> ApiResult<Option<String>> {

        self.lock_db()?.get_meta(schema::CHECKPOINT_KEY)

    }



    #[handle_error(Error)]

    pub fn run_maintenance(&self, options: Option<RunMaintenanceOptions>) -> ApiResult<()> {

        let conn = self.lock_db()?;
@@ -516,15 +504,6 @@ mod tests { 
        assert_eq!(b_after_update.times_used, 2);

    }



    #[test]

    fn test_checkpoint() {

        ensure_initialized();

        let store = LoginStore::new_in_memory();

        let checkpoint = "a-checkpoint";

        store.set_checkpoint(checkpoint).ok();

        assert_eq!(store.get_checkpoint().unwrap().unwrap(), checkpoint);

    }



    #[test]

    fn test_sync_manager_registration() {

        ensure_initialized();