Commit 2673d556 authored by Matthew Finkel's avatar Matthew Finkel
Browse files

Bug 40034: Disable PWA onboading

parent aa85cb0e
......@@ -22,8 +22,9 @@ class PwaOnboardingObserver(
) : Session.Observer {
override fun onLoadingStateChanged(session: Session, loading: Boolean) {
@SuppressWarnings("CollapsibleIfStatements")
if (!loading && webAppUseCases.isInstallable() && !settings.userKnowsAboutPwas) {
settings.incrementVisitedInstallableCount()
// settings.incrementVisitedInstallableCount()
if (settings.shouldShowPwaOnboarding) {
val directions =
BrowserFragmentDirections.actionBrowserFragmentToPwaOnboardingDialogFragment()
......
......@@ -670,7 +670,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
var userKnowsAboutPwas by booleanPreference(
appContext.getPreferenceKey(R.string.pref_key_user_knows_about_pwa),
default = false
default = true
)
var shouldShowOpenInAppBanner by booleanPreference(
......
......@@ -417,7 +417,7 @@ class SettingsTest {
settings.incrementVisitedInstallableCount()
// Then
assertTrue(settings.shouldShowPwaOnboarding)
assertFalse(settings.shouldShowPwaOnboarding)
}
@Test
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment