Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
The Tor Project
Applications
fenix
Commits
2daf7c31
Commit
2daf7c31
authored
Feb 07, 2020
by
Arturo Mejia
Committed by
Christian Sadilek
Feb 07, 2020
Browse files
For issue #8221: Fix crash in the AddonsManagementFragment when binding
the RecyclerView after the fragment is not attached anymore
parent
e94f5d3d
Changes
1
Hide whitespace changes
Inline
Side-by-side
app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt
View file @
2daf7c31
...
...
@@ -76,26 +76,26 @@ class AddonsManagementFragment : Fragment(R.layout.fragment_add_ons_management),
lifecycleScope
.
launch
(
IO
)
{
try
{
val
addons
=
requireContext
().
components
.
addonManager
.
getAddons
()
lifecycleScope
.
launch
(
Dispatchers
.
Main
)
{
val
adapter
=
AddonsManagerAdapter
(
requireContext
().
components
.
addonCollectionProvider
,
this
@AddonsManagementFragment
,
addons
)
view
.
add_ons_progress_bar
.
isVisible
=
false
view
.
add_ons_empty_message
.
isVisible
=
false
runIfFragmentIsAttached
{
val
adapter
=
AddonsManagerAdapter
(
requireContext
().
components
.
addonCollectionProvider
,
this
@AddonsManagementFragment
,
addons
)
view
.
add_ons_progress_bar
.
isVisible
=
false
view
.
add_ons_empty_message
.
isVisible
=
false
recyclerView
.
adapter
=
adapter
recyclerView
.
adapter
=
adapter
}
}
}
catch
(
e
:
AddonManagerException
)
{
lifecycleScope
.
launch
(
Dispatchers
.
Main
)
{
showSnackBar
(
view
,
getString
(
R
.
string
.
mozac_feature_addons_failed_to_query_add_ons
)
)
view
.
add_ons_progress_bar
.
isVisible
=
false
view
.
add_ons_empty_message
.
isVisible
=
true
runIfFragmentIsAttached
{
showSnackBar
(
view
,
getString
(
R
.
string
.
mozac_feature_addons_failed_to_query_add_ons
))
view
.
add_ons_progress_bar
.
isVisible
=
false
view
.
add_ons_empty_message
.
isVisible
=
true
}
}
}
}
...
...
@@ -165,13 +165,7 @@ class AddonsManagementFragment : Fragment(R.layout.fragment_add_ons_management),
},
onError
=
{
_
,
_
->
this
@AddonsManagementFragment
.
view
?.
let
{
view
->
showSnackBar
(
view
,
getString
(
R
.
string
.
mozac_feature_addons_failed_to_install
,
addon
.
translatedName
)
)
showSnackBar
(
view
,
getString
(
R
.
string
.
mozac_feature_addons_failed_to_install
,
addon
.
translatedName
))
addonProgressOverlay
?.
visibility
=
View
.
GONE
isInstallationInProgress
=
false
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment