GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Commit 7cc59bfb authored by Matthew Finkel's avatar Matthew Finkel

Bug 40034: Disable PWA onboading

parent 45924165
......@@ -22,8 +22,9 @@ class PwaOnboardingObserver(
) : Session.Observer {
override fun onLoadingStateChanged(session: Session, loading: Boolean) {
@SuppressWarnings("CollapsibleIfStatements")
if (!loading && webAppUseCases.isInstallable() && !settings.userKnowsAboutPwas) {
settings.incrementVisitedInstallableCount()
// settings.incrementVisitedInstallableCount()
if (settings.shouldShowPwaCfr) {
val directions =
BrowserFragmentDirections.actionBrowserFragmentToPwaOnboardingDialogFragment()
......
......@@ -683,7 +683,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
var userKnowsAboutPwas by booleanPreference(
appContext.getPreferenceKey(R.string.pref_key_user_knows_about_pwa),
default = false
default = true
)
var shouldShowOpenInAppBanner by booleanPreference(
......
......@@ -431,7 +431,7 @@ class SettingsTest {
settings.incrementVisitedInstallableCount()
// Then
assertTrue(settings.shouldShowPwaCfr)
assertFalse(settings.shouldShowPwaCfr)
}
@Test
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment