Bug 40034: Disable PWA onboading

app/src/main/java/org/mozilla/fenix/shortcut/PwaOnboardingObserver.kt

@@ -22,8 +22,9 @@ class PwaOnboardingObserver(
 ) : Session.Observer {
 
     override fun onLoadingStateChanged(session: Session, loading: Boolean) {
+        @SuppressWarnings("CollapsibleIfStatements")
         if (!loading && webAppUseCases.isInstallable() && !settings.userKnowsAboutPwas) {
-            settings.incrementVisitedInstallableCount()
+            // settings.incrementVisitedInstallableCount()
             if (settings.shouldShowPwaCfr) {
                 val directions =
                     BrowserFragmentDirections.actionBrowserFragmentToPwaOnboardingDialogFragment()

app/src/main/java/org/mozilla/fenix/utils/Settings.kt

@@ -728,7 +728,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
 
     var userKnowsAboutPwas by booleanPreference(
         appContext.getPreferenceKey(R.string.pref_key_user_knows_about_pwa),
-        default = false
+        default = true
     )
 
     var shouldShowOpenInAppBanner by booleanPreference(

app/src/test/java/org/mozilla/fenix/utils/SettingsTest.kt

@@ -445,7 +445,7 @@ class SettingsTest {
         settings.incrementVisitedInstallableCount()
 
         // Then
-        assertTrue(settings.shouldShowPwaCfr)
+        assertFalse(settings.shouldShowPwaCfr)
     }
 
     @Test