Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
The Tor Project
Applications
fenix
Commits
d0ee6fe3
Commit
d0ee6fe3
authored
Oct 22, 2020
by
Alex Catarineu
Browse files
Bug 40095: Hide "Sign in to sync" in bookmarks
parent
03b642ac
Changes
1
Hide whitespace changes
Inline
Side-by-side
app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt
View file @
d0ee6fe3
...
...
@@ -48,7 +48,6 @@ import org.mozilla.fenix.ext.bookmarkStorage
import
org.mozilla.fenix.ext.components
import
org.mozilla.fenix.ext.minus
import
org.mozilla.fenix.ext.nav
import
org.mozilla.fenix.ext.requireComponents
import
org.mozilla.fenix.ext.toShortUrl
import
org.mozilla.fenix.library.LibraryPageFragment
import
org.mozilla.fenix.utils.allowUndo
...
...
@@ -129,16 +128,9 @@ class BookmarkFragment : LibraryPageFragment<BookmarkNode>(), UserInteractionHan
@ExperimentalCoroutinesApi
override
fun
onViewCreated
(
view
:
View
,
savedInstanceState
:
Bundle
?)
{
super
.
onViewCreated
(
view
,
savedInstanceState
)
val
accountManager
=
requireComponents
.
backgroundServices
.
accountManager
consumeFrom
(
bookmarkStore
)
{
bookmarkView
.
update
(
it
)
// Only display the sign-in prompt if we're inside of the virtual "Desktop Bookmarks" node.
// Don't want to pester user too much with it, and if there are lots of bookmarks present,
// it'll just get visually lost. Inside of the "Desktop Bookmarks" node, it'll nicely stand-out,
// since there are always only three other items in there. It's also the right place contextually.
bookmarkView
.
view
.
bookmark_folders_sign_in
.
isVisible
=
it
.
tree
?.
guid
==
BookmarkRoot
.
Root
.
id
&&
accountManager
.
authenticatedAccount
()
==
null
bookmarkView
.
view
.
bookmark_folders_sign_in
.
isVisible
=
false
}
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment