Resolve Detekt failures

Fixed upstream on master with 52d4ffde

app/src/main/java/org/mozilla/fenix/AppRequestInterceptor.kt

@@ -28,7 +28,8 @@ class AppRequestInterceptor(private val context: Context) : RequestInterceptor {
     ): RequestInterceptor.InterceptionResponse? {
         return context.components.services.appLinksInterceptor
             .onLoadRequest(
-                engineSession, uri, lastUri, hasUserGesture, isSameDomain, isRedirect, isDirectNavigation, isSubframeRequest
+                engineSession, uri, lastUri, hasUserGesture, isSameDomain,
+                    isRedirect, isDirectNavigation, isSubframeRequest
             )
     }
 

app/src/main/java/org/mozilla/fenix/browser/ToolbarGestureHandler.kt

@@ -35,6 +35,7 @@ import kotlin.math.min
  * Handles intercepting touch events on the toolbar for swipe gestures and executes the
  * necessary animations.
  */
+@SuppressWarnings("LargeClass", "TooManyFunctions")
 class ToolbarGestureHandler(
     private val activity: Activity,
     private val contentLayout: View,
@@ -67,6 +68,7 @@ class ToolbarGestureHandler(
 
     private var gestureDirection = GestureDirection.LEFT_TO_RIGHT
 
+    @SuppressWarnings("ComplexCondition")
     override fun onSwipeStarted(start: PointF, next: PointF): Boolean {
         val dx = next.x - start.x
         val dy = next.y - start.y

app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt

@@ -95,6 +95,7 @@ class LeanplumMetricsService(
         deviceId
     }
 
+    @SuppressWarnings("ComplexMethod")
     override fun start() {
 
         if (!application.settings().isMarketingTelemetryEnabled) return
@@ -255,7 +256,7 @@ class LeanplumMetricsService(
             "jpn" // Japanese
         )
 
-        private val PREFERENCE_NAME = "LEANPLUM_PREFERENCES"
-        private val DEVICE_ID_KEY = "LP_DEVICE_ID"
+        private const val PREFERENCE_NAME = "LEANPLUM_PREFERENCES"
+        private const val DEVICE_ID_KEY = "LP_DEVICE_ID"
     }
 }

app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt

@@ -532,6 +532,7 @@ sealed class Event {
         get() = null
 }
 
+@SuppressWarnings("LongMethod")
 private fun Fact.toEvent(): Event? = when (Pair(component, item)) {
     Component.FEATURE_PROMPTS to LoginDialogFacts.Items.DISPLAY -> Event.LoginDialogPromptDisplayed
     Component.FEATURE_PROMPTS to LoginDialogFacts.Items.CANCEL -> Event.LoginDialogPromptCancelled

app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt

@@ -250,6 +250,7 @@ class BrowserToolbarView(
         private const val TOOLBAR_ELEVATION = 16
     }
 
+    @SuppressWarnings("ComplexCondition")
     private fun ToolbarMenu.Item.performHapticIfNeeded(view: View) {
         if (this is ToolbarMenu.Item.Reload && this.bypassCache ||
             this is ToolbarMenu.Item.Back && this.viewHistory ||

app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt

@@ -33,6 +33,7 @@ import org.mozilla.fenix.search.SearchFragmentState
 /**
  * View that contains and configures the BrowserAwesomeBar
  */
+@SuppressWarnings("LargeClass")
 class AwesomeBarView(
     private val container: ViewGroup,
     val interactor: AwesomeBarInteractor,

app/src/main/java/org/mozilla/fenix/tabhistory/TabHistoryViewHolder.kt

@@ -33,7 +33,9 @@ class TabHistoryViewHolder(
         history_layout.loadFavicon(item.url)
 
         if (item.isSelected) {
-            history_layout.setBackgroundColor(history_layout.context.getColorFromAttr(R.attr.tabHistoryItemSelectedBackground))
+            history_layout.setBackgroundColor(
+                history_layout.context.getColorFromAttr(
+                    R.attr.tabHistoryItemSelectedBackground))
         } else {
             history_layout.background = null
         }

config/detekt.yml

@@ -76,7 +76,7 @@ complexity:
     # https://github.com/mozilla-mobile/fenix/issues/4861
     threshold: 75
   LongParameterList:
-    active: trued
+    active: true
     excludes: "**/*Controller.kt, **/*Integration.kt"
     functionThreshold: 6
     constructorThreshold: 7