1. 20 Feb, 2021 1 commit
  2. 10 Dec, 2020 1 commit
  3. 03 Dec, 2020 1 commit
  4. 03 Sep, 2020 1 commit
  5. 02 Sep, 2020 1 commit
  6. 19 Aug, 2020 3 commits
  7. 21 Jul, 2020 1 commit
  8. 22 Jun, 2020 1 commit
  9. 10 Jun, 2020 2 commits
  10. 02 Jun, 2020 1 commit
  11. 01 Jun, 2020 1 commit
  12. 22 May, 2020 1 commit
    • Grisha Kruglov's avatar
      For #10494: Process HomeMenu builder changes on the main thread · b26ac51e
      Grisha Kruglov authored
      Problem was that we were trying to process menu changes (in response to account manager events) on some background thread as that's what account manager emits them on, so some code internally in PopupWindow's dismiss handling (i think, didn't dig very deeply here) was silently giving up and we'd get into a bad state.
      
      The reason this seemingly only happened if you quickly opened a menu on startup is because account manager isn't initialized until sometime after the startup finished. So the trick was to open the menu (and register account manager state callbacks) before it got initialized, so that the callbacks are invoked.
      
      This should also reproduce in other, much more obscure ways, e.g. if you open the menu right before sync is scheduled to run in the background, change FxA password on another connected client, and then eventually receive a onAuthenticationProblem callback.
      b26ac51e
  13. 11 May, 2020 1 commit
  14. 01 Apr, 2020 3 commits
  15. 31 Mar, 2020 3 commits
    • Grisha Kruglov's avatar
      Make sure reconnect item is displayed in HomeMenu in case of account problems · 54b7fd88
      Grisha Kruglov authored
      AccountObserver listeners were being triggered correctly, however, during every time
      we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
      block. Before this patch, the init block would never touch the account manager.
      After this patch, it will query it if account manager has already been initialized.
      54b7fd88
    • Grisha Kruglov's avatar
      Closes #9561: Fix initialization order in HomeMenu · 60943df6
      Grisha Kruglov authored
      `init` blocks are executed before `val` initialization which is declared afterwards
      in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
      but declared after the `init` block which may need them. And so, while this compiles
      just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.
      
      Simply re-ordering initialization fixes the problem.
      60943df6
    • Grisha Kruglov's avatar
      Part 5: Refactor HomeMenu<->HomeFragment interaction · 057e28d4
      Grisha Kruglov authored
      This refactor "reverses" relationship between these two classes, allowing
      HomeMenu to inform its parent, HomeFragment, of any changes to the menu.
      
      Once that's in place, we start observing account manager changes (once its ready)
      for account problems.
      
      This solves two problems:
      - initialization of the account manager is no longer necessary to build a home menu
      - home menu now starts observing changes to the account manager's state (before it was static)
      057e28d4
  16. 21 Mar, 2020 1 commit
  17. 02 Mar, 2020 1 commit
  18. 27 Feb, 2020 1 commit
  19. 19 Dec, 2019 1 commit
  20. 29 Nov, 2019 1 commit
  21. 21 Nov, 2019 2 commits
  22. 31 Oct, 2019 1 commit
  23. 04 Oct, 2019 1 commit
  24. 18 Sep, 2019 1 commit
  25. 03 Sep, 2019 1 commit
  26. 21 Aug, 2019 1 commit
  27. 12 Jul, 2019 1 commit
  28. 30 May, 2019 1 commit
  29. 23 Apr, 2019 1 commit
  30. 15 Apr, 2019 1 commit
  31. 06 Mar, 2019 1 commit
  32. 25 Feb, 2019 1 commit