1. 13 Feb, 2020 1 commit
  2. 12 Feb, 2020 1 commit
  3. 07 Feb, 2020 2 commits
  4. 06 Feb, 2020 4 commits
  5. 05 Feb, 2020 1 commit
  6. 04 Feb, 2020 1 commit
  7. 03 Feb, 2020 1 commit
  8. 29 Jan, 2020 1 commit
  9. 24 Jan, 2020 3 commits
  10. 22 Jan, 2020 2 commits
  11. 17 Jan, 2020 1 commit
  12. 06 Jan, 2020 1 commit
  13. 27 Dec, 2019 1 commit
  14. 19 Dec, 2019 1 commit
  15. 17 Dec, 2019 1 commit
  16. 14 Dec, 2019 1 commit
  17. 06 Dec, 2019 1 commit
  18. 05 Dec, 2019 1 commit
    • Gabriel's avatar
      For #5574 - Migrate SessionControl to LibState (#6651) · 56b21426
      Gabriel authored
      * For #5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (#6651)
      
      - Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
      - Removes the TabAction.SaveTabGroup.
      
      * For #5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (#6651)
      
      In #2205, the tab overflow button was removed which would have shown the
      TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
      used and as a result, we can also remove TabAction.Share since there are
      no consumers.
      
      * For #5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (#6651)
      
      - Removes TabAction
      
      * For #5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (#6651)
      
      * For #5574 - Part 15: Introduce a HomeFragmentStore (#6651)
      
      - We will hook up the HomeFragmentStore in later parts.
      - Removes List<Tab>.toSessionBundle(context: Context) since it is unused.
      
      * For #5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (#6651)
      
      - We assume the store is hooked up to the SessionControlController in this part,
      but this work will be done in a later part.
      - Removes CollectionAction.
      
      * For #5574 - Part 20: Remove the architecture module. (#6651)
      
      * For #5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (#6651)
      
      There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
      In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
      BrowserFragment in order to dispatch the CollectionsChange event.
      
      * For #5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (#6651)
      
      * For #5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (#6651)
      
      - Renames SessionControlUIView to SessionControlView
      
      * For #5574 - Part 21: Fix white screen on home fragment (#6651)
      
      * For #5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (#6651)
      
      * For #5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (#6651)
      
      This ensures that the metrics.track will be called immediately before the tab is removed from the collection.
      
      * For #5574 - Part 24: Use the sessionManager getter in SessionControlController (#6651)
      
      * For #5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (#6651)
      
      * For #5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (#6651)
      
      * For #5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (#6651)
      
      * For #5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (#6651)
      
      * For #5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (#6651)
      
      * For #5574 - Removes running CI against the architecture debug build varient
      56b21426
  19. 02 Dec, 2019 1 commit
  20. 27 Nov, 2019 1 commit
  21. 15 Nov, 2019 1 commit
    • Severin Rudie's avatar
      4844 fix url elision (#6588) · 8d683173
      Severin Rudie authored
      * For #4844: add test cases for url elision
      
      * For 4844: implement toShortUrl to pass test cases
      
      * For 4844: update plumbing to use toShortUrl
      
      * For 4844: adds/handles suggested url elision test case
      8d683173
  22. 13 Nov, 2019 1 commit
  23. 23 Oct, 2019 1 commit
    • Severin Rudie's avatar
      #4596 migrate collections (#5911) · aa8642f5
      Severin Rudie authored
      * For #4596: move code from CollectionCreationComponent to CollectionCreationStore
      
      Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.
      
      * For 4596: update CollectionCreateStore to libstate
      
      * For 4596: copied CollectionCreationUIView into CollectionCreationView
      
      Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.
      
      * For 4596: update CollectionCreationView to LibState
      
      Note that the minimal changes possible to enable migration were made.  Refactoring will happen in a later commit.
      
      * For 4596: updated CollectionCreationTabListAdapter to work with the new View
      
      * For 4596: updated SaveCollectionListAdapter to work with the new View
      
      * For 4596: implemented CollectionCreationController
      
      For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer
      
      * For 4596: copied over previous reducer code
      
      No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer
      
      * For 4596: update reducer code param names
      
      Otherwise, no changes at this time
      
      * For 4596: add arguments to CreateCollectionFragment in nav_graph
      
      These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.
      
      * For 4596: pass arguments to collection via transaction instead of VM
      
      The VM will be removed in a later commit
      
      * For 4596: update BrowserToolbarController to share state to collection via its Direction
      
      * For 4596: removed CreateCollectionViewModel
      
      * For 4596: test tab retrieval in CreateCollectionFragment
      
      * For 4596: fix crashing CreateCollectionFragmentTest
      
      * For 4596: removed classes create collection classes used by old architecture
      
      * For 4596: collection interactor rename + kdoc
      
      * For 4596: moved collection interactor interface
      
      * For 4596: renamed CreateCollectionFragment
      
      All related classes followed the pattern of CollectionCreationX
      
      * For 4596: kdoc CollectionCreationController
      
      There's no effective difference between these calls and their interactor equivalent, so I linked to them
      
      * For 4596: fix bug that caused rename to not work
      
      * For 4596: removed unused collection actions
      
      These were unused before the LibState refactor
      
      * For 4596: kdoc StepChanged
      
      * For 4596: removed todos about moving logic to the reducer
      
      saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive
      
      handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here
      
      stepBack: called by handleBackPress. See above
      
      * For 4596: wrote tests for CollectionCreationController#stepback
      
      * For 4596: fixed tests broken by changes to collections
      
      * For 4596: small readability refactor for CollectionController#stepBack
      
      No change to functionality (see tests)
      
      * For 4596: broke apart CollectionView#update
      
      There's probably a lot more that could be done here, but smaller changes were made to reduce scope
      
      * For 4596: remove unnecessary todos
      
      It looks like we don't follow the suggested pattern in this project
      
      * For 4596: test CollectionCreationController#normalSessionSize
      
      * For 4596: updated naming in CollectionCreationController per review
      aa8642f5
  24. 21 Oct, 2019 1 commit
  25. 18 Oct, 2019 1 commit
  26. 10 Oct, 2019 1 commit
    • Mugurell's avatar
      For #3584 - Check if menu is open before showing a new one (#5674) · 8f0325c0
      Mugurell authored
      Could have implemented this check (if menu is showing) inside the show() method
      of BrowserMenu but this would mean the client (us) would go to the process of
      building a new menu and then trying to have it displayed only for this to be
      ignored by BrowserMenu in a somewhat opaque way.
      Having this check done as soon as possible offers us full control and avoids
      the unnecessary steps for building an already shown menu.
      8f0325c0
  27. 07 Oct, 2019 1 commit
  28. 06 Oct, 2019 1 commit
  29. 26 Sep, 2019 1 commit
  30. 25 Sep, 2019 3 commits
  31. 24 Sep, 2019 1 commit