1. 23 Oct, 2020 3 commits
  2. 22 Sep, 2020 1 commit
  3. 01 Sep, 2020 1 commit
  4. 28 Aug, 2020 1 commit
  5. 24 Aug, 2020 1 commit
  6. 21 Jul, 2020 1 commit
  7. 17 Jul, 2020 1 commit
  8. 27 Jun, 2020 1 commit
  9. 25 Jun, 2020 1 commit
  10. 09 Jun, 2020 1 commit
  11. 29 May, 2020 1 commit
  12. 03 Apr, 2020 1 commit
    • Michael Comella's avatar
      For #9605: replace unit test runners with FenixRobolectricTestRunner. · 6e0d851d
      Michael Comella authored
      This is how we can apply the new test runner to remove duplication.
      
      This commit was generated programmatically with the following commands:
      ```
        // Replace test runners with new one.
        find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
        find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
      
        // Replace imports of old test runners with new one
        find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
        find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
      
        // Remove unused imports
        find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
        find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
        find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
      ```
      
      Where gsed is the GNU version of sed installed via homebrew. After
      running these commands, I need to manually clean up the following files:
      - FenixRobolectricTestRunner
      - LocaleManagerExtensionTest
      6e0d851d
  13. 20 Mar, 2020 1 commit
  14. 11 Mar, 2020 1 commit
  15. 25 Feb, 2020 1 commit
  16. 12 Nov, 2019 1 commit
    • Severin Rudie's avatar
      4281 remove qab (#6310) · 6909a76b
      Severin Rudie authored
      * For #4281: small ToolbarMenu refactor
      
      This makes it easier to see how items are ordered in the menuItems list
      
      * For 4281: add QAB buttons to menu
      
      * For 4281: removed menu back button per mocks
      
      I double checked with UX, and we'll be relying on the hardware back button for its functionality
      
      * For 4281: add content descriptions for bookmarking
      
      * For 4281: updated BrowserToolbarController for new functionality
      
      * For 4281: provided simple dependencies to browser controller
      
      More complex changes will be in a following commit, for review readability
      
      * For 4281: move toolbar controller dependencies up to BaseBrowserFragment
      
      The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones
      
      * For 4281: removed (now unused) code related to QAB
      
      * For 4281: fix test compilation after QAB removal
      
      Tests still need to be expanded to include added functionality
      
      * For 4281: updated menu to show if url is bookmarked
      
      This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.
      
      https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
      https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.
      
      * For 4281: update reader mode switch
      
      * For 4281: selectively show/hide menu items
      
      * For 4281: add reader mode appearance
      
      * For 4281: update bookmark button when it is clicked
      
      * For 4281: removed unused QAB code
      
      * For 4281: removed QAB robot, updated UI tests
      
      * For 4281: removed QuickActionSheet metrics
      
      Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped
      
      * For 4281: fixed lint errors
      
      * For 4281: add new strings for buttons added to menu
      
      This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages
      
      * For 4281: remove outdated TODOs
      
      * For 4281: removed QAB container
      
      * For 4281: removed back button reference from UI test
      
      This button no longer exists
      
      * For 4821: Fixes a visual defect (extra padding on top of toolbar)
      
      * For 4281: update copy on reader mode
      
      * For 4281: fixed review nits
      6909a76b
  17. 07 Nov, 2019 1 commit
  18. 09 Oct, 2019 2 commits
  19. 08 Oct, 2019 1 commit
  20. 03 Oct, 2019 2 commits
  21. 02 Oct, 2019 1 commit
  22. 24 Sep, 2019 1 commit
  23. 20 Sep, 2019 2 commits
  24. 19 Sep, 2019 1 commit
  25. 11 Sep, 2019 2 commits
  26. 10 Sep, 2019 1 commit
  27. 05 Sep, 2019 1 commit
  28. 21 Aug, 2019 1 commit
  29. 20 Aug, 2019 1 commit
  30. 07 Aug, 2019 1 commit
  31. 12 Jul, 2019 1 commit
  32. 25 Jun, 2019 1 commit
  33. 24 Jun, 2019 1 commit