Fenix still sends telemetry pings to Mozilla

We got contacted by Mozilla folks who saw telemetry pings sent by Tor Browser alpha (more precise by a thing with the appId "org-torproject-torbrowser-alpha".

Replacing the if/else block in app/build.gradle with buildConfigField 'boolean', 'TELEMETRY', 'false' should do the trick.

I think we are trying something similar in our fix for #33594 (closed) but it seems it is not working.

This started around 10/12/2020 and boils down to about 5000 pings for that week.

If sending is enabled we would see something like

2020-10-19 13:40:00.191 16559-16619/org.mozilla.fenix.debug
I/libglean_ffi: glean_core::ping: Collecting baseline
2020-10-19 13:40:00.191 16559-16619/org.mozilla.fenix.debug
I/libglean_ffi: glean_core::ping: Storage for baseline empty. Ping will
still be sent.
2020-10-19 13:40:00.201 16559-16619/org.mozilla.fenix.debug
D/libglean_ffi: glean_core::ping: Storing ping
'3528460e-39af-4888-b979-0f2035696fc1' at
'/data/user/0/org.mozilla.fenix.debug/glean_data/pending_pings/3528460e-39af-4888-b979-0f2035696fc1'
2020-10-19 13:40:00.203 16559-16619/org.mozilla.fenix.debug
I/libglean_ffi: glean_core::upload::directory: Processing ping at:
/data/user/0/org.mozilla.fenix.debug/glean_data/pending_pings/3528460e-39af-4888-b979-0f2035696fc1
2020-10-19 13:40:00.205 16559-16619/org.mozilla.fenix.debug
I/libglean_ffi: glean_core: The ping 'baseline' was submitted and will
be sent as soon as possible

in the logs. (relevant keywords here are "Collecting", "Processing", and "submitted" and all of that would not happen if uploading weren't enabled) The actual request would then look something like

2020-10-19 13:43:31.995 16897-17078/org.mozilla.fenix.debug
D/glean/ConceptFetchHttpUploader: Submitting ping to:
https://incoming.telemetry.mozilla.org/submit/org-mozilla-fenix-debug/baseline/1/f19ab3e4-c975-4f0b-bc6d-bbd928ad69a2

I got told that initializeGlean() seems to work around disabling telemetry in the build.gradle file. So, maybe that's what we are hitting here.

In general removing any call to Glean.initialize() should do the trick. Even leaving the call to initialize enabled would be okay, I got told, if false was passed to the uploadEnabled parameter.