Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • F fenix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 67
    • Issues 67
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • fenix
  • Issues
  • #40145

Closed
Open
Created Feb 01, 2021 by Matthew Finkel@sysrqbMaintainer

Suppress EmptyFunctionBlock detekt violation

In 24abe628 we add updateSecurityLevel and handleOpenSecurityLevelSettingsClicked, but they are only stubs. Later, in d95db65d, we implement those functions.

When we run detekt on 24abe628 the above two functions are reported as violating EmptyFunctionBlock (and we use that that commit because it is the last patch that successfully links with Mozilla's MozAC). Let's clean up this reported violation by suppressing that rule in 24abe628, and then delete it in d95db65d.

Assignee
Assign to
Time tracking