Commit 23812589 authored by henry's avatar henry Committed by Pier Angelo Vendrame
Browse files

fixup! BB 32308: Use direct browser sizing for letterboxing. 

TB 44214: Drop letterboxing gradient.
parent f1439632

toolkit/components/resistfingerprinting/RFPHelper.sys.mjs

+0 −9
Original line number Diff line number Diff line
@@ -17,8 +17,6 @@ const kPrefLetterboxingTesting = 
  "privacy.resistFingerprinting.letterboxing.testing";

const kPrefLetterboxingVcenter =

  "privacy.resistFingerprinting.letterboxing.vcenter";

const kPrefLetterboxingGradient =

  "privacy.resistFingerprinting.letterboxing.gradient";



const kTopicDOMWindowOpened = "domwindowopened";

const kTopicDOMWindowClosed = "domwindowclosed";
@@ -56,7 +54,6 @@ class _RFPHelper { 
    Services.prefs.addObserver(kPrefResistFingerprinting, this);

    Services.prefs.addObserver(kPrefLetterboxing, this);

    Services.prefs.addObserver(kPrefLetterboxingVcenter, this);

    Services.prefs.addObserver(kPrefLetterboxingGradient, this);



    XPCOMUtils.defineLazyPreferenceGetter(

      this,
@@ -89,7 +86,6 @@ class _RFPHelper { 


    // Remove unconditional observers

    Services.prefs.removeObserver(kPrefResistFingerprinting, this);

    Services.prefs.removeObserver(kPrefLetterboxingGradient, this);

    Services.prefs.removeObserver(kPrefLetterboxingVcenter, this);

    Services.prefs.removeObserver(kPrefLetterboxing, this);

    // Remove the RFP observers, swallowing exceptions if they weren't present
@@ -143,7 +139,6 @@ class _RFPHelper { 
        break;

      case kPrefLetterboxing:

      case kPrefLetterboxingVcenter:

      case kPrefLetterboxingGradient:

        this._handleLetterboxingPrefChanged();

        break;

      default:
@@ -615,10 +610,6 @@ class _RFPHelper { 
      "letterboxing-vcenter",

      Services.prefs.getBoolPref(kPrefLetterboxingVcenter, false)

    );

    tabBrowser.tabpanels?.classList.toggle(

      "letterboxing-gradient",

      Services.prefs.getBoolPref(kPrefLetterboxingGradient, false)

    );



    for (let tab of tabBrowser.tabs) {

      let browser = tab.linkedBrowser;

toolkit/components/resistfingerprinting/content/letterboxing.css

+0 −7
Original line number Diff line number Diff line
@@ -14,8 +14,6 @@ 
  --letterboxing-border-top-radius: 0;

  --letterboxing-vertical-alignment: start;

  --letterboxing-shadow-color: rgba(12, 12, 13, 0.1);

  --letterboxing-gradient-color1: var(--letterboxing-bgcolor);

  --letterboxing-gradient-color2: color-mix(in srgb, var(--chrome-content-separator-color) 50%, var(--letterboxing-bgcolor));

  --letterboxing-border-color: var(--letterboxing-bgcolor);

  --letterboxing-decorator-visibility: visible;
@@ -36,7 +34,6 @@ 
    border-top-right-radius: var(--letterboxing-border-top-radius);

    width: var(--letterboxing-width) !important;

    height: var(--letterboxing-height) !important;

    background: var(--letterboxing-gradient-color2);

  }

}
@@ -53,10 +50,6 @@ 
  --letterboxing-vertical-alignment: center;

}



.letterboxing.letterboxing-gradient .browserContainer {

  background: linear-gradient(283deg, var(--letterboxing-gradient-color1) 0%, var(--letterboxing-gradient-color2) 100%), var(--letterboxing-bgcolor);

}



:root:not([inDOMFullscreen]) .letterboxing .browserContainer:not(.responsive-mode) > .browserStack:not(.exclude-letterboxing) > .browserDecorator {

  display: initial;

  visibility: var(--letterboxing-decorator-visibility);