Commit 4954a5b0 authored by Andreas Pehrson's avatar Andreas Pehrson
Browse files

Bug 1509548 - Remove early PullNewData return. r=padenot 

Without knownTracksTime, StreamTracks::GetFirstTrackEnd() returns
STREAM_TIME_MAX for an empty StreamTracks, so PullNewData() thinks no new data
is needed.

This circumvents that by always checking whether tracks need data.

Differential Revision: https://phabricator.services.mozilla.com/D12928

--HG--
extra : moz-landing-system : lando
parent 3410ec9f

dom/media/MediaStreamGraph.cpp

+0 −3
Original line number Diff line number Diff line
@@ -2525,9 +2525,6 @@ bool SourceMediaStream::PullNewData(GraphTime aDesiredUpToTime) { 
      ("%p: Calling NotifyPull aStream=%p t=%f current end=%f", GraphImpl(),

       this, GraphImpl()->MediaTimeToSeconds(t),

       GraphImpl()->MediaTimeToSeconds(current)));

  if (t <= current) {

    return false;

  }

  for (const TrackData& track : mUpdateTracks) {

    if (track.mCommands & TrackEventCommand::TRACK_EVENT_ENDED) {

      continue;