Commit 7dc13808 authored by Beth Rennie's avatar Beth Rennie
Browse files

Bug 1787290 - Cache isDefaultBrowser in ASRouter targeting r=Mardak 

Differential Revision: https://phabricator.services.mozilla.com/D155646
parent e0367698

browser/components/newtab/lib/ASRouterTargeting.jsm

+7 −1
Original line number Diff line number Diff line
@@ -277,6 +277,12 @@ const QueryCache = { 
      FRECENT_SITES_UPDATE_INTERVAL,

      ShellService

    ),

    isDefaultBrowser: new CachedTargetingGetter(

      "isDefaultBrowser",

      null,

      FRECENT_SITES_UPDATE_INTERVAL,

      ShellService

    ),

    currentThemes: new CachedTargetingGetter(

      "getAddonsByTypes",

      ["theme"],
@@ -507,7 +513,7 @@ const TargetingGetters = { 
  },

  get isDefaultBrowser() {

    try {

      return ShellService.isDefaultBrowser();

      return QueryCache.getters.isDefaultBrowser.get();

    } catch (e) {}

    return null;

  },

browser/components/newtab/test/browser/browser_asrouter_targeting.js

+1 −1
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ add_task(async function checksearchEngines() { 


add_task(async function checkisDefaultBrowser() {

  const expected = ShellService.isDefaultBrowser();

  const result = ASRouterTargeting.Environment.isDefaultBrowser;

  const result = await ASRouterTargeting.Environment.isDefaultBrowser;

  is(typeof result, "boolean", "isDefaultBrowser should be a boolean value");

  is(

    result,