Commit 818be8be authored by Samuel Vargas's avatar Samuel Vargas
Browse files

Bug 1381610 - Check bindRenderbuffer called before framebufferRenderbuffer. r=jgilbert

parent 474db8c1

dom/canvas/WebGLFramebuffer.cpp

+11 −2
Original line number Diff line number Diff line
@@ -1389,9 +1389,18 @@ WebGLFramebuffer::FramebufferRenderbuffer(const char* funcName, GLenum attachEnu 
    }



    // `rb`

    if (rb && !mContext->ValidateObject("framebufferRenderbuffer: rb", *rb))

    if (rb) {

        if (!mContext->ValidateObject("framebufferRenderbuffer: rb", *rb))

            return;



        if (!rb->mHasBeenBound) {

            mContext->ErrorInvalidOperation("%s: bindRenderbuffer must be called before"

                                            " attachment to %04x",

                                            funcName, attachEnum);

            return;

      }

    }



    // End of validation.



    if (mContext->IsWebGL2() && attachEnum == LOCAL_GL_DEPTH_STENCIL_ATTACHMENT) {