Commit 82e32884 authored by Andrew Halberstadt's avatar Andrew Halberstadt
Browse files

Bug 1717427 - [tryselect] Use 'raise_for_status' when downloading estimates data, r=mhentges 

These requests had except blocks to catch all requests exceptions. But because
we weren't calling 'raise_for_status', exceptions were never raised, resulting
in bizarre error tracebacks later on.

Depends on D118356

Differential Revision: https://phabricator.services.mozilla.com/D118357
parent 6aec441f

tools/tryselect/util/manage_estimates.py

+2 −0
Original line number Diff line number Diff line
@@ -67,6 +67,7 @@ def download_task_history_data(cache_dir): 


    try:

        r = requests.get(TASK_DURATION_URL, stream=True)

        r.raise_for_status()

    except requests.exceptions.RequestException as exc:

        # This is fine, the durations just won't be in the preview window.

        print(
@@ -90,6 +91,7 @@ def download_task_history_data(cache_dir): 


    try:

        r = requests.get(GRAPH_QUANTILES_URL, stream=True)

        r.raise_for_status()

    except requests.exceptions.RequestException as exc:

        # This is fine, the percentile just won't be in the preview window.

        print(