Commit 8c44b387 authored by Sergey Galich's avatar Sergey Galich
Browse files

Bug 1786329 - Remove signon.showAutoCompleteOrigins pref r=dimi 

Differential Revision: https://phabricator.services.mozilla.com/D155255
parent b7f9e854

modules/libpref/init/all.js

+0 −1
Original line number Diff line number Diff line
@@ -3455,7 +3455,6 @@ pref("signon.includeOtherSubdomainsInLookup", true); 
// This temporarily prevents the primary password to reprompt for autocomplete.

pref("signon.masterPasswordReprompt.timeout_ms", 900000); // 15 Minutes

pref("signon.showAutoCompleteFooter",             false);

pref("signon.showAutoCompleteOrigins",            true);



// Satchel (Form Manager) prefs

pref("browser.formfill.debug",            false);

toolkit/components/passwordmgr/LoginAutoComplete.jsm

+1 −6
Original line number Diff line number Diff line
@@ -29,11 +29,6 @@ XPCOMUtils.defineLazyServiceGetter( 
  "@mozilla.org/satchel/form-fill-controller;1",

  Ci.nsIFormFillController

);

XPCOMUtils.defineLazyPreferenceGetter(

  lazy,

  "SHOULD_SHOW_ORIGIN",

  "signon.showAutoCompleteOrigins"

);

XPCOMUtils.defineLazyGetter(lazy, "log", () => {

  return lazy.LoginHelper.createLogger("LoginAutoComplete");

});
@@ -138,7 +133,7 @@ class LoginAutocompleteItem extends AutocompleteItem { 
    actor,

    isOriginMatched

  ) {

    super(lazy.SHOULD_SHOW_ORIGIN ? "loginWithOrigin" : "login");

    super("loginWithOrigin");

    this.login = login.QueryInterface(Ci.nsILoginMetaInfo);

    this.#actor = actor;

toolkit/components/passwordmgr/test/mochitest/test_autocomplete_basic_form_subdomain.html

+0 −1
Original line number Diff line number Diff line
@@ -72,7 +72,6 @@ add_setup(async () => { 
  await SpecialPowers.pushPrefEnv({

    set: [

      ["signon.includeOtherSubdomainsInLookup", true],

      ["signon.showAutoCompleteOrigins", true],

    ],

  });

  listenForUnexpectedPopupShown();

toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation.html

+0 −1
Original line number Diff line number Diff line
@@ -216,7 +216,6 @@ add_task(async function test_autofillAutocompleteUsername_noGeneration2() { 
  await SpecialPowers.pushPrefEnv({"set": [

    ["signon.generation.available", true],

    ["signon.generation.enabled", true],

    ["signon.showAutoCompleteOrigins", true],

  ]});



  // 2nd form should not be filled

toolkit/components/passwordmgr/test/unit/test_login_autocomplete_result.js

+0 −1
Original line number Diff line number Diff line
@@ -657,7 +657,6 @@ add_task(async function test_all_patterns() { 


  LoginHelper.createLogger("LoginAutoCompleteResult");

  Services.prefs.setBoolPref("signon.showAutoCompleteFooter", true);

  Services.prefs.setBoolPref("signon.showAutoCompleteOrigins", true);



  expectedResults.forEach((pattern, testIndex) => {

    info(`expectedResults[${testIndex}]`);