Commit a2132d95 authored by Sarah Clements's avatar Sarah Clements
Browse files

Bug 1789042 - Prepend page-icon to url if image is null in Recently Closed Tabs list r=mak 

Differential Revision: https://phabricator.services.mozilla.com/D160050
parent 4540b14b

browser/components/firefoxview/helpers.mjs

+2 −2
Original line number Diff line number Diff line
@@ -45,10 +45,10 @@ export function convertTimestamp( 
  return formattedTime;

}



export function createFaviconElement(image) {

export function createFaviconElement(image, targetURI = "") {

  const imageUrl = image

    ? lazy.PlacesUIUtils.getImageURL(image)

    : "chrome://global/skin/icons/defaultFavicon.svg";

    : `page-icon:${targetURI}`;

  let favicon = document.createElement("div");



  favicon.style.backgroundImage = `url('${imageUrl}')`;

browser/components/firefoxview/recently-closed-tabs.mjs

+3 −3
Original line number Diff line number Diff line
@@ -230,10 +230,10 @@ class RecentlyClosedTabsList extends HTMLElement { 
    title.textContent = `${tab.title}`;

    title.classList.add("closed-tab-li-title");



    const favicon = createFaviconElement(tab.image);

    li.append(favicon);



    const targetURI = this.getTabStateValue(tab, "url");

    const image = tab.image;

    const favicon = createFaviconElement(image, targetURI);

    li.append(favicon);



    const urlElement = document.createElement("span");

    urlElement.classList.add("closed-tab-li-url");

browser/components/firefoxview/tab-pickup-list.mjs

+1 −1
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ class TabPickupList extends HTMLElement { 
    title.textContent = tab.title;

    title.classList.add("synced-tab-li-title");



    const favicon = createFaviconElement(tab.icon);

    const favicon = createFaviconElement(tab.icon, targetURI);



    const lastUsedMs = tab.lastUsed * 1000;

    const time = document.createElement("span");