Commit a38b25b2 authored by Nazım Can Altınova's avatar Nazım Can Altınova
Browse files

Bug 1728544 - Make the MarkerSchema::Format enum class values CamelCased r=gerald 

Differential Revision: https://phabricator.services.mozilla.com/D124241
parent ddae0f7c

dom/events/EventDispatcher.cpp

+1 −1
Original line number Diff line number Diff line
@@ -1059,7 +1059,7 @@ nsresult EventDispatcher::Dispatch(nsISupports* aTarget, 
              schema.SetTooltipLabel("{marker.data.eventType} - DOMEvent");

              schema.SetTableLabel("{marker.data.eventType}");

              schema.AddKeyLabelFormat("latency", "Latency",

                                       MS::Format::duration);

                                       MS::Format::Duration);

              return schema;

            }

          };

dom/ipc/ContentChild.cpp

+4 −4
Original line number Diff line number Diff line
@@ -327,8 +327,8 @@ struct ProcessPriorityChange { 
  static MarkerSchema MarkerTypeDisplay() {

    using MS = MarkerSchema;

    MS schema{MS::Location::MarkerChart, MS::Location::MarkerTable};

    schema.AddKeyFormat("Before", MS::Format::string);

    schema.AddKeyFormat("After", MS::Format::string);

    schema.AddKeyFormat("Before", MS::Format::String);

    schema.AddKeyFormat("After", MS::Format::String);

    schema.AddStaticLabelValue("Note",

                               "This is a notification of the priority change "

                               "that was done by the parent process");
@@ -353,8 +353,8 @@ struct ProcessPriority { 
  static MarkerSchema MarkerTypeDisplay() {

    using MS = MarkerSchema;

    MS schema{MS::Location::MarkerChart, MS::Location::MarkerTable};

    schema.AddKeyFormat("Priority", MS::Format::string);

    schema.AddKeyFormat("Marker cause", MS::Format::string);

    schema.AddKeyFormat("Priority", MS::Format::String);

    schema.AddKeyFormat("Marker cause", MS::Format::String);

    schema.SetAllLabels("priority: {marker.data.Priority}");

    return schema;

  }

dom/ipc/ProcessPriorityManager.cpp

+6 −6
Original line number Diff line number Diff line
@@ -109,9 +109,9 @@ struct SubProcessPriorityChange { 
  static MarkerSchema MarkerTypeDisplay() {

    using MS = MarkerSchema;

    MS schema{MS::Location::MarkerChart, MS::Location::MarkerTable};

    schema.AddKeyFormat("pid", MS::Format::integer);

    schema.AddKeyFormat("Before", MS::Format::string);

    schema.AddKeyFormat("After", MS::Format::string);

    schema.AddKeyFormat("pid", MS::Format::Integer);

    schema.AddKeyFormat("Before", MS::Format::String);

    schema.AddKeyFormat("After", MS::Format::String);

    schema.SetAllLabels(

        "priority of child {marker.data.pid}:"

        " {marker.data.Before} -> {marker.data.After}");
@@ -136,9 +136,9 @@ struct SubProcessPriority { 
  static MarkerSchema MarkerTypeDisplay() {

    using MS = MarkerSchema;

    MS schema{MS::Location::MarkerChart, MS::Location::MarkerTable};

    schema.AddKeyFormat("pid", MS::Format::integer);

    schema.AddKeyFormat("Priority", MS::Format::string);

    schema.AddKeyFormat("Marker cause", MS::Format::string);

    schema.AddKeyFormat("pid", MS::Format::Integer);

    schema.AddKeyFormat("Priority", MS::Format::String);

    schema.AddKeyFormat("Marker cause", MS::Format::String);

    schema.SetAllLabels(

        "priority of child {marker.data.pid}: {marker.data.Priority}");

    return schema;

dom/media/AsyncLogger.h

+1 −2
Original line number Diff line number Diff line
@@ -217,8 +217,7 @@ class AsyncLogger { 
              MS schema{MS::Location::MarkerChart, MS::Location::MarkerTable};

              schema.SetChartLabel("{marker.data.name}");

              schema.SetTableLabel("{marker.name} - {marker.data.name}");

              schema.AddKeyLabelFormat("name", "Comment",

                                       MarkerSchema::Format::string);

              schema.AddKeyLabelFormat("name", "Comment", MS::Format::String);

              return schema;

            }

          };

dom/performance/Performance.cpp

+4 −4
Original line number Diff line number Diff line
@@ -258,10 +258,10 @@ struct UserTimingMarker { 
    MS schema{MS::Location::MarkerChart, MS::Location::MarkerTable};

    schema.SetAllLabels("{marker.data.name}");

    schema.AddStaticLabelValue("Marker", "UserTiming");

    schema.AddKeyLabelFormat("entryType", "Entry Type", MS::Format::string);

    schema.AddKeyLabelFormat("name", "Name", MS::Format::string);

    schema.AddKeyLabelFormat("startMark", "Start Mark", MS::Format::string);

    schema.AddKeyLabelFormat("endMark", "End Mark", MS::Format::string);

    schema.AddKeyLabelFormat("entryType", "Entry Type", MS::Format::String);

    schema.AddKeyLabelFormat("name", "Name", MS::Format::String);

    schema.AddKeyLabelFormat("startMark", "Start Mark", MS::Format::String);

    schema.AddKeyLabelFormat("endMark", "End Mark", MS::Format::String);

    schema.AddStaticLabelValue("Description",

                               "UserTimingMeasure is created using the DOM API "

                               "performance.measure().");