From aedcc1ebbcb0531df75e09fcdc09209c3b8d1866 Mon Sep 17 00:00:00 2001 From: Tony Herre <toprice@chromium.org> Date: Fri, 27 Jan 2023 15:33:09 +0000 Subject: [PATCH] Bug 1812306 [wpt PR 38164] - Add frameType to RTCEncodedVideoFrameMetadata, a=testonly Automatic update from web-platform-tests Add frameType to RTCEncodedVideoFrameMetadata Add a field specifying if a frame is a key or delta frame to the RTC encoded frame metadata. Without this, encodedFrame.setMetadata(encodedFrame.getMetadata()) would reset the frame type in the header to "kEmptyFrame", causing it to be dropped before being sent on a PeerConnection, making it hard to test setMetadata(). Guarded by the same feature as the rest of this additional metadata: RTCEncodedVideoFrameAdditionalMetadata. Bug: webrtc:14709 Change-Id: Id93622dc7488f04900debff450689113fe757840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4181178 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tony Herre <toprice@chromium.org> Cr-Commit-Position: refs/heads/main@{#1097421} -- wpt-commits: 672d747e92e68a55697fbeb69f8f9c14e2ebdf29 wpt-pr: 38164 --- .../tests/webrtc-encoded-transform/set-metadata.https.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testing/web-platform/tests/webrtc-encoded-transform/set-metadata.https.html b/testing/web-platform/tests/webrtc-encoded-transform/set-metadata.https.html index 3840bfc7a28d5..ad346c12e44e2 100644 --- a/testing/web-platform/tests/webrtc-encoded-transform/set-metadata.https.html +++ b/testing/web-platform/tests/webrtc-encoded-transform/set-metadata.https.html @@ -35,6 +35,8 @@ promise_test(async t => { 'spatialIndex'); assert_equals(cloneMetadata.temporalIndex, metadata.temporalIndex, 'temporalIndex'); + assert_equals(cloneMetadata.frameType, metadata.frameType, + 'frameType'); // RTCEncodedVideoFrameAdditionalMetadata-only fields. assert_array_equals(cloneMetadata.decodeTargetIndications, metadata.decodeTargetIndications, -- GitLab