Commit ba11b9cf authored by Eden Chuang's avatar Eden Chuang Committed by Pier Angelo Vendrame
Browse files

Bug 1738426 - Ignoring status 206 and vary header checking for opaque response... 

Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth

Differential Revision: https://phabricator.services.mozilla.com/D186431
parent 8d046102

dom/cache/TypeUtils.cpp

+1 −1
Original line number Diff line number Diff line
@@ -184,7 +184,7 @@ void TypeUtils::ToCacheResponseWithoutBody(CacheResponse& aOut, 
  aOut.statusText() = aIn.GetUnfilteredStatusText();

  RefPtr<InternalHeaders> headers = aIn.UnfilteredHeaders();

  MOZ_DIAGNOSTIC_ASSERT(headers);

  if (HasVaryStar(headers)) {

  if (aIn.Type() != ResponseType::Opaque && HasVaryStar(headers)) {

    aRv.ThrowTypeError("Invalid Response object with a 'Vary: *' header.");

    return;

  }

testing/web-platform/meta/service-workers/cache-storage/cache-put.https.any.js.ini

deleted100644 → 0
+0 −26
Original line number Diff line number Diff line 
[cache-put.https.any.serviceworker.html]

  expected:

    if (os == "android") and fission: [OK, TIMEOUT]

  [Cache.put with a VARY:* opaque response should not reject]

    expected: FAIL





[cache-put.https.any.sharedworker.html]

  expected:

    if (os == "android") and fission: [OK, TIMEOUT]

  [Cache.put with a VARY:* opaque response should not reject]

    expected: FAIL





[cache-put.https.any.html]

  expected:

    if (os == "android") and fission: [OK, TIMEOUT]

  [Cache.put with a VARY:* opaque response should not reject]

    expected: FAIL





[cache-put.https.any.worker.html]

  expected:

    if (os == "android") and fission: [OK, TIMEOUT]

  [Cache.put with a VARY:* opaque response should not reject]

    expected: FAIL