Commit ba95fb3f authored by Nika Layzell's avatar Nika Layzell
Browse files

Bug 1337056 - Part 2: Replace the synchronous ReadPermissions API with async APIs, r=baku 

These APIs are intended to use the mechanism defined in Part 1.

Part 3 implements the usage of these APIs to synchronize permissions.

MozReview-Commit-ID: HNKyDPtoaHl
parent ca0fec34

dom/ipc/ContentChild.cpp

+10 −0
Original line number Diff line number Diff line
@@ -3261,6 +3261,16 @@ ContentChild::AsyncOpenAnonymousTemporaryFile(AnonymousTemporaryFileCallback aCa 
  return NS_OK;

}



mozilla::ipc::IPCResult

ContentChild::RecvSetPermissionsWithKey(const nsCString& aPermissionKey,

                                        nsTArray<IPC::Permission>&& aPerms)

{

  nsCOMPtr<nsIPermissionManager> permissionManager =

    services::GetPermissionManager();

  permissionManager->SetPermissionsWithKey(aPermissionKey, aPerms);



  return IPC_OK();

}



} // namespace dom

} // namespace mozilla

dom/ipc/ContentChild.h

+4 −0
Original line number Diff line number Diff line
@@ -589,6 +589,10 @@ public: 
  virtual mozilla::ipc::IPCResult

  RecvProvideAnonymousTemporaryFile(const uint64_t& aID, const FileDescOrError& aFD) override;



  mozilla::ipc::IPCResult

  RecvSetPermissionsWithKey(const nsCString& aPermissionKey,

                            nsTArray<IPC::Permission>&& aPerms) override;



#if defined(XP_WIN) && defined(ACCESSIBILITY)

  bool

  SendGetA11yContentId();

dom/ipc/ContentParent.cpp

+0 −51
Original line number Diff line number Diff line
@@ -2463,57 +2463,6 @@ ContentParent::RecvReadFontList(InfallibleTArray<FontListEntry>* retValue) 
  return IPC_OK();

}



mozilla::ipc::IPCResult

ContentParent::RecvReadPermissions(InfallibleTArray<IPC::Permission>* aPermissions)

{

#ifdef MOZ_PERMISSIONS

  nsCOMPtr<nsIPermissionManager> permissionManagerIface =

    services::GetPermissionManager();

  nsPermissionManager* permissionManager =

    static_cast<nsPermissionManager*>(permissionManagerIface.get());

  MOZ_ASSERT(permissionManager,

             "We have no permissionManager in the Chrome process !");



  nsCOMPtr<nsISimpleEnumerator> enumerator;

  DebugOnly<nsresult> rv = permissionManager->GetEnumerator(getter_AddRefs(enumerator));

  MOZ_ASSERT(NS_SUCCEEDED(rv), "Could not get enumerator!");

  while(1) {

    bool hasMore;

    enumerator->HasMoreElements(&hasMore);

    if (!hasMore)

      break;



    nsCOMPtr<nsISupports> supp;

    enumerator->GetNext(getter_AddRefs(supp));

    nsCOMPtr<nsIPermission> perm = do_QueryInterface(supp);



    nsCOMPtr<nsIPrincipal> principal;

    perm->GetPrincipal(getter_AddRefs(principal));

    nsCString origin;

    if (principal) {

      principal->GetOrigin(origin);

    }

    nsCString type;

    perm->GetType(type);

    uint32_t capability;

    perm->GetCapability(&capability);

    uint32_t expireType;

    perm->GetExpireType(&expireType);

    int64_t expireTime;

    perm->GetExpireTime(&expireTime);



    aPermissions->AppendElement(IPC::Permission(origin, type,

                                                capability, expireType,

                                                expireTime));

  }



  // Ask for future changes

  mSendPermissionUpdates = true;

#endif



  return IPC_OK();

}



mozilla::ipc::IPCResult

ContentParent::RecvSetClipboard(const IPCDataTransfer& aDataTransfer,

                                const bool& aIsPrivateData,

dom/ipc/ContentParent.h

+0 −2
Original line number Diff line number Diff line
@@ -926,8 +926,6 @@ private: 


  virtual mozilla::ipc::IPCResult RecvReadFontList(InfallibleTArray<FontListEntry>* retValue) override;



  virtual mozilla::ipc::IPCResult RecvReadPermissions(InfallibleTArray<IPC::Permission>* aPermissions) override;



  virtual mozilla::ipc::IPCResult RecvSetClipboard(const IPCDataTransfer& aDataTransfer,

                                                   const bool& aIsPrivateData,

                                                   const IPC::Principal& aRequestingPrincipal,

dom/ipc/PContent.ipdl

+2 −3
Original line number Diff line number Diff line
@@ -593,6 +593,8 @@ child: 


    async ProvideAnonymousTemporaryFile(uint64_t aID, FileDescOrError aFD);



    async SetPermissionsWithKey(nsCString aPermissionKey, Permission[] aPermissions);



parent:

    async InitBackground(Endpoint<PBackgroundParent> aEndpoint);
@@ -785,9 +787,6 @@ parent: 
                      uint32_t lineNumber, uint32_t colNumber, uint32_t flags,

                      nsCString category);



    // nsIPermissionManager messages

    sync ReadPermissions() returns (Permission[] permissions);



    // Places the items within dataTransfer on the clipboard.

    async SetClipboard(IPCDataTransfer aDataTransfer,

                       bool aIsPrivateData,