Bug 1363560 - Name more runnables (r=mccr8) (c197e07f) · Commits · The Tor Project / Applications / Mullvad Browser

dom/base/ImageEncoder.cpp

+8 −3

Original line number	Diff line number	Diff line
		@@ -29,7 +29,10 @@ namespace dom {
		// template parameter, we need to move this class outside.
		class SurfaceHelper : public Runnable {
		public:
		explicit SurfaceHelper(already_AddRefed<layers::Image> aImage) : mImage(aImage) {}
		explicit SurfaceHelper(already_AddRefed<layers::Image> aImage)
		: Runnable("SurfaceHelper")
		, mImage(aImage)
		{}

		// It retrieves a SourceSurface reference and convert color format on main
		// thread and passes DataSourceSurface to caller thread.
		@@ -79,7 +82,8 @@ class EncodingCompleteEvent : public CancelableRunnable

		public:
		explicit EncodingCompleteEvent(EncodeCompleteCallback* aEncodeCompleteCallback)
		: mImgSize(0)
		: CancelableRunnable("EncodingCompleteEvent")
		, mImgSize(0)
		, mType()
		, mImgData(nullptr)
		, mEncodeCompleteCallback(aEncodeCompleteCallback)
		@@ -152,7 +156,8 @@ public:
		int32_t aFormat,
		const nsIntSize aSize,
		bool aUsingCustomOptions)
		: mType(aType)
		: Runnable("EncodingRunnable")
		, mType(aType)
		, mOptions(aOptions)
		, mImageBuffer(Move(aImageBuffer))
		, mImage(aImage)

dom/base/nsGlobalWindow.cpp

+16 −0

Original line number	Diff line number	Diff line
		@@ -561,6 +561,7 @@ NS_INTERFACE_MAP_END_INHERITING(TimeoutHandler)

		class IdleRequestExecutor final : public nsIRunnable
		, public nsICancelableRunnable
		, public nsINamed
		, public nsIIncrementalRunnable
		{
		public:
		@@ -580,6 +581,7 @@ public:
		NS_DECL_CYCLE_COLLECTION_CLASS_AMBIGUOUS(IdleRequestExecutor, nsIRunnable)

		NS_DECL_NSIRUNNABLE
		NS_DECL_NSINAMED
		nsresult Cancel() override;
		void SetDeadline(TimeStamp aDeadline) override;

		@@ -646,10 +648,24 @@ NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
		NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(IdleRequestExecutor)
		NS_INTERFACE_MAP_ENTRY(nsIRunnable)
		NS_INTERFACE_MAP_ENTRY(nsICancelableRunnable)
		NS_INTERFACE_MAP_ENTRY(nsINamed)
		NS_INTERFACE_MAP_ENTRY(nsIIncrementalRunnable)
		NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsISupports, nsIRunnable)
		NS_INTERFACE_MAP_END

		NS_IMETHODIMP
		IdleRequestExecutor::GetName(nsACString& aName)
		{
		aName.AssignASCII("IdleRequestExecutor");
		return NS_OK;
		}

		NS_IMETHODIMP
		IdleRequestExecutor::SetName(const char* aName)
		{
		return NS_ERROR_NOT_IMPLEMENTED;
		}

		NS_IMETHODIMP
		IdleRequestExecutor::Run()
		{

dom/base/nsObjectLoadingContent.cpp

+5 −3

Original line number	Diff line number	Diff line
		@@ -151,7 +151,7 @@ InActiveDocument(nsIContent *aContent)
		class nsAsyncInstantiateEvent : public Runnable {
		public:
		explicit nsAsyncInstantiateEvent(nsObjectLoadingContent* aContent)
		: mContent(aContent) {}
		: Runnable("nsAsyncInstantiateEvent"), mContent(aContent) {}

		~nsAsyncInstantiateEvent() override = default;

		@@ -260,7 +260,8 @@ CheckPluginStopEvent::Run()
		class nsSimplePluginEvent : public Runnable {
		public:
		nsSimplePluginEvent(nsIContent* aTarget, const nsAString &aEvent)
		: mTarget(aTarget)
		: Runnable("nsSimplePluginEvent")
		, mTarget(aTarget)
		, mDocument(aTarget->GetComposedDoc())
		, mEvent(aEvent)
		{
		@@ -325,7 +326,8 @@ public:
		const nsAString& aPluginName,
		const nsAString& aPluginFilename,
		bool submittedCrashReport)
		: mContent(aContent),
		: Runnable("nsPluginCrashedEvent"),
		mContent(aContent),
		mPluginDumpID(aPluginDumpID),
		mBrowserDumpID(aBrowserDumpID),
		mPluginName(aPluginName),

dom/crypto/WebCryptoTask.cpp

+2 −1

Original line number	Diff line number	Diff line
		@@ -3726,7 +3726,8 @@ WebCryptoTask::CreateUnwrapKeyTask(nsIGlobalObject* aGlobal,
		}

		WebCryptoTask::WebCryptoTask()
		: mEarlyRv(NS_OK)
		: CancelableRunnable("WebCryptoTask")
		, mEarlyRv(NS_OK)
		, mEarlyComplete(false)
		, mOriginalThread(nullptr)
		, mReleasedNSSResources(false)

dom/html/HTMLMediaElement.cpp

+12 −5

Original line number	Diff line number	Diff line
		@@ -1210,6 +1210,7 @@ public:
		// Per bug 1235183 comment 8, we can't spin the event loop from stable
		// state. Defer NS_NewChannel() to a new regular runnable.
		return NS_DispatchToMainThread(NewRunnableMethod<HTMLMediaElement*>(
		"ChannelLoader::LoadInternal",
		this, &ChannelLoader::LoadInternal, aElement));
		}

		@@ -1819,7 +1820,8 @@ void HTMLMediaElement::QueueLoadFromSourceTask()

		ChangeDelayLoadStatus(true);
		ChangeNetworkState(nsIDOMHTMLMediaElement::NETWORK_LOADING);
		RefPtr<Runnable> r = NewRunnableMethod(this, &HTMLMediaElement::LoadFromSourceChildren);
		RefPtr<Runnable> r = NewRunnableMethod("HTMLMediaElement::LoadFromSourceChildren",
		this, &HTMLMediaElement::LoadFromSourceChildren);
		RunInStableState(r);
		}

		@@ -1830,7 +1832,8 @@ void HTMLMediaElement::QueueSelectResourceTask()
		return;
		mHaveQueuedSelectResource = true;
		ChangeNetworkState(nsIDOMHTMLMediaElement::NETWORK_NO_SOURCE);
		RefPtr<Runnable> r = NewRunnableMethod(this, &HTMLMediaElement::SelectResourceWrapper);
		RefPtr<Runnable> r = NewRunnableMethod("HTMLMediaElement::SelectResourceWrapper",
		this, &HTMLMediaElement::SelectResourceWrapper);
		RunInStableState(r);
		}

		@@ -1966,7 +1969,8 @@ void HTMLMediaElement::SelectResource()
		// set the networkState to NETWORK_EMPTY, and abort these steps; the
		// synchronous section ends.
		nsCOMPtr<nsIRunnable> event =
		NewRunnableMethod<nsCString>(this, &HTMLMediaElement::NoSupportedMediaSourceError, nsCString());
		NewRunnableMethod<nsCString>("HTMLMediaElement::NoSupportedMediaSourceError",
		this, &HTMLMediaElement::NoSupportedMediaSourceError, nsCString());
		NS_DispatchToMainThread(event);
		} else {
		// Otherwise, the source elements will be used.
		@@ -2125,7 +2129,8 @@ void HTMLMediaElement::NotifyMediaTrackDisabled(MediaTrack* aTrack)
		MOZ_ASSERT(outputTrack);
		if (outputTrack) {
		NS_DispatchToMainThread(
		NewRunnableMethod(outputTrack, &MediaStreamTrack::OverrideEnded));
		NewRunnableMethod("MediaStreamTrack::OverrideEnded",
		outputTrack, &MediaStreamTrack::OverrideEnded));
		}

		ms.mTrackPorts[i].second()->Destroy();
		@@ -2171,7 +2176,8 @@ void HTMLMediaElement::DealWithFailedElement(nsIContent* aSourceElement)

		DispatchAsyncSourceError(aSourceElement);
		nsCOMPtr<nsIRunnable> event =
		NewRunnableMethod(this, &HTMLMediaElement::QueueLoadFromSourceTask);
		NewRunnableMethod("HTMLMediaElement::QueueLoadFromSourceTask",
		this, &HTMLMediaElement::QueueLoadFromSourceTask);
		NS_DispatchToMainThread(event);
		}

		@@ -3289,6 +3295,7 @@ HTMLMediaElement::AddCaptureMediaTrackToOutputStream(MediaTrack* aTrack,
		if (aAsyncAddtrack) {
		NS_DispatchToMainThread(
		NewRunnableMethod<StoreRefPtrPassByPtr<MediaStreamTrack>>(
		"DOMMediaStream::AddTrackInternal",
		aOutputStream.mStream, &DOMMediaStream::AddTrackInternal, track));
		} else {
		aOutputStream.mStream->AddTrackInternal(track);