Commit c63d2547 authored by Shane Hughes's avatar Shane Hughes
Browse files

Bug 1804098 - Avoid subpixel rounding inconsistencies in about welcome progress bar. r=negin 

Differential Revision: https://phabricator.services.mozilla.com/D163866
parent 532a3abe

browser/components/newtab/aboutwelcome/content/aboutwelcome.css

+3 −4
Original line number Diff line number Diff line
@@ -653,7 +653,7 @@ html { 
.onboardingContainer .screen[pos=split] .section-main .main-content .steps.progress-bar .indicator {

  width: -moz-available;

  height: 100%;

  margin-inline: 0;

  margin-inline: -1px;

  scale: 1;

  background: transparent;

  border: 0;
@@ -678,11 +678,10 @@ html { 
    border-top: 1px solid var(--in-content-page-color);

  }

  .onboardingContainer .screen[pos=split] .section-main .main-content .steps.progress-bar .indicator {

    opacity: 1;

    border-color: var(--in-content-page-background);

    background-color: var(--in-content-page-background);

  }

  .onboardingContainer .screen[pos=split] .section-main .main-content .steps.progress-bar .indicator.current, .onboardingContainer .screen[pos=split] .section-main .main-content .steps.progress-bar .indicator.complete {

    border-color: var(--in-content-accent-color);

    background-color: var(--in-content-accent-color);

  }

}

.onboardingContainer .screen[pos=split] .section-secondary {

browser/components/newtab/content-src/aboutwelcome/aboutwelcome.scss

+3 −4
Original line number Diff line number Diff line
@@ -516,7 +516,7 @@ html { 
              .indicator {

                width: -moz-available;

                height: 100%;

                margin-inline: 0;

                margin-inline: -1px;

                scale: 1;

                background: transparent;

                border: 0;
@@ -547,12 +547,11 @@ html { 
              border-top: 1px solid var(--in-content-page-color);



              .indicator {

                opacity: 1;

                border-color: var(--in-content-page-background);

                background-color: var(--in-content-page-background);



                &.current,

                &.complete {

                  border-color: var(--in-content-accent-color);

                  background-color: var(--in-content-accent-color);

                }

              }

            }

browser/components/newtab/test/browser/browser_aboutwelcome_configurable_ui.js

+2 −1
Original line number Diff line number Diff line
@@ -584,7 +584,8 @@ add_task(async function test_MR_aboutwelcome_with_progress_bar() { 
      // Base progress bar step styles.

      height: "6px",

      "padding-block": "0px",

      margin: "0px",

      "margin-inline": "-1px",

      "margin-block": "0px",

    });

  }