Commit d839993a authored by Alex Franchuk's avatar Alex Franchuk
Browse files

Bug 1911779 - Default to including the URL in crash reports a=dmeehan 

This default is used when the crash reporter has never been launched
before. Notably, this is currently a user-global setting (as opposed to
per-profile), so the defaults will typically only be used when someone
hasn't ever had Firefox installed on their system.

Original Revision: https://phabricator.services.mozilla.com/D218887

Differential Revision: https://phabricator.services.mozilla.com/D219152
parent 0681cf34

toolkit/crashreporter/client/app/src/settings.rs

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ impl Default for Settings { 
    fn default() -> Self {

        Settings {

            submit_report: true,

            include_url: false,

            include_url: true,

        }

    }

}

toolkit/crashreporter/client/app/src/test.rs

+3 −2
Original line number Diff line number Diff line
@@ -590,7 +590,7 @@ fn no_submit() { 
        "data_dir/crashreporter_settings.json",

        Settings {

            submit_report: true,

            include_url: true,

            include_url: false,

        }

        .to_string(),

    );
@@ -599,7 +599,7 @@ fn no_submit() { 
            assert!(c.checked.get())

        });

        interact.element("include-url", |_style, c: &model::Checkbox| {

            assert!(c.checked.get())

            assert!(!c.checked.get())

        });

        interact.element("send", |_style, c: &model::Checkbox| c.checked.set(false));

        interact.element("include-url", |_style, c: &model::Checkbox| {
@@ -765,6 +765,7 @@ fn details_window() { 
             TelemetryServerURL: https://telemetry.example.com\n\

             TelemetrySessionId: telemetry_session\n\

             Throttleable: 1\n\

             URL: https://url.example.com\n\

             Vendor: FooCorp\n\

             Version: 100.0\n\

             This report also contains technical information about the state of the application when it crashed.\n"