From e6fdbe4cafe78f342c010651ffec5782637b5e3f Mon Sep 17 00:00:00 2001
From: Andreas Tolfsen <ato@sny.no>
Date: Tue, 1 Aug 2017 18:21:04 +0100
Subject: [PATCH] Bug 1381876 - Compare window rect, not window size.
r=automatedtester
The dictionary from Marionette#window_size is a subset of what is returned
from Marionette#window_rect, causing the self.assertEqual to complain
that they are not equal. We want to compare the same types.
MozReview-Commit-ID: L4XTlgtUYKW
--HG--
extra : rebase_source : c3adf89777ac589cab2fb84fe3e543f22d9895fc
---
.../tests/unit/test_window_maximize.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py b/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
index 02c955e611cf1..28a0dbb890b6f 100644
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
@@ -60,11 +60,11 @@ class TestWindowMaximize(MarionetteTestCase):
self.assertIsInstance(rect["y"], int)
def test_maximize(self):
- rect = self.marionette.maximize_window()
- self.assert_window_rect(rect)
- size = self.marionette.window_size
- self.assertEqual(size, rect)
- self.assert_window_maximized(size)
+ maximize_resp = self.marionette.maximize_window()
+ self.assert_window_rect(maximize_resp)
+ window_rect_resp = self.marionette.window_rect
+ self.assertEqual(maximize_resp, window_rect_resp)
+ self.assert_window_maximized(maximize_resp)
def test_maximize_twice_restores(self):
maximized = self.marionette.maximize_window()
--
GitLab