RBM issueshttps://gitlab.torproject.org/tpo/applications/rbm/-/issues2023-06-01T17:23:58Zhttps://gitlab.torproject.org/tpo/applications/rbm/-/issues/26185rbm should do deep merge of options hashes2023-06-01T17:23:58Zboklmrbm should do deep merge of options hashesIn templates, when using the `c()` or `pc()` functions, it is possible to give as 2nd or 3rd argument an hash table containing variables to be overridden. To do that, we merge this hash table into the main options hash table. However we ...In templates, when using the `c()` or `pc()` functions, it is possible to give as 2nd or 3rd argument an hash table containing variables to be overridden. To do that, we merge this hash table into the main options hash table. However we only merge one level, which means that if the new options hash table contains variables in a second level with something like `var => { option_1 => 'value1' }`, then `var` is replaced instead of merged, and all `var/*` options other than `option_1` are removed.https://gitlab.torproject.org/tpo/applications/rbm/-/issues/25719Add option to store last time a file was used in a build2022-11-29T09:04:23ZboklmAdd option to store last time a file was used in a buildIn `tor-browser-build`, we can clean old build files by running `make clean`, which will keep only the files used in the current build.
There are however some problems with that:
- running `make clean` is slow as it needs to compute all...In `tor-browser-build`, we can clean old build files by running `make clean`, which will keep only the files used in the current build.
There are however some problems with that:
- running `make clean` is slow as it needs to compute all the file names used in a build, for all the branches/series we are using.
- when working on different bugs at the same time, running `make clean` will clean build files created by branches that have not been merged yet.
Instead, it would be nice to be able to clean files that have not been used in the last X days. To allow that, rbm should have an option to store somewhere a timestamp of when each input files have been used in a build for the last time.https://gitlab.torproject.org/tpo/applications/rbm/-/issues/25421Add an option to clean repository if checkout fails2023-06-01T17:23:55ZboklmAdd an option to clean repository if checkout failsOur nightly build sometimes fail with an error such as:
```
Error: Cannot checkout tor-browser-52.6.0esr-8.0-2-build2
```
The reason is that the working tree from the git repository is not clean, which prevents checking out an other com...Our nightly build sometimes fail with an error such as:
```
Error: Cannot checkout tor-browser-52.6.0esr-8.0-2-build2
```
The reason is that the working tree from the git repository is not clean, which prevents checking out an other commit.
We should add an option to rbm to do a `git reset --hard` and `git clean` if the checkout fails.