Unverified Commit 8b94652d authored by Georg Koppen's avatar Georg Koppen
Browse files

Bug 40090: NSIS 3.06.1 still needs timestamp patch

parent 6addbb46

projects/nsis/build

+5 −0
Original line number Original line Diff line number Diff line
@@ -8,6 +8,11 @@ tar -C /var/tmp/build -xf nsis-[% c('version') %].tar.bz2 
tar -C /var/tmp/build -xf [% c('input_files_by_name/zlib') %]

tar -C /var/tmp/build -xf [% c('input_files_by_name/zlib') %]





cd /var/tmp/build/nsis-[% c('version') %]-src

cd /var/tmp/build/nsis-[% c('version') %]-src

# Adding --no-insert-timestamp to APPEND_LINKFLAGS is not working as it

# is used for both the host and cross-compiled parts, but this option is

# only valid for the Windows linker. Therefore we add it using a patch

# to the cross-compilation part only. Still needed as of 3.06.1, see: #40090.

patch -p1 < $rootdir/no-insert-timestamp.patch





[% IF c("var/windows-x86_64") %]

[% IF c("var/windows-x86_64") %]

  # Seems like setting TARGET_ARCH is not enough so we need to patch build.cpp

  # Seems like setting TARGET_ARCH is not enough so we need to patch build.cpp

projects/nsis/config

+1 −0
Original line number Original line Diff line number Diff line
@@ -17,6 +17,7 @@ input_files: 
  - filename: 'nsis-[% c("version") %].tar.bz2'

  - filename: 'nsis-[% c("version") %].tar.bz2'

    URL: 'https://downloads.sourceforge.net/nsis/nsis-[% c("version") %]-src.tar.bz2'

    URL: 'https://downloads.sourceforge.net/nsis/nsis-[% c("version") %]-src.tar.bz2'

    sha256sum: 9b5d68bf1874a7b393432410c7e8c376f174d2602179883845d2508152153ff0

    sha256sum: 9b5d68bf1874a7b393432410c7e8c376f174d2602179883845d2508152153ff0

  - filename: no-insert-timestamp.patch

  - name: '[% c("var/compiler") %]'

  - name: '[% c("var/compiler") %]'

    project: '[% c("var/compiler") %]'

    project: '[% c("var/compiler") %]'

  - name: zlib

  - name: zlib

projects/nsis/no-insert-timestamp.patch

0 → 100644
+27 −0
Original line number Original line Diff line number Diff line 
diff -ur nsis-3.03-src/SCons/Config/gnu nsis-3.03-src.n/SCons/Config/gnu

--- nsis-3.03-src/SCons/Config/gnu	2017-10-06 15:30:20.000000000 -0400

+++ nsis-3.03-src.n/SCons/Config/gnu	2018-06-17 13:26:05.945495151 -0400

@@ -102,6 +102,7 @@

 stub_env.Append(LINKFLAGS = ['$NODEFLIBS_FLAG'])    # no standard libraries

 stub_env.Append(LINKFLAGS = ['$ALIGN_FLAG'])        # 512 bytes align

 stub_env.Append(LINKFLAGS = ['$MAP_FLAG'])          # generate map file

+stub_env.Append(LINKFLAGS = ['-Wl,--no-insert-timestamp']) # remove timestamps for reproducible builds

 

 stub_uenv = stub_env.Clone()

 stub_uenv.Append(CPPDEFINES = ['_UNICODE', 'UNICODE'])

@@ -142,6 +143,7 @@

 plugin_env.Append(LINKFLAGS = ['$MAP_FLAG'])        # generate map file

 plugin_env.Append(LINKFLAGS = ['-static-libgcc'])   # remove libgcc*.dll dependency

 plugin_env.Append(LINKFLAGS = ['-static-libstdc++']) # remove libstdc++*.dll dependency

+plugin_env.Append(LINKFLAGS = ['-Wl,--no-insert-timestamp']) # remove timestamps for reproducible builds

 

 plugin_uenv = plugin_env.Clone()

 plugin_uenv.Append(CPPDEFINES = ['_UNICODE', 'UNICODE'])

@@ -181,6 +183,7 @@

 

 util_env.Append(LINKFLAGS = ['-mwindows'])          # build windows executables

 util_env.Append(LINKFLAGS = ['$ALIGN_FLAG'])        # 512 bytes align

+util_env.Append(LINKFLAGS = ['-Wl,--no-insert-timestamp']) # remove timestamps for reproducible builds

 

 

 conf = FlagsConfigure(util_env)