tor-browser-build issueshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues2022-10-07T10:17:01Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40634Update the project/browser path in tools/changelog-format-blog-post and other...2022-10-07T10:17:01ZPier Angelo VendrameUpdate the project/browser path in tools/changelog-format-blog-post and other filesIt's still leading to tor-browser on current main, and a 404 in turn in the 12.0a3 blog post.It's still leading to tor-browser on current main, and a 404 in turn in the 12.0a3 blog post.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40615Consider adding a readme to the fonts directory2023-10-03T15:38:05ZPier Angelo VendrameConsider adding a readme to the fonts directoryWe could add a readme.txt to the font directory, in which we explain users that they aren't supposed to add fonts on their own, sum up the risk, and link some FAQ page.We could add a readme.txt to the font directory, in which we explain users that they aren't supposed to add fonts on their own, sum up the risk, and link some FAQ page.Sponsor 131 - Phase 2 - Privacy Browserhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40638Visit our website link after build-to-build upgrade in Nightly channel points...2022-10-27T22:48:08ZrichardVisit our website link after build-to-build upgrade in Nightly channel points to old v2 onionAfter upgrade nightly builds have the following copy on about:tor:
----
### Tor Browser has been updated.
For the most up-to-date information about this release, [visit our website](http://f4amtbsowhix7rrf.onion/).
----
We need to u...After upgrade nightly builds have the following copy on about:tor:
----
### Tor Browser has been updated.
For the most up-to-date information about this release, [visit our website](http://f4amtbsowhix7rrf.onion/).
----
We need to upgrade this to the new v3 onionSponsor 131 - Phase 3 - Major ESR 102 MigrationPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40585Prune the manual more2022-10-12T18:31:41ZPier Angelo VendramePrune the manual moreWe have had an increase in TBB size, and it's partly due to the manual.
We should remove webfonts because they are not even rendered (7.9MB uncompressed), there are not minimized JS and CSS, and we should see if we can remove some image...We have had an increase in TBB size, and it's partly due to the manual.
We should remove webfonts because they are not even rendered (7.9MB uncompressed), there are not minimized JS and CSS, and we should see if we can remove some images.
We can remove what we don't need with the script that packs the manual (it just copies the static files).Sponsor 131 - Phase 3 - Major ESR 102 MigrationPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40471Integrate libwinsane into build and link into tor daemon2023-11-01T19:19:42ZrichardIntegrate libwinsane into build and link into tor daemonlibwinsane: https://github.com/skeeto/scratch/tree/master/libwinsane
Would fix utf8 path handling on Windows in tor. We can probably get this working by pointing LDFLAGS/LDLIBS to the output .o file, but long term we should also patch ...libwinsane: https://github.com/skeeto/scratch/tree/master/libwinsane
Would fix utf8 path handling on Windows in tor. We can probably get this working by pointing LDFLAGS/LDLIBS to the output .o file, but long term we should also patch tor with new config option (--enable-libwinsane or similar) which handles this 'correctly' on windows.https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40429hash_incrementals script hangs on sha256sum when no .incremental.mar files ar...2022-02-14T15:01:10Zrichardhash_incrementals script hangs on sha256sum when no .incremental.mar files are presentRan into this today when attempting to build tbb-11.5a4-build1
I had incorrectly set `torbrowser_incremental_from` to 11.5a3 which was an Android-only release. As 11.5a4 is Desktop-only, there were no .incremental-mar files to be used.
...Ran into this today when attempting to build tbb-11.5a4-build1
I had incorrectly set `torbrowser_incremental_from` to 11.5a3 which was an Android-only release. As 11.5a4 is Desktop-only, there were no .incremental-mar files to be used.
We should verify that the set of filenames output by `ls -1 | grep '\.incremental\.mar$' | sort` is not empty, otherwise sha256sum will hang indefinitely waiting for data to be read in from stdin.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40186noto-fonts Git repo is excessively large2022-12-08T15:15:28ZJeremyRandnoto-fonts Git repo is excessively largeThe `noto-fonts` Git repo (cloned as part of the `fonts` project) uses over 6 GiB of storage, even though downloading a `.zip` archive from GitHub of the tree at that commit hash results in an archive that uses less than 40 MiB when deco...The `noto-fonts` Git repo (cloned as part of the `fonts` project) uses over 6 GiB of storage, even though downloading a `.zip` archive from GitHub of the tree at that commit hash results in an archive that uses less than 40 MiB when decompressed. Is there any reason that it's downloaded via Git rather than a standard HTTPS archive download? The excessively large size is a significant barrier to some users with limited storage capacity and/or network bandwidth.https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40112libstdc++.so.6 not stripped2021-01-20T18:56:24Zyanmaanilibstdc++.so.6 not strippedIn `tor-browser-build/projects/tor/build`, `libstdc++.so.6` is copied from GCC to the output:
```
# We need to copy the libstdc++.so.6 for Tor Browser on older Linux distros.
# Copying it into /Browser, which feels more natural, and ...In `tor-browser-build/projects/tor/build`, `libstdc++.so.6` is copied from GCC to the output:
```
# We need to copy the libstdc++.so.6 for Tor Browser on older Linux distros.
# Copying it into /Browser, which feels more natural, and amending
# LD_LIBRARY_PATH breaks updates from a Tor Browser with the old
# LD_LIBRARY_PATH value to the Tor Browser with the newer one. Thus, we copy
# the libstdc++ into the directory with the libs tor depends on, too. See bug
# 13359 for further details.
mkdir -p "$distdir/Tor/libstdc++"
cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libstdc++.so.6 "$distdir/Tor/libstdc++/"
[% IF c("var/asan") -%]
cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libasan.so.5 "$distdir/Tor/"
cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libubsan.so.1 "$distdir/Tor/"
[% END -%]
chmod 700 "$distdir"/Tor/*.so*
chmod 700 "$distdir"/Tor/libstdc++/*.so*
```
This file is unstripped and contains debug info. Stripping it takes it from 17 MB to 2 MB, without any impact on functionality as far as I can tell. After compression, the entire tarball is 3MB smaller.
This should be a one-line change, provided `strip` is deterministic. I haven't looked into it.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/31321Add cc -> gcc link to projects/gcc2022-08-05T15:06:01ZboklmAdd cc -> gcc link to projects/gccThere are a few places where we add a `cc -> gcc` symbolic link:
```
projects/clang/build: ln -s gcc /var/tmp/dist/gcc/bin/cc
projects/firefox/build: ln -s gcc /var/tmp/dist/gcc/bin/cc
projects/llvm/build: ln -s gcc /var/tmp/dist/gcc/...There are a few places where we add a `cc -> gcc` symbolic link:
```
projects/clang/build: ln -s gcc /var/tmp/dist/gcc/bin/cc
projects/firefox/build: ln -s gcc /var/tmp/dist/gcc/bin/cc
projects/llvm/build: ln -s gcc /var/tmp/dist/gcc/bin/cc
projects/nasm/build: ln -s gcc /var/tmp/dist/gcc/bin/cc
projects/node/build: ln -s gcc /var/tmp/dist/gcc/bin/cc
```
Instead of creating this link in each project where it is needed, maybe we could create it only one time, during the build of gcc in `projects/gcc/build`.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/26650Update d3dcompiler_47.dll to latest version in Tor Browser (10.0.15063.675)2022-11-16T09:36:20ZGeorg KoppenUpdate d3dcompiler_47.dll to latest version in Tor Browser (10.0.15063.675)A user on the blog (https://blog.torproject.org/comment/275958#comment-275958) mentioned there is a newer version of the d3dcompiler_47 library we ship with Tor Browser and strongly suggested to update the one we provide.A user on the blog (https://blog.torproject.org/comment/275958#comment-275958) mentioned there is a newer version of the d3dcompiler_47 library we ship with Tor Browser and strongly suggested to update the one we provide.Sponsor 131 - Phase 5 - Ongoing MaintenancePier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40599Windows 32bit installer is missing many languages from the NSIS file2022-10-04T19:01:53ZDavid Fifielddcf@torproject.orgWindows 32bit installer is missing many languages from the NSIS fileThe installer file lists 56 languages,
* https://github.com/MarkCSmith/tbb-windows-installer/blob/00133b8741eb8ca34fc8153d344c7c54a5e3fae9/torbrowser.nsi#L51
but the installer only shows 26.
It looks like these are the 30 languages tha...The installer file lists 56 languages,
* https://github.com/MarkCSmith/tbb-windows-installer/blob/00133b8741eb8ca34fc8153d344c7c54a5e3fae9/torbrowser.nsi#L51
but the installer only shows 26.
It looks like these are the 30 languages that are missing, notably including TBB official languages Arabic, Farsi, Korean, Polish, Russian, Turkish, and Chinese.
```
!insertmacro MUI_LANGUAGE "SimpChinese"
!insertmacro MUI_LANGUAGE "TradChinese"
!insertmacro MUI_LANGUAGE "Japanese"
!insertmacro MUI_LANGUAGE "Korean"
!insertmacro MUI_LANGUAGE "Greek"
!insertmacro MUI_LANGUAGE "Russian"
!insertmacro MUI_LANGUAGE "Polish"
!insertmacro MUI_LANGUAGE "Ukrainian"
!insertmacro MUI_LANGUAGE "Czech"
!insertmacro MUI_LANGUAGE "Slovak"
!insertmacro MUI_LANGUAGE "Croatian"
!insertmacro MUI_LANGUAGE "Bulgarian"
!insertmacro MUI_LANGUAGE "Hungarian"
!insertmacro MUI_LANGUAGE "Thai"
!insertmacro MUI_LANGUAGE "Romanian"
!insertmacro MUI_LANGUAGE "Latvian"
!insertmacro MUI_LANGUAGE "Macedonian"
!insertmacro MUI_LANGUAGE "Estonian"
!insertmacro MUI_LANGUAGE "Turkish"
!insertmacro MUI_LANGUAGE "Lithuanian"
!insertmacro MUI_LANGUAGE "Slovenian"
!insertmacro MUI_LANGUAGE "Serbian"
!insertmacro MUI_LANGUAGE "SerbianLatin"
!insertmacro MUI_LANGUAGE "Arabic"
!insertmacro MUI_LANGUAGE "Farsi"
!insertmacro MUI_LANGUAGE "Hebrew"
!insertmacro MUI_LANGUAGE "Mongolian"
!insertmacro MUI_LANGUAGE "Albanian"
!insertmacro MUI_LANGUAGE "Belarusian"
!insertmacro MUI_LANGUAGE "Bosnian"
```Sponsor 131 - Phase 3 - Major ESR 102 Migration