tor-browser-build issueshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues2021-07-02T15:05:36Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40322Prep 10.52021-07-02T15:05:36ZMatthew FinkelPrep 10.5Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40302Update version of snowflake2022-03-29T23:46:53ZCecylia BocovichUpdate version of snowflakeWe've have some minor bug fixes in the snowflake client.We've have some minor bug fixes in the snowflake client.Tor Browser: 10.5Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40284Prep 10.5a152022-03-29T23:46:55ZMatthew FinkelPrep 10.5a15Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40238Prep 10.5a112021-02-21T04:29:44ZMatthew FinkelPrep 10.5a11Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40225Prep 10.5a9 Android2021-02-04T21:12:46ZMatthew FinkelPrep 10.5a9 AndroidTor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40216List update_responses dependencies in main README file2021-01-26T17:06:58ZboklmList update_responses dependencies in main README fileWe have a few dependencies for `tools/update-responses/update_responses` which are listed in `tools/update-responses/README.md` but are not in the main `README` file (at the root).
As the `update_responses` script is used to generate in...We have a few dependencies for `tools/update-responses/update_responses` which are listed in `tools/update-responses/README.md` but are not in the main `README` file (at the root).
As the `update_responses` script is used to generate incremental mars, which is part of the normal build process, I think we should include its dependencies in the main README file.Tor Browser: 10.5boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/4021510.5a8-build1 does not match2021-02-01T20:45:49ZMatthew Finkel10.5a8-build1 does not matchIncrementals match, but the difference in the package build is:
```diff
--- acat/sha256sums-unsigned-build.txt 2021-01-25 14:46:58.870796904 +0000
+++ sysrqb/sha256sums-unsigned-build.txt 2021-01-24 14:45:01.070615685 +0000
@@ ...Incrementals match, but the difference in the package build is:
```diff
--- acat/sha256sums-unsigned-build.txt 2021-01-25 14:46:58.870796904 +0000
+++ sysrqb/sha256sums-unsigned-build.txt 2021-01-24 14:45:01.070615685 +0000
@@ -42,13 +42,13 @@
2ba21cdeed4d19cab01442371c88875e7460c353cd096822f8e5ab1ace6c709d mar-tools-win64.zip
4b78241a2ed544b9604ef2f81bbdcbd244da5eacfcf63adf06043285a820f062 src-firefox-tor-browser-78.7.0esr-10.5-1-build1.tar.xz
24da2f50b886c6cebca82d40e5ce3329a6471861a5a63f6884a4fc9d014a98d5 src-tor-launcher-0.2.26.tar.xz
-5faae9718e846676cff592daee17040671eb5ce858b308a0cc88915ba850f9a4 tor-browser-10.5a8-android-aarch64-androidTest.apk
+578ad930944a3f6fdb83bb17d74f9450cd7186ac6dea436a989e4a00f3393b23 tor-browser-10.5a8-android-aarch64-androidTest.apk
4d431bd5cdc119eaa5795229c60ae6f80d0a8cbf42eedeb414a70d3c2b35084e tor-browser-10.5a8-android-aarch64-multi-qa.apk
-a10bd12fd22b24d481e8662453cf8872206d949db395e7d473b599d3198d8dd6 tor-browser-10.5a8-android-armv7-androidTest.apk
+2f8d11cfde39ca3409e5c176fc9744a32f315a3f6b72d406e406ada5cd37c8ae tor-browser-10.5a8-android-armv7-androidTest.apk
e017e2ebbda38100c9d84b3d4231ba6c6a997cf0a0eb9688a8dc140db4464cda tor-browser-10.5a8-android-armv7-multi-qa.apk
-a10bd12fd22b24d481e8662453cf8872206d949db395e7d473b599d3198d8dd6 tor-browser-10.5a8-android-x86-androidTest.apk
+2f8d11cfde39ca3409e5c176fc9744a32f315a3f6b72d406e406ada5cd37c8ae tor-browser-10.5a8-android-x86-androidTest.apk
703f0a58e5a7b5773775b67eb9a9d599f7008704463e2561d0910eecf422d5e3 tor-browser-10.5a8-android-x86-multi-qa.apk
-5faae9718e846676cff592daee17040671eb5ce858b308a0cc88915ba850f9a4 tor-browser-10.5a8-android-x86_64-androidTest.apk
+578ad930944a3f6fdb83bb17d74f9450cd7186ac6dea436a989e4a00f3393b23 tor-browser-10.5a8-android-x86_64-androidTest.apk
1b591c94b6221b2eca21d164b0f4bf80d94ef837a9e6972e1f8de7f74c2dbd38 tor-browser-10.5a8-android-x86_64-multi-qa.apk
8b581fed5016e19e955fc5555eb6a7a55df5267d3ecf987db75308e64909000d tor-browser-linux32-10.5a8_ar.mar
bad9e63cdd23a0e8b9a579d9b4ad2c76fd9026d0ff382bbd3c70799345a5fddf tor-browser-linux32-10.5a8_ar.tar.xz
```
These are only instrumented apks used for testing, so I'm not concerned about the underlying reproducibility issue, however now we do not have matching sha256sum-unsigned files.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40214Update Addons url in fetch_allowed_addons.py2021-02-02T08:24:35ZMatthew FinkelUpdate Addons url in fetch_allowed_addons.pyIn android-components@267cb52adedbc63c50e9323eb1bffdf1e10ec780 (https://github.com/mozilla-mobile/android-components/issues/9186) Mozilla moved from https://addons.mozilla.org to https://services.addons.mozilla.org
The stated reasoning ...In android-components@267cb52adedbc63c50e9323eb1bffdf1e10ec780 (https://github.com/mozilla-mobile/android-components/issues/9186) Mozilla moved from https://addons.mozilla.org to https://services.addons.mozilla.org
The stated reasoning of the move is caching on service.amo, so this isn't critical, but we should should follow Mozilla's lead.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40213Prep 10.5a82022-03-17T20:10:36ZMatthew FinkelPrep 10.5a8- [x] android-components#40037
- [x] fenix#40139
- [x] tor-browser#40305
- [x] tor-browser#40307- [x] android-components#40037
- [x] fenix#40139
- [x] tor-browser#40305
- [x] tor-browser#40307Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40212Bump versions of snowflake and webrtc2021-02-04T14:53:33ZCecylia BocovichBump versions of snowflake and webrtcWe have a few performance improvements since the last update. pion-webrtc had a major version update so figuring out the dependencies might take a bit of workWe have a few performance improvements since the last update. pion-webrtc had a major version update so figuring out the dependencies might take a bit of workTor Browser: 10.5Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40209Update nightly build gpg key and sign-nightly configuration2021-02-27T07:37:52ZboklmUpdate nightly build gpg key and sign-nightly configurationWe should create a new gpg key on `tb-build-01` to sign the nightly builds.
When we are ready to switch to the new nightly build machine, we should add the new key to `tor-browser-build/keyring/torbrowser-nightly.gpg` and update `builds...We should create a new gpg key on `tb-build-01` to sign the nightly builds.
When we are ready to switch to the new nightly build machine, we should add the new key to `tor-browser-build/keyring/torbrowser-nightly.gpg` and update `builds_url` in `tor-browser-build/tools/signing/nightly/config.yml` to fetch builds from the new URL.Tor Browser: 10.5boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/4020710.5a7-build2 Linux64 mismatch2021-02-04T08:32:48ZMatthew Finkel10.5a7-build2 Linux64 mismatchComparing acat's and my `tor-browser-linux64-10.5a7_en-US.tar.xz` we have:
```
-87f0a8b965f25c8491624eb22e22e4a58a5b5d7b2105e4e7312643ef77cc444b linux64/tor-browser_en-US/Browser/TorBrowser/Tor/PluggableTransports/obfs4proxy ...Comparing acat's and my `tor-browser-linux64-10.5a7_en-US.tar.xz` we have:
```
-87f0a8b965f25c8491624eb22e22e4a58a5b5d7b2105e4e7312643ef77cc444b linux64/tor-browser_en-US/Browser/TorBrowser/Tor/PluggableTransports/obfs4proxy
-264f38f77ad07f391b68253c05f3a7fcab20ec5e06ebd79b3442fba8cd1d699a linux64/tor-browser_en-US/Browser/TorBrowser/Tor/PluggableTransports/snowflake-client
+a7b7c0e3d5f0979fa7b117e792196b638413b1c3fbf87f447d902a0455648341 linux64/tor-browser_en-US/Browser/TorBrowser/Tor/PluggableTransports/obfs4proxy
+43a8f7d39f5e44633d8128a020dab2cd50db5a2b195395b389c95931c46eb29e linux64/tor-browser_en-US/Browser/TorBrowser/Tor/PluggableTransports/snowflake-client
```
Looking at those, they differ by:
```
--- acat.obfs4proxy.xxd 2021-01-18 16:43:47.685480270 +0000
+++ sysrqb.obfs4proxy.xxd 2021-01-18 16:43:56.085494140 +0000
@@ -247,9 +247,9 @@
00000f60: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000f70: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000f80: 0400 0000 5300 0000 0400 0000 476f 0000 ....S.......Go..
-00000f90: 4659 6e35 7843 3676 7745 3469 4133 6c7a FYn5xC6vwE4iA3lz
-00000fa0: 564a 7239 2f78 6c56 4b4b 7a38 7546 5646 VJr9/xlVKKz8uFVF
-00000fb0: 3847 6159 6639 4562 522f 496e 4543 676d 8GaYf9EbR/InECgm
+00000f90: 7a76 6466 5153 6438 5032 5044 4263 4d49 zvdfQSd8P2PDBcMI
+00000fa0: 6a6c 5259 2f61 7864 6450 6c46 3236 6248 jlRY/axddPlF26bH
+00000fb0: 7765 6d69 574f 4a77 752f 496e 4543 676d wemiWOJwu/InECgm
00000fc0: 3248 3635 6b78 555a 4451 5853 5f30 2f61 2H65kxUZDQXS_0/a
00000fd0: 3678 4562 5751 4730 6239 4e6f 4a78 2d35 6xEbWQG0b9NoJx-5
00000fe0: 434f 7300 2f6c 6962 3634 2f6c 642d 6c69 COs./lib64/ld-li
```
```
--- acat.snowflake-client.xxd 2021-01-18 16:46:59.973819114 +0000
+++ sysrqb.snowflake-client.xxd 2021-01-18 16:47:07.277832763 +0000
@@ -247,9 +247,9 @@
00000f60: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000f70: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000f80: 0400 0000 5300 0000 0400 0000 476f 0000 ....S.......Go..
-00000f90: 5276 3157 4e58 657a 326b 3931 4e2d 6b51 Rv1WNXez2k91N-kQ
-00000fa0: 3679 6d4d 2f66 6f75 2d5f 5f33 3536 662d 6ymM/fou-__356f-
-00000fb0: 6538 5f6e 3851 344c 592f 6b33 7946 485f e8_n8Q4LY/k3yFH_
+00000f90: 4569 4d4e 4447 5139 4378 6952 5138 384c EiMNDGQ9CxiRQ88L
+00000fa0: 3541 7077 2f76 726b 6157 4d42 6c63 6b65 5Apw/vrkaWMBlcke
+00000fb0: 5064 5737 364f 3842 302f 6b33 7946 485f PdW76O8B0/k3yFH_
00000fc0: 7758 3239 3953 7771 6d59 4d2d 534d 2f62 wX299SwqmYM-SM/b
00000fd0: 6354 4178 4848 7953 7262 2d36 346a 6b37 cTAxHHySrb-64jk7
00000fe0: 7056 7900 2f6c 6962 3634 2f6c 642d 6c69 pVy./lib64/ld-li
```Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40206Delete "Add to top sites" menu item2021-01-16T14:54:11ZMatthew FinkelDelete "Add to top sites" menu itemFenix added a new item on the menu list when browsing a web site: `Add to top sites`. We don't (explicitly) support the Top Site home page, so we should delete or hide this option.Fenix added a new item on the menu list when browsing a web site: `Add to top sites`. We don't (explicitly) support the Top Site home page, so we should delete or hide this option.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40205Prep 10.5a72021-01-22T15:31:11ZMatthew FinkelPrep 10.5a7- [x] tor-browser#40293
- [x] #40204
- [x] tor-browser#40297
- [x] android-components#40036
- [x] fenix#40134
- [x] tor-browser-build#40190
- [x] tor-browser-build#40191
- [x] #40165- [x] tor-browser#40293
- [x] #40204
- [x] tor-browser#40297
- [x] android-components#40036
- [x] fenix#40134
- [x] tor-browser-build#40190
- [x] tor-browser-build#40191
- [x] #40165Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40203Make stdout not buffering in nightly signing script2021-01-14T08:05:17ZGeorg KoppenMake stdout not buffering in nightly signing scriptWe had some [discussion](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40146#note_2721629) about an error log over in #40146 and I think making stdout in our signing script could be helpful when debugging issues.We had some [discussion](https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40146#note_2721629) about an error log over in #40146 and I think making stdout in our signing script could be helpful when debugging issues.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40196Set up nightly builds on tb-build-01.tpo2021-03-08T19:21:11ZboklmSet up nightly builds on tb-build-01.tpoI think we need to do the following things to set up nightly builds on `tb-build-01`:
- [x] add nightly build configuration files in `tor-browser-bundle-testsuite.git` (I opened tor-browser-bundle-testsuite#40015 for this)
- [x] git clon...I think we need to do the following things to set up nightly builds on `tb-build-01`:
- [x] add nightly build configuration files in `tor-browser-bundle-testsuite.git` (I opened tor-browser-bundle-testsuite#40015 for this)
- [x] git clone `tor-browser-bundle-testsuite.git` on `tb-build-01` as the `tb-build` user
- [x] update `TBBTestSuite/TestSuite/TorBrowserBuild.pm` locally to not checkout the master branch of `tor-browser-build` but a specific branch containing the changes for #23631 and rbm#40001 (while they are not yet merged).
- [x] add a tools/prune-old-builds script: #40221
- [x] add a cron job with the `tbb-testsuite` command to start nightly builds, and the `prune-old-builds` command to remove old builds (`tools/ansible/roles/tbb-nightly-build/templates/start-tbb-nightly` can be used as an example)
- [x] check that nightly builds are built, and emails sent
- [x] Set up rsync between tb-build-01 and tbb-nightlies-master: #40228
- [x] Adapt the `sign-nightly` script to be able to fetch builds from a local directory: #40229
- [x] Update TBBTestSuite/TestSuite/RBMBuild.pm to run rsync after each build: tor-browser-bundle-testsuite#40018
- [x] merge #23631 and rbm#40001
- [x] remove the local changes to `TBBTestSuite/TestSuite/TorBrowserBuild.pm` to build the master branch
- [x] update `tools/signing/nightly/config.yml` to fetch builds from the new URL and update nightly gpg key (#40209)
- [x] remove `tools/ansible/roles/tbb-nightly-build` from `tor-browser-build`: #40244
/cc @gkTor Browser: 10.5boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40195repo.spring.io is not usable anymore2022-05-03T17:48:41ZGeorg Koppenrepo.spring.io is not usable anymoreWe get a 401 now when trying to fetch dependencies e.g. for
`tor-onion-proxy-service` from `repo.spring.io`. I suppose that's due to
their [changed
policy](https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io...We get a 401 now when trying to fetch dependencies e.g. for
`tor-onion-proxy-service` from `repo.spring.io`. I suppose that's due to
their [changed
policy](https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020).
Using `jcenter()` instead solves the problem only partially
(`jtorctl-0.2` is still not accounted for with that change).Tor Browser: 10.5Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40194Remove var/osname part in cbindgen filename2021-01-14T20:57:42ZGeorg KoppenRemove var/osname part in cbindgen filename`cbindgen` is a host tool we use when building Firefox/GeckoView. There
is no need to include the `var/osname` in it. In particular, as that
prevents building `cbindgen` just once and using the build artifact for
more than one target.`cbindgen` is a host tool we use when building Firefox/GeckoView. There
is no need to include the `var/osname` in it. In particular, as that
prevents building `cbindgen` just once and using the build artifact for
more than one target.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40193Build all mobile Rust targets in a single compilation step2021-01-14T20:57:42ZGeorg KoppenBuild all mobile Rust targets in a single compilation stepWhile we can't use more than one `--target` argument we can
comma-separate the Rust targets we want to build. Thus, no need to
compile five times e.g LLVM just to build Rust for all platforms.
(Note: In principle this works for desktop,...While we can't use more than one `--target` argument we can
comma-separate the Rust targets we want to build. Thus, no need to
compile five times e.g LLVM just to build Rust for all platforms.
(Note: In principle this works for desktop, too, but the different
toolchains needed for the different platforms makes this (slightly) more
complicated. So, we start with mobile-only here first)Tor Browser: 10.5Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40191Update components for switch to mozilla85-based Fenix2021-01-15T18:38:33ZMatthew FinkelUpdate components for switch to mozilla85-based FenixTor Browser: 10.5Georg KoppenGeorg Koppen