tor-browser-build issueshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues2020-09-14T12:15:14Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40088Use MOZ_BUILD_DATE for extension manifest timestamps2020-09-14T12:15:14ZGeorg KoppenUse MOZ_BUILD_DATE for extension manifest timestampsIn fenix#40042 we add the option to overwrite the `Date()` call with
some generated build date making use of `MOZ_BUILD_DATE`. We need to
actually set that env variable in our build script, though.In fenix#40042 we add the option to overwrite the `Date()` call with
some generated build date making use of `MOZ_BUILD_DATE`. We need to
actually set that env variable in our build script, though.Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/4008710.0a7-build1 non-determinism2020-09-13T19:35:41ZMatthew Finkel10.0a7-build1 non-determinismFrom #40073, it seems like the order in which the https-everywhere files were added into `Browser/omni.ja` was not deterministic on two computers.
[tor-browser-linux64-10.0a7_ar.tar.xz.diff](/uploads/be1c423820bb423185f90a0f551162d0/tor...From #40073, it seems like the order in which the https-everywhere files were added into `Browser/omni.ja` was not deterministic on two computers.
[tor-browser-linux64-10.0a7_ar.tar.xz.diff](/uploads/be1c423820bb423185f90a0f551162d0/tor-browser-linux64-10.0a7_ar.tar.xz.diff)Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40086classes2.dex is not reproducible in Fenix2020-10-02T17:23:02ZGeorg Koppenclasses2.dex is not reproducible in FenixThere is a big diff between `classes2.dex` for two Fenix builds. It is
attached.
[diff.bz2](/uploads/2246bee9e5d293f065ff1822e77d91f7/diff.bz2)There is a big diff between `classes2.dex` for two Fenix builds. It is
attached.
[diff.bz2](/uploads/2246bee9e5d293f065ff1822e77d91f7/diff.bz2)Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40085classes.dex is not reproducible in Fenix2022-05-06T16:29:04ZGeorg Koppenclasses.dex is not reproducible in Fenix```
--- diff1 2020-09-10 12:56:41.420435344 +0000
+++ diff2 2020-09-10 12:56:45.944473534 +0000
@@ -1,10 +1,10 @@
-00000000: 6465 780a 3033 3500 91ac 4818 cccd df98 dex.035...H.....
-00000010: e66f c93a 13c9 5794 c7d6 5c9e 7675 0e06 .o...```
--- diff1 2020-09-10 12:56:41.420435344 +0000
+++ diff2 2020-09-10 12:56:45.944473534 +0000
@@ -1,10 +1,10 @@
-00000000: 6465 780a 3033 3500 91ac 4818 cccd df98 dex.035...H.....
-00000010: e66f c93a 13c9 5794 c7d6 5c9e 7675 0e06 .o.:..W...\.vu..
+00000000: 6465 780a 3033 3500 2caa 318d 2cde 4f25 dex.035.,.1.,.O%
+00000010: 1f36 9bd8 6008 46ce a75a 692c 3fce f46b .6..`.F..Zi,?..k
00000020: a475 8100 7000 0000 7856 3412 0000 0000 .u..p...xV4.....
00000030: 0000 0000 c874 8100 8aef 0000 7000 0000 .....t......p...
00000040: 5d27 0000 98be 0300 9f33 0000 0c5c 0400 ]'.......3...\..
00000050: 2bf9 0000 80c7 0600 94d9 0000 d890 0e00 +...............
00000060: fb20 0000 785d 1500 ccf8 6700 d87c 1900 . ..x]....g..|..
00000070: e06a 5700 e26a 5700 256b 5700 906b 5700 .jW..jW.%kW..kW.
00000080: 936b 5700 a56b 5700 b76b 5700 c96b 5700 .kW..kW..kW..kW.
00000090: dd6b 5700 f46b 5700 0c6c 5700 246c 5700 .kW..kW..lW.$lW.
@@ -466021,17 +466021,17 @@
0071c640: 7c5f 5f00 017d 0002 7d0a 000d 7d20 4672 |__..}..}...} Fr
0071c650: 6167 6d65 6e74 7320 2800 137d 2056 6965 agments (..} Vie
0071c660: 774d 6f64 656c 5374 6f72 6573 2028 0003 wModelStores (..
0071c670: 7d2c 2000 027d 4000 027d 5b00 027d 5d00 }, ..}@..}[..}].
0071c680: 027d 7d00 017e 0058 7e7e 5238 7b22 636f .}}..~.X~~R8{"co
0071c690: 6d70 696c 6174 696f 6e2d 6d6f 6465 223a mpilation-mode":
0071c6a0: 2272 656c 6561 7365 222c 226d 696e 2d61 "release","min-a
0071c6b0: 7069 223a 3231 2c22 7067 2d6d 6170 2d69 pi":21,"pg-map-i
-0071c6c0: 6422 3a22 6130 6538 3738 6122 2c22 7665 d":"a0e878a","ve
+0071c6c0: 6422 3a22 3430 3436 3266 3422 2c22 7665 d":"40462f4","ve
0071c6d0: 7273 696f 6e22 3a22 312e 352e 3638 227d rsion":"1.5.68"}
0071c6e0: 0001 7f00 01c2 a300 3fc3 80c3 81c3 82c3 ........?.......
0071c6f0: 83c3 84c3 85c3 86c3 87c3 88c3 89c3 8ac3 ................
0071c700: 8bc3 8cc3 8dc3 8ec3 8fc3 90c3 91c3 92c3 ................
0071c710: 93c3 94c3 95c3 96c3 97c3 98c3 99c3 9aef ................
0071c720: bfba 1c1d 1ec3 9bc3 9cc3 9dc3 9ec3 9fc2 ................
0071c730: aac2 acc2 b1c2 b2c2 b3c2 b5c2 b9c2 bac2 ................
0071c740: bcc2 bdc2 bec2 80c2 81c2 82c2 83c2 84c2 ................
```Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40084Generation of AndroidManifest.xml is not reproducible2023-08-17T16:20:24ZGeorg KoppenGeneration of AndroidManifest.xml is not reproducibleWhen building Fenix twice the decompiled `AndroidManifest.xml` is the
same, yet the compiled one, not:
```
< 000046e0: 0800 0010 891a 2678 a800 0000 2d00 0000 ......&x....-...
---
> 000046e0: 0800 0010 911a 2678 a800 0000 2d00 0000 ......When building Fenix twice the decompiled `AndroidManifest.xml` is the
same, yet the compiled one, not:
```
< 000046e0: 0800 0010 891a 2678 a800 0000 2d00 0000 ......&x....-...
---
> 000046e0: 0800 0010 911a 2678 a800 0000 2d00 0000 ......&x....-...
```Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40083Timestamp is embedded in extension manifest files2020-09-14T07:33:29ZGeorg KoppenTimestamp is embedded in extension manifest filesInspecting two Fenix .apk files one can see:
```
diff -r 1/test/assets/extensions/ads/manifest.json
2/test/assets/extensions/ads/manifest.json
9c9
< "version": "57.0.0.0910095351",
---
> "version": "57.0.0.0910102701",
diff -r 1/test...Inspecting two Fenix .apk files one can see:
```
diff -r 1/test/assets/extensions/ads/manifest.json
2/test/assets/extensions/ads/manifest.json
9c9
< "version": "57.0.0.0910095351",
---
> "version": "57.0.0.0910102701",
diff -r 1/test/assets/extensions/cookies/manifest.json
2/test/assets/extensions/cookies/manifest.json
9c9
< "version": "57.0.0.0910095351",
---
> "version": "57.0.0.0910102701",
```
The versions stem from a respective `manifest.template.json` which gets
processed in `app/build.gradle` like
```
def values = ['version': AndroidComponents.VERSION + "." + new
Date().format('MMddHHmmss')]
```Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40082Fenix reproducibility issues2020-10-03T07:24:06ZGeorg KoppenFenix reproducibility issuesThis is the parent ticket for tracking Fenix reproducibility issues.
- [x] #33935
- [x] android-components#40013
- [x] fenix#40042
- [x] #40084
- [x] #40085
- [x] #40086
- [x] #40088
- [x] #40117This is the parent ticket for tracking Fenix reproducibility issues.
- [x] #33935
- [x] android-components#40013
- [x] fenix#40042
- [x] #40084
- [x] #40085
- [x] #40086
- [x] #40088
- [x] #40117Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40078Bump Gradle version for Fenix to 6.5.12020-09-10T15:54:24ZGeorg KoppenBump Gradle version for Fenix to 6.5.1While we did not look did Mozilla bump Fenix's Gradle version to 6.5.1.
We should do the same.
Thanks, cypherpunk!While we did not look did Mozilla bump Fenix's Gradle version to 6.5.1.
We should do the same.
Thanks, cypherpunk!Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40076Use our android-components repo on GitLab2020-09-04T17:46:09ZMatthew FinkelUse our android-components repo on GitLabLet's point at our hosted repo.Let's point at our hosted repo.Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40075Modify Android-Components WebExtensions Menu2020-09-11T13:37:42ZMatthew FinkelModify Android-Components WebExtensions MenuAs described here by @acat https://gitlab.torproject.org/tpo/applications/fenix/-/merge_requests/6#note_2707418As described here by @acat https://gitlab.torproject.org/tpo/applications/fenix/-/merge_requests/6#note_2707418Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40074Integrate "Disable PWA" android-components patch2020-09-10T17:44:36ZMatthew FinkelIntegrate "Disable PWA" android-components patchInclude android-components#40001Include android-components#40001Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40073Repack omni.ja to include the unzipped https-everywhere extension2020-11-19T14:47:32ZAlex CatarineuRepack omni.ja to include the unzipped https-everywhere extensionThis should go together with tor-browser#40091. For desktop, we need to make the https-everywhere extension contents accessible from `resource://torbutton/content/extensions/https-everywhere/` (at least with the current tor-browser#40091...This should go together with tor-browser#40091. For desktop, we need to make the https-everywhere extension contents accessible from `resource://torbutton/content/extensions/https-everywhere/` (at least with the current tor-browser#40091 patch). So, we should repack `omni.ja` and unzip the `https-everywhere` xpi to `chrome/torbutton/content/extensions/https-everywhere/`.Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40072Tor libraries are missing in final .apk after switch to 81.1.0b12020-09-10T15:21:26ZGeorg KoppenTor libraries are missing in final .apk after switch to 81.1.0b1While preparing patches for #40055 and #40068 I realized that suddenly the Tor related artifacts do not seem to get picked up during build anymore and are therefore missing in the final .apk.
I double-checked that the `tor-onion-service...While preparing patches for #40055 and #40068 I realized that suddenly the Tor related artifacts do not seem to get picked up during build anymore and are therefore missing in the final .apk.
I double-checked that the `tor-onion-service-library` and `tor-android-service` artifacts included are a) still properly copied over to the /app directory and b) that they still contain the dependencies we need for the final .apk.Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40068Bump versions for Fenix 81.1.0b1 dependencies2020-09-04T15:33:46ZGeorg KoppenBump versions for Fenix 81.1.0b1 dependenciesWe need to bump the dependencies for Fenix 81.1.0b1 and make sure the
result still compiles and runs.
The GeckoView part is already done and handled in #40062.
- [x] fenix#40029We need to bump the dependencies for Fenix 81.1.0b1 and make sure the
result still compiles and runs.
The GeckoView part is already done and handled in #40062.
- [x] fenix#40029Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40066Remove default bridge 37.218.240.342020-09-01T18:15:32ZPhilipp Winterphw@torproject.orgRemove default bridge 37.218.240.34The bridge's operator informed us that their HK-based colocation (which includes this bridge) will be shut down.The bridge's operator informed us that their HK-based colocation (which includes this bridge) will be shut down.Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40065Bump debootstrap-image ubuntu_version to 20.04.12020-09-01T09:57:37ZAlex CatarineuBump debootstrap-image ubuntu_version to 20.04.119.10 reached EOL https://lists.ubuntu.com/archives/ubuntu-announce/2020-July/000258.html, so we should move to 20.04.19.10 reached EOL https://lists.ubuntu.com/archives/ubuntu-announce/2020-July/000258.html, so we should move to 20.04.Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40062Mach is breaking when building GeckoView based on 81.0b22020-09-04T06:53:34ZGeorg KoppenMach is breaking when building GeckoView based on 81.0b2https://bugzilla.mozilla.org/show_bug.cgi?id=1656993 makes it necessary
to run either `./mach create-mach-environment` or set
`MACH_USE_SYSTEM_PYTHON`. The former is not easily for us to do as
missing Python packages need to get download...https://bugzilla.mozilla.org/show_bug.cgi?id=1656993 makes it necessary
to run either `./mach create-mach-environment` or set
`MACH_USE_SYSTEM_PYTHON`. The former is not easily for us to do as
missing Python packages need to get downloaded which breaks as we don't
allow that. So, we stick for now with the environment variableTor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40061Remove Android SDK 282020-09-07T06:33:12ZGeorg KoppenRemove Android SDK 28Fenix has [moved to target Android
10](https://gitlab.torproject.org/tpo/applications/fenix/-/commit/c99a8f5cfafa816bfe8645ee21e2afa89eb394e1)
which allows us to simplify our toolchain.
Thanks cypherpunk for pointing that out.Fenix has [moved to target Android
10](https://gitlab.torproject.org/tpo/applications/fenix/-/commit/c99a8f5cfafa816bfe8645ee21e2afa89eb394e1)
which allows us to simplify our toolchain.
Thanks cypherpunk for pointing that out.Tor Browser: 10.0Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40060Set Fenix Version Name in build2020-09-30T19:20:21ZMatthew FinkelSet Fenix Version Name in buildBy default, the app `versionName` is not set. Fennec uses the Firefox version name as the versionName.
Mozilla releases `Nightly` with the name `Nightly $date $time` (where date is YYYYMMDD, and time is HH:MM). See
https://gitlab.torpr...By default, the app `versionName` is not set. Fennec uses the Firefox version name as the versionName.
Mozilla releases `Nightly` with the name `Nightly $date $time` (where date is YYYYMMDD, and time is HH:MM). See
https://gitlab.torproject.org/tpo/applications/fenix/-/blob/tor-browser-80.0b6-10-1/taskcluster/fenix_taskgraph/transforms/build.py#L85
and some "version" config for beta/release:
https://gitlab.torproject.org/tpo/applications/fenix/-/blob/tor-browser-80.0b6-10-1/taskcluster/fenix_taskgraph/transforms/build.py#L98
I *think* they're just using the Fenix git tag (without the leading `v`) as the name (the current Firefox Beta has the `versionName` as `80.0.1-beta.2`).Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40057Include translations into build process in the fenix world2020-10-07T00:36:26ZGeorg KoppenInclude translations into build process in the fenix worldWe used to have mobile translations included into the firefox project
build. However, with the move to Fenix that part needs to find a new home.
- [x] https://gitlab.torproject.org/tpo/community/l10n/-/issues/40005We used to have mobile translations included into the firefox project
build. However, with the move to Fenix that part needs to find a new home.
- [x] https://gitlab.torproject.org/tpo/community/l10n/-/issues/40005Tor Browser: 10.0Georg KoppenGeorg Koppen