tor-browser-build issueshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues2020-12-13T21:34:10Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40145Adapt Makefile to build from a single alpha tag for all platforms again2020-12-13T21:34:10ZGeorg KoppenAdapt Makefile to build from a single alpha tag for all platforms againWe are reducing our chaos caused by a load of different branches in the wake of the ESR and regular Firefox release channel split.
It's therefore time revert the changes in our `Makefile` that introduced a separate mobile alpha build ta...We are reducing our chaos caused by a load of different branches in the wake of the ESR and regular Firefox release channel split.
It's therefore time revert the changes in our `Makefile` that introduced a separate mobile alpha build target.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40138Move nightly signing key to tor-browser2022-04-04T17:53:05ZGeorg KoppenMove nightly signing key to tor-browserWhen fixing tor-browser#33803 we should make sure that the current nightly signing key is moved out of `tor-browser-build` as well (see: https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33803#note_2671931).When fixing tor-browser#33803 we should make sure that the current nightly signing key is moved out of `tor-browser-build` as well (see: https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33803#note_2671931).Tor Browser: 10.5Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40133Bump Rust to 1.43.0 for ESR 782020-11-08T15:37:32ZGeorg KoppenBump Rust to 1.43.0 for ESR 78While looking at the [minimum required Rust
version](https://searchfox.org/mozilla-esr78/source/python/mozboot/mozboot/base.py#161)
to build ESR 78 (1.41.1) I somehow missed that Mozilla is
[actually](https://bugzilla.mozilla.org/show_bu...While looking at the [minimum required Rust
version](https://searchfox.org/mozilla-esr78/source/python/mozboot/mozboot/base.py#161)
to build ESR 78 (1.41.1) I somehow missed that Mozilla is
[actually](https://bugzilla.mozilla.org/show_bug.cgi?id=1632723)
building ESR 78 with
[1.43.0](https://wiki.mozilla.org/Rust_Update_Policy_for_Firefox). We
should do the same to minimize toolchain differences between official
Firefox and Tor Browser builds.
Thanks to a cypherpunk for the reminder.Tor Browser: 10.5Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40128Do script for packaging and updating allowed_addons.json for Fenix2020-12-04T14:48:15ZAlex CatarineuDo script for packaging and updating allowed_addons.json for FenixFor fenix#40062 we shipped a default `allowed_addons.json` containing a list of allowed addons fetched from mozilla. We should create a script for keeping this list up-to-date and replace the default one from Fenix. We could also check t...For fenix#40062 we shipped a default `allowed_addons.json` containing a list of allowed addons fetched from mozilla. We should create a script for keeping this list up-to-date and replace the default one from Fenix. We could also check that the https-everywhere and noscript versions in this file are consistent with the ones we ship.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40112libstdc++.so.6 not stripped2021-01-20T18:56:24Zyanmaanilibstdc++.so.6 not strippedIn `tor-browser-build/projects/tor/build`, `libstdc++.so.6` is copied from GCC to the output:
```
# We need to copy the libstdc++.so.6 for Tor Browser on older Linux distros.
# Copying it into /Browser, which feels more natural, and ...In `tor-browser-build/projects/tor/build`, `libstdc++.so.6` is copied from GCC to the output:
```
# We need to copy the libstdc++.so.6 for Tor Browser on older Linux distros.
# Copying it into /Browser, which feels more natural, and amending
# LD_LIBRARY_PATH breaks updates from a Tor Browser with the old
# LD_LIBRARY_PATH value to the Tor Browser with the newer one. Thus, we copy
# the libstdc++ into the directory with the libs tor depends on, too. See bug
# 13359 for further details.
mkdir -p "$distdir/Tor/libstdc++"
cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libstdc++.so.6 "$distdir/Tor/libstdc++/"
[% IF c("var/asan") -%]
cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libasan.so.5 "$distdir/Tor/"
cp /var/tmp/dist/gcc/[% c("var/libdir") %]/libubsan.so.1 "$distdir/Tor/"
[% END -%]
chmod 700 "$distdir"/Tor/*.so*
chmod 700 "$distdir"/Tor/libstdc++/*.so*
```
This file is unstripped and contains debug info. Stripping it takes it from 17 MB to 2 MB, without any impact on functionality as far as I can tell. After compression, the entire tarball is 3MB smaller.
This should be a one-line change, provided `strip` is deterministic. I haven't looked into it.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/4010310.5a1-build1 firefox-linux-i686 busted due to missing pulse2020-09-19T21:32:49ZMatthew Finkel10.5a1-build1 firefox-linux-i686 busted due to missing pulse```
0:24.70 checking for libpulse... no
0:24.70 ERROR: Package libpulse was not found in the pkg-config search path.
0:24.70 ERROR: Perhaps you should add the directory containing `libpulse.pc'
0:24.70 ERROR: to the PKG_CONFIG_PATH e...```
0:24.70 checking for libpulse... no
0:24.70 ERROR: Package libpulse was not found in the pkg-config search path.
0:24.70 ERROR: Perhaps you should add the directory containing `libpulse.pc'
0:24.70 ERROR: to the PKG_CONFIG_PATH environment variable
0:24.70 ERROR: No package 'libpulse' found
0:24.76 *** Fix above errors and then restart with\
0:24.76 "./mach build"
0:24.76 client.mk:111: recipe for target 'configure' failed
0:24.76 make: *** [configure] Error 1
```Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40081Build with --enable-rust-simd2020-12-01T17:28:58ZGeorg KoppenBuild with --enable-rust-simdA cypherpunk pointed out that Mozilla ships their builds with
`--enable-rust-simd` and indeed if one downloads the source and builds
it then this option is not set but ["It is the default for CI and for
the builds we
ship."](https://bugz...A cypherpunk pointed out that Mozilla ships their builds with
`--enable-rust-simd` and indeed if one downloads the source and builds
it then this option is not set but ["It is the default for CI and for
the builds we
ship."](https://bugzilla.mozilla.org/show_bug.cgi?id=1578677#c4)
We should set it to, then.Tor Browser: 10.5https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40064Bump libevent to 2.1.122020-11-08T19:33:28ZGeorg KoppenBump libevent to 2.1.12Libevent 2.1.12 got a released a couple of weeks ago. We should start
using that one instead of 2.1.11.
- [x] #26238Libevent 2.1.12 got a released a couple of weeks ago. We should start
using that one instead of 2.1.11.
- [x] #26238Tor Browser: 10.5Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40041Remove Centos 6 support for Tor Browser 10.52020-09-18T20:37:38ZGeorg KoppenRemove Centos 6 support for Tor Browser 10.5There are CentOS 6 bits in our tor-browser-build parts that we should
remove (there is at least the one in `start-firefox`) for 10.5.There are CentOS 6 bits in our tor-browser-build parts that we should
remove (there is at least the one in `start-firefox`) for 10.5.Tor Browser: 10.5Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/34360Bump binutils version to 2.35.12021-12-21T08:54:46ZGeorg KoppenBump binutils version to 2.35.1We are using a rather old binutils version. Let's bump it to the latest, 2.35.1We are using a rather old binutils version. Let's bump it to the latest, 2.35.1Tor Browser: 10.5Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/34108Write script to keep track of toolchain changes2021-06-22T14:26:54ZGeorg KoppenWrite script to keep track of toolchain changesWe have a lot of different requirements for our toolchain (see: legacy/trac#33557) due to a number of different projects involved in building Fenix. We should write a script that we run periodically to keep track of necessary toolchain c...We have a lot of different requirements for our toolchain (see: legacy/trac#33557) due to a number of different projects involved in building Fenix. We should write a script that we run periodically to keep track of necessary toolchain changes ahead of time.Tor Browser: 10.5boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/26238Move from Debian Wheezy to Debian Jessie for our Linux builds2020-10-03T07:49:50ZGeorg KoppenMove from Debian Wheezy to Debian Jessie for our Linux buildsDebian Wheezy is about to get unsupported and we should move to Debian Jessie for our Linux builds. This has the additional advantage that we don't have different Debian versions anymore to build bundles for all of our supported platform...Debian Wheezy is about to get unsupported and we should move to Debian Jessie for our Linux builds. This has the additional advantage that we don't have different Debian versions anymore to build bundles for all of our supported platforms: We are then using Debian Jessie everywhere.
The only worrying situation is the CentOS one. We should think about whether we still can and want to support CentOS 6 (which we need to do anyway while switching to Firefox ESR 60 which requires GTK3) and what the CentOS 7 situation is if we start building using Jessie.
- [x] #40041
- [x] tor-browser#40089Tor Browser: 10.5Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/23631Improve sudo need2021-03-01T16:46:05ZTom Rittertom@ritter.vgImprove sudo needRight now the Tor Browser build takes a long time, and sudo is needed periodically throughout it. This means you have to either run it as root, babysit it, or set your user account up with passwordless sudo. All of those kinda stink.
It...Right now the Tor Browser build takes a long time, and sudo is needed periodically throughout it. This means you have to either run it as root, babysit it, or set your user account up with passwordless sudo. All of those kinda stink.
It's be cool if we could improve that a bit. Ideas:
- Write a setuid program that execs the necessary commands but provides input and directory filtering (directory path either compiled in or read from a root-owned file I guess)
- Same idea but instead of setuid, it's set up to be run with passwordless sudo
- Somehow request sudo access in the beginning and retain it through the whole script (without running everything as root)Tor Browser: 10.5boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40399Bring Noto Sans Gurmukhi and Sinhala back2022-01-06T21:18:40ZPier Angelo VendrameBring Noto Sans Gurmukhi and Sinhala backWe removed these fonts because we initially thought they were the cause of #40387.
However, with tor-browser#40685 solved, we should be able to bring them back.We removed these fonts because we initially thought they were the cause of #40387.
However, with tor-browser#40685 solved, we should be able to bring them back.Tor Browser: 11.0 Issues with previous releasePier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40395Adapt NodeJS for ESR 912022-01-14T10:33:21ZGeorg KoppenAdapt NodeJS for ESR 91We have #40005 for ESR 78 but I am not sure why we don't had something similar for 11.0 but we should: https://bugzilla.mozilla.org/show_bug.cgi?id=1690377.
(Thanks to the rambling cypherpunk).We have #40005 for ESR 78 but I am not sure why we don't had something similar for 11.0 but we should: https://bugzilla.mozilla.org/show_bug.cgi?id=1690377.
(Thanks to the rambling cypherpunk).Tor Browser: 11.0 Issues with previous releaseboklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40389Remove workaround deployed in #403832021-12-20T11:03:11ZGeorg KoppenRemove workaround deployed in #40383It seems @pierov found the underlying bug for our HTTPS-Everywhere WASM issue. See: https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40721. We therefore should remove the workaround we implemented in #40383.It seems @pierov found the underlying bug for our HTTPS-Everywhere WASM issue. See: https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40721. We therefore should remove the workaround we implemented in #40383.Tor Browser: 11.0 Issues with previous releaseGeorg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40387Tor Browser: Fonts of the GUI (Menu, Bookmarks, ...) do not render after Update2021-12-20T11:14:33ZqawseTor Browser: Fonts of the GUI (Menu, Bookmarks, ...) do not render after UpdateThe following image say it all:
- the web pages are rendered normally
- every text of the Browser (menu, bookmarks, popup about, a.s.o) are broken
![image](/uploads/4eeaf9797dbd8d607b1a0ac735ad6432/image.png)
My system: Fedora release ...The following image say it all:
- the web pages are rendered normally
- every text of the Browser (menu, bookmarks, popup about, a.s.o) are broken
![image](/uploads/4eeaf9797dbd8d607b1a0ac735ad6432/image.png)
My system: Fedora release 33 (Thirty Three).
The version of the browser should appear on the picture.
The system has been updated and rebooted after the issue appeared (today).Tor Browser: 11.0 Issues with previous releasePier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40382Fonts don't render2022-05-05T14:06:11ZMatthew FinkelFonts don't renderhttps://blog.torproject.org/comment/293017#comment-293017
https://blog.torproject.org/comment/293052#comment-293052
![blogfonts](/uploads/5b09bc13df568968aff99e598fd85bae/blogfonts.png)https://blog.torproject.org/comment/293017#comment-293017
https://blog.torproject.org/comment/293052#comment-293052
![blogfonts](/uploads/5b09bc13df568968aff99e598fd85bae/blogfonts.png)Tor Browser: 11.0 Issues with previous releasePier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40355Nightly builds (starting with 08/28/2021) are not bootstrapping anymore2021-08-31T00:47:31ZGeorg KoppenNightly builds (starting with 08/28/2021) are not bootstrapping anymoreI think it's either Torbutton/Tor Launcher async changes that landed or the fixes for tor-browser#40597. I've not checked but suspect the former which are needed for esr91.
/cc @richard.
This is happening on Linux and I did not check o...I think it's either Torbutton/Tor Launcher async changes that landed or the fixes for tor-browser#40597. I've not checked but suspect the former which are needed for esr91.
/cc @richard.
This is happening on Linux and I did not check other platforms.Tor Browser: 11.0 Issues with previous releasehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40352Create desktop-only (Windows/macOS/Linux) Makefile rules2021-09-07T20:19:04ZMatthew FinkelCreate desktop-only (Windows/macOS/Linux) Makefile rulesWe did this in c5431b7c2fff0e98580ebfe795e12bcef9ab0370, but we lost it when we stablized `10.5`. We should add it again, except this time onto `master` and then backport onto `maint-10.5`.We did this in c5431b7c2fff0e98580ebfe795e12bcef9ab0370, but we lost it when we stablized `10.5`. We should add it again, except this time onto `master` and then backport onto `maint-10.5`.Tor Browser: 11.0 Issues with previous release