Skip to content

GitLab

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (duplicated)
Created by Matthew Finkel@sysrqbDeveloper

Android Tor Browser build file requires more specific glob for x86

The error message is:

Unexpected parameter(s) after --in: /var/tmp/tmp.uuChEVShrP/fenix/app-x86_64-beta-unsigned.apk
Build log: /home/user/tor-browser-build/logs/tor-browser-android-x86.log                                                                                                 
Error running build
Opening debug shell
Warning: build files will be removed when you exit this shell.
Container directory: /home/user/tor-browser-build/tmp/rbm-O4dwF8/rbm-containers/ed98ce595286ff0d59659580ae671ab27935cb36147b30e937d9f14a22e0b3cb                         
/bin/sh: 0: can't access tty; job control turned off
debug-tor-browser$ ls
android-qa.keystore  build  container-image_buster-amd64-d9275b7eb691.tar.gz  fenix  fenix-2ae11ff949bd-75b07c.tar.gz  https-everywhere-2020.8.13-53dcf7.xpi                                               
debug-tor-browser$ ls fenix/
app-arm64-v8a-beta-unsigned.apk  app-armeabi-v7a-beta-unsigned.apk  app-x86-beta-unsigned.apk  app-x86_64-beta-unsigned.apk

The templated build file contains:

apk=$rootdir/fenix/app-[% c("var/abi") %]*.apk

and that becomes:

apk=$rootdir/fenix/app-x86*.apk

Unfortunately, this matches x86_64, too.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information