Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
tor-browser-build
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 196
    • Issues 196
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Applications
  • tor-browser-build
  • Issues
  • #40151

Closed (duplicated)
Open
Opened Nov 11, 2020 by Alex Catarineu@acatDeveloper

Android builds for 10.5a3 differ

I got slightly different apks than @gk ones. I ran a few checks: zipcmp gk/tor-browser-10.5a3-android-x86-multi-qa.apk acat/tor-browser-10.5a3-android-x86-multi-qa.apk

-       1194 be7dcb34 META-INF/ANDROIDQ.RSA
+       1194 d6fda0f7 META-INF/ANDROIDQ.RSA
-     259467 36702dd1 META-INF/ANDROIDQ.SF
+     259467 5703faf0 META-INF/ANDROIDQ.SF
+     259424 3444b186 META-INF/MANIFEST.MF
-     259424 4668e970 META-INF/MANIFEST.MF
-    8519520 a6153309 classes.dex
+    8519520 100dcb4c classes.dex
-    2873052 501b0a28 classes2.dex
+    2873136 5be103d1 classes2.dex

diff <(apkanalyzer dex packages gk/tor-browser-10.5a3-android-x86-multi-qa.apk) <(apkanalyzer dex packages acat/tor-browser-10.5a3-android-x86-multi-qa.apk)

1c1
< P d 65410	72878	9255326	<TOTAL>
---
> P d 65411	72879	9255387	<TOTAL>
54295,54296c54295,54296
< P d 16156	16377	2086496	org
< P d 14787	14898	1893092	org.mozilla
---
> P d 16157	16378	2086557	org
> P d 14788	14899	1893153	org.mozilla
76546c76546
< P d 2263	2266	268503	org.mozilla.geckoview
---
> P d 2264	2267	268564	org.mozilla.geckoview
77242c77242
< C d 38	38	4724	org.mozilla.geckoview.GeckoResult
---
> C d 39	39	4790	org.mozilla.geckoview.GeckoResult
77261a77262
> M d 1	1	66	org.mozilla.geckoview.GeckoResult org.mozilla.geckoview.GeckoResult lambda$accept$0(org.mozilla.geckoview.GeckoResult$Consumer,java.lang.Object)
80179c80180
< C d 2	2	189	org.mozilla.geckoview.-$$Lambda$GeckoResult$I3k4K0DCRrX6z4p5VGaRoaRBTZM
---
> C d 2	2	184	org.mozilla.geckoview.-$$Lambda$GeckoResult$I3k4K0DCRrX6z4p5VGaRoaRBTZM
80181c80182
< M d 1	1	68	org.mozilla.geckoview.-$$Lambda$GeckoResult$I3k4K0DCRrX6z4p5VGaRoaRBTZM org.mozilla.geckoview.GeckoResult onValue(java.lang.Object)
---
> M d 1	1	63	org.mozilla.geckoview.-$$Lambda$GeckoResult$I3k4K0DCRrX6z4p5VGaRoaRBTZM org.mozilla.geckoview.GeckoResult onValue(java.lang.Object)

diff <(apkanalyzer dex code --class org.mozilla.geckoview.GeckoResult gk/tor-browser-10.5a3-android-x86-multi-qa.apk) <(apkanalyzer dex code --class org.mozilla.geckoview.GeckoResult acat/tor-browser-10.5a3-android-x86-multi-qa.apk)

> .method static synthetic lambda$accept$0(Lorg/mozilla/geckoview/GeckoResult$Consumer;Ljava/lang/Object;)Lorg/mozilla/geckoview/GeckoResult;
>     .registers 2
> 
>     .line 1
>     invoke-interface {p0, p1}, Lorg/mozilla/geckoview/GeckoResult$Consumer;->accept(Ljava/lang/Object;)V
> 
>     const/4 p0, 0x0
> 
>     return-object p0
> .end method
>

So, I think the only difference is that the code of org.mozilla.geckoview.GeckoResult in my apk has:

.method static synthetic lambda$accept$0(Lorg/mozilla/geckoview/GeckoResult$Consumer;Ljava/lang/Object;)Lorg/mozilla/geckoview/GeckoResult;
    .registers 2

    .line 1
    invoke-interface {p0, p1}, Lorg/mozilla/geckoview/GeckoResult$Consumer;->accept(Ljava/lang/Object;)V

    const/4 p0, 0x0

    return-object p0
.end method

.method static synthetic lambda$accept$1(Lorg/mozilla/geckoview/GeckoResult$Consumer;Ljava/lang/Throwable;)Lorg/mozilla/geckoview/GeckoResult;
    .registers 2

    .line 1
    invoke-interface {p0, p1}, Lorg/mozilla/geckoview/GeckoResult$Consumer;->accept(Ljava/lang/Object;)V

    const/4 p0, 0x0

    return-object p0
.end method

While in gk's one the accept$0 is not there (optimized out?)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor Browser: 10.5
Milestone
Tor Browser: 10.5
Assign milestone
Time tracking
None
Due date
None
Reference: tpo/applications/tor-browser-build#40151